Pick all units to determine Damage, and some Special Effects

[DM Cross]

I'm having a problem with this trigger I'm using to pick all units in the map at casting so that number will determine how much damage an ability does. Here's the code I tried:

Bomb
    Events
        Unit - A unit Begins casting an ability
    Conditions
        (Ability being cast) Equal to Bomb
    Actions
        Set BombDamage = ((Real((Number of units in (Units in (Playable map area))))) x 10.00)
        Set BombTarget = (Target point of ability being cast)
        Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
            Loop - Actions
                Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Undead\DarkRitual\DarkRitualTarget.mdl
        Wait 9.75 seconds
        Special Effect - Create a special effect at BombTarget using Units\Demon\Infernal\InfernalBirth.mdl
        Wait 2.00 seconds
        Special Effect - Destroy (Last created special effect)
        Special Effect - Destroy BombEffect
        Unit Group - Pick every unit in (Units within 500.00 of BombTarget) and do (Actions)
            Loop - Actions
                Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - BombDamage)

BombTarget is a Point variable.
BombDamage is a Real variable. (Should I be using an Integer?)

The special effects work fine. It's the damage that seems to be screwed up, since that's the part my computer froze until I restarted it at.

Also, is it alright that I didn't set the Infernal special effect to a variable, and simply destroyed it 2 seconds after I created it?

I figured this was easier, but didn't know if it was a good or bad idea...

Any help, guys?

 

[xPheRe]

So the problem is with dealing damage, isn't it?
Have you tried with "Unit - Damage area"?
I don't know if it needs the caster to be a certain distance or whatever, but I think it can work.

Unit - Order (Caster) to damage area of size 500.00 at (BombTarget) for BombDamage using attack type Spells and damage type Normal.

 

[Heptameron]

I suggest you destroy every special effect you make the instant after you make it (the next action; this includes in the loop). I believe special effects will finish the animation after they are destroyed. As long as it isn't a looping animation, it's a bit cleaner.

Also, what the heck is BombEffect, and why are you destroying it?

Like xPheRe said, also try using the damage actions instead. (Except I've never gotten Damage Area to work, though I haven't tried very hard at it.)

Otherwise that looks like it should work, as long as you don't cast it twice.

 

[DM Cross]

BombEffect is a special effect variable, as I stated.

Edit
Found the damage area. Sorry, wasn't looking far down enough.

 

[AceHart]

Unit - Order unit to damage ...

Should be the very last thing in the "unit" list (or close to the end, at least).

Careful though, as it damages anything in that area...
For a bomb, that's expected I guess


> BombEffect is a special effect variable

I see no "set BombEffect"?


[EDIT]

 

[Heptameron]

BombEffect is a special effect variable, as I stated.

No, you didn't, and you never set it.

 

[DM Cross]

Oh, you're right... I just forgot about it, I guess, and I set it before I tested, but it froze the comp, anyway -.-

This is what I turned it into:

Bomb
    Events
        Unit - A unit Begins casting an ability
    Conditions
        (Ability being cast) Equal to Bomb
    Actions
        Set BombDamage = ((Number of units in (Units in (Playable map area))) x 10)
        Set BombTarget = (Target point of ability being cast)
        Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
            Loop - Actions
                Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Undead\DarkRitual\DarkRitualTarget.mdl
        Wait 9.75 seconds
        Special Effect - Create a special effect at BombTarget using Units\Demon\Infernal\InfernalBirth.mdl
        Wait 2.00 seconds
        Special Effect - Destroy (Last created special effect)
        Special Effect - Destroy BombEffect
        Unit Group - Pick every unit in (Units within 500.00 of BombTarget) and do (Actions)
            Loop - Actions

Anymore ideas?

 

[Heptameron]

Bomb
    Events
        Unit - A unit Finishes casting an ability
    Conditions
        (Ability being cast) Equal to Bomb
    Actions
        Set BombDamage = ((Number of units in (Units in (Playable map area))) x 10)
        Set BombTarget = (Target point of ability being cast)
        Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
            Loop - Actions
                Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Undead\DarkRitual\DarkRitualTarget.mdl
                Special Effect - Destroy (Last created special effect)
        Wait 9.75 seconds
        Special Effect - Create a special effect at BombTarget using Units\Demon\Infernal\InfernalBirth.mdl
        Special Effect - Destroy (Last created special effect)
        Wait 2.00 seconds
        Unit Group - Pick every unit in (Units within 500.00 of BombTarget) and do (Actions)
            Loop - Actions
                [i]<damage picked unit>[/i]

Try that... although it really shouldn't be crashing.

 

[DM Cross]

SpiritBomb
    Events
        Unit - A unit Finishes casting an ability
    Conditions
        (Ability being cast) Equal to Spirit Bomb (Goku)
    Actions
        Set SpiritBombDamage = ((Real((Number of units in (Units in (Playable map area))))) x 2.00)
        Set SpiritBombTarget = (Target point of ability being cast)
        Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
            Loop - Actions
                Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Undead\DarkRitual\DarkRitualTarget.mdl
                Special Effect - Destroy (Last created special effect)
        Wait 9.75 seconds
        Special Effect - Create a special effect at SpiritBombTarget using Units\Demon\Infernal\InfernalBirth.mdl
        Wait 2.00 seconds
        Special Effect - Destroy (Last created special effect)
        Unit Group - Pick every unit in (Units within 500.00 of SpiritBombTarget) and do (Actions)
            Loop - Actions
                Unit - Order (Casting unit) to damage area in 0.50 seconds of size 500.00 at SpiritBombTarget for SpiritBombDamage using attack type Spells and damage type Normal.

It still crashs. It just manages to crash AFTER the ability ends. And the first special effect doesn't happen until after the ability...

 

[Heptameron]

It still crashs. It just manages to crash AFTER the ability ends. And the first special effect doesn't happen until after the ability...

Try zapping the waits or changing them to game-time waits (which they should be anyway).

 

[DM Cross]

I stripped it down to doing nothing but damage.

Bomb
    Events
        Unit - A unit Finishes casting an ability
    Conditions
        (Ability being cast) Equal to Bomb
    Actions
        Set BombDamage = ((Real((Number of units in (Units in (Playable map area))))) x 2.00)
        Unit Group - Pick every unit in (Units within 500.00 of BombTarget) and do (Actions)
            Loop - Actions
                Unit - Order (Casting unit) to damage area in 0.50 seconds of size 500.00 at BombTarget for BombDamage using attack type Spells and damage type Normal.

Yup, it still crashes. So ... It must be something with the damage, if you want my opinion (not that I really understand it, so yeah...)

Could it be that I'm ordering the casting unit to do more damage then he's capable of doing? Or that the type of damage isn't his type of damage? (The casting unit is a hero, with hero melee damage)

Still need help.

 

[Rinpun]

I think the damage area is flawed. It doesn't matter anyway if you order a unit to attack area or whatever, because it STILL doesn't give gold for killing said unit. That's why I set life of ____ to life of ____ - (damage to be done)

Ordering to damage area of a different type or amount should NOT be the problem

 

[DM Cross]

Gold? Who said anything about gold. If anything, I don't want gold given.

I already tried "Set life of Picked unit to (Life of Picked unit - BombDamage)" or whatever. See the first post.

I still don't know how to write the proper code for this...

 

[Rinpun]

That so? Well that was an issue for CoH, so there

Well, I can't make heads or tails of your graphics. It'd be better if after creation you set a Special Effects Array equal to the effect placed on the targeted units (using an integer that is constantly set to 0). After the wait, you can run a for loop to delete them all.

 

[DM Cross]

The problem isn't with the Special Effects, Rin. I just tore the trigger down, and used NO Special Effects whatsoever, just the damage part, and it didn't work.

I'll keep the stuff you said in mind and all, but... That's not what I need help on.

 

[Rinpun]

Yea? Well, consider removing the DAMAGE doing and see if the graphics still work. I'm actually more convinced the problem is with the ability itself--not the trigger.

Because, to put it simply, I have abilities like these all the time and they work.

 

[DM Cross]

OK, I'll try doing just the graphics, then.

By the way, the ability itself is based of off Flame Strike. All the damage values and stuff were set to 0.

Here's something weird -.- One of the damn data files for Flame Strike is in some Raw code.

Data - WESTRING_AEVAL_HSF6

I... Have no idea what that field is for. Anyone else know?

 

[Rinpun]

Nope, but I preferred leaving that ghost field ALONE. Perhaps if you changed it, you might've damaged something.

And hey, if you set various area settings to 0, you won't be able to target anything. Try 10

 

[Sargon]

Sounds like an area of effect field? Just judging by the AE in it. Maybe not though.

 

[DM Cross]

Whatever it was, that's what was crashing the game. I set it to default and then was able to test it (without the trigger enabled) and it didn't crash!

I'll try to remake the trigger (since I destroyed msot of the damn thing) and see if it works.