Spell Pillar of Lightning

[Ghan]

> Why?

Deleted the globals. Didn't want to rename all the variables in the code.

 

[U are a noob]

Pillar of Lightning
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Pillar of Lightning 
    Actions
        Set TempPoint = ((Target point of ability being cast) offset by (0.00, 0.00))
        Special Effect - Create a special effect at TempPoint using Abilities\Spells\Human\ThunderClap\ThunderClapCaster.mdl
        Special Effect - Destroy (Last created special effect)
        For each (Integer A) from 1 to 10, do (Actions)
            Loop - Actions
                Unit - Create 1 Effect Unit for (Owner of (Triggering unit)) at TempPoint facing Default building facing degrees
                Unit - Order (Last created unit) to Stop
                Animation - Play (Last created unit)'s stand animation
                Set Wisps[(Integer A)] = (Last created unit)
                Animation - Change Wisps[(Integer A)] flying height to (50.00 x ((Real((Integer A))) - 1.00)) at 500.00
        Wait 0.10 seconds
        For each (Integer A) from 1 to LightningIntervals, do (Actions)
            Loop - Actions
                For each (Integer B) from 1 to NumberofTargets, do (Actions)
                    Loop - Actions
                        Custom script:   if (bj_forLoopBIndex == 1 or GetRandomInt(1,100) <= udg_ChanceforBolt) then
                        Unit - Create 1 Effect Unit for (Owner of (Triggering unit)) at TempPoint facing Default building facing degrees
                        Set Caster = (Last created unit)
                        Unit - Hide Caster
                        Unit - Add a 3.00 second Generic expiration timer to Caster
                        Animation - Change Caster flying height to (Random real number between 100.00 and 450.00) at 4000.00
                        Set TempGroup = (Units within BoltRange of TempPoint matching (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True))
                        Set Target = (Random unit from TempGroup)
                        Unit - Order Caster to Orc Far Seer - Chain Lightning Target
                        Custom script:   call DestroyGroup(udg_TempGroup)
                        Custom script:   endif
                Wait (Random real number between 1.00 and 3.00) seconds
        For each (Integer A) from 1 to 10, do (Actions)
            Loop - Actions
                Animation - Change Wisps[(Integer A)] flying height to 0.00 at 300.00
        Wait 2.50 seconds
        For each (Integer A) from 1 to 10, do (Actions)
            Loop - Actions
                Unit - Remove Wisps[(Integer A)] from the game
        Custom script:   call RemoveLocation(udg_TempPoint)

If this is all that is in your spell you can upgrade it to MUI easy.

 

[Ghan]

> If this is all that is in your spell you can upgrade it to MUI easy.

Array-less? Doubt it. Already tried.

The JASS version is MUI. Just use that.

 

[Crapling]

This looks awesome, I'll have to try it out once I get home.

 

[Exide]

exitwhen looping > end

Could be:

exitwhen looping > 10

Anyway, nice spell.

 

[Ghan]

> Could be:

exitwhen looping > 10

Yes. In some cases. Not all. But, I was just going for the MUI, and merely replaced the GUI functions with more efficient ones, but didn't alter the structure a whole lot.

 

[Exide]

>Yes. In some cases. Not all. But, I was just going for the MUI, and merely replaced the GUI functions with more efficient ones, but didn't alter the structure a whole lot.
Also, I noticed that later in the trigger;

set end = LightningIntervals

So I guess it will only work properly on the first loop, and since you're using a variable, 'end', later anyway so what the heck...

 

[Ghan]

Well, at least you're critiquing my code.

That's a good thing.
I thought there'd be more problems with it. (I don't do JASS well - yet.)

I'm surprised so far.

 

[Sim]

> I thought there'd be more problems with it. (I don't do JASS well - yet.)
> I'm surprised so far.

If you insist

> set TempGroup = GetUnitsInRangeOfLocMatching(BoltRange, TempPoint, Condition(function Trig_Pillar_of_Lightning_Func008Func001Func007002003))

You could use the native directly by first setting TempGroup to "CreateGroup()" and then calling the function "GroupEnumUnitsInRangeOfLocMatching" (NOT setting the variable to the function. Call it and give it the created group).

You might want to name your functions better.

> set TempPoint = OffsetLocation(GetSpellTargetLoc(), 0, 0)

Technically, you should set first another location variable to "GetSpellTargetLoc()" because it leaks and then set TempPoint to this location offset by 0...

But, why not just set TempPoint directly to GetSpellTargetLoc()?

> call AddSpecialEffectLoc("Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl", TempPoint )
> call DestroyEffect( GetLastCreatedEffectBJ() )

Sorry, AddSpecialEffectLoc doesn't work with GetLastCreatedEffectBJ()

You should do this instead:

call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl", TempPoint ))

    call CreateNUnitsAtLoc( 1, 'e000', GetOwningPlayer(GetTriggerUnit()), TempPoint, bj_UNIT_FACING )
    call IssueImmediateOrder( GetLastCreatedUnit(), "stop" )
    call SetUnitAnimation( GetLastCreatedUnit(), "stand" )
    set Wisps[looping] = GetLastCreatedUnit()

If you're going to use "GetLastCreatedUnit()" many times, you're better off setting it to a variable to prevent useless function calls.

While doing so, using the native "CreateUnit()" would also be better

Don't know why, but you did set the last created unit to a variable in the second loop!

So... that's about it!

 

[Ghan]

> You could use the native directly by first setting TempGroup to "CreateGroup()" and then calling the function "GroupEnumUnitsInRangeOfLocMatching" (NOT setting the variable to the function. Call it and give it the created group).


No idea what you mean there.
Why would I want to create the group when I just set the variable?

> You might want to name your functions better.

Bah! Who cares about that? Useless, that's what it is.

> Technically, you should set first another location variable to "GetSpellTargetLoc()" because it leaks and then set TempPoint to this location offset by 0...
But, why not just set TempPoint directly to GetSpellTargetLoc()?

Yes, I think I already mentioned this, but I thought that was causing a problem earlier. Didn't change it back. Fixed.

> Sorry, AddSpecialEffectLoc doesn't work with GetLastCreatedEffectBJ()

You should do this instead:

call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Human\\ThunderCl ap\\ThunderClapCaster.mdl", TempPoint ))



Interesting. What does it do? How can it destroy an effect that has not been created?

> If you're going to use "GetLastCreatedUnit()" many times, you're better off setting it to a variable to prevent useless function calls.

Oh, now you're just being silly.
Don't expect consistency from me. Expect it to work.


> While doing so, using the native "CreateUnit()" would also be better

Boo! Hiss! I refuse to define X's and Y's.

> Don't know why, but you did set the last created unit to a variable in the second loop!

Consistency....

 

[Sim]

> Why would I want to create the group when I just set the variable?

To use the native directly. Saves function calls

> Interesting. What does it do? How can it destroy an effect that has not been created?

I'll go in deep explanations of "what" and "why".

what?

Quite simple

Here is the function "AddSpecialEffectLocBJ" (which you didn't use)

function AddSpecialEffectLocBJ takes location where, string modelName returns effect
    set bj_lastCreatedEffect = AddSpecialEffectLoc(modelName, where)
    return bj_lastCreatedEffect
endfunction

It sets bj_lastCreatedEffect to the newly created effect. (bj_lastCreatedEffect is returned by the function GetLastCreatedEffect)

Then, the function you used:

native AddSpecialEffectLoc          takes string modelName, location where returns effect

Oops, no bj_lastCreatedEffect!

So it won't work.

why?

Why use the DestroyEffect before and how can you create and destroy an effect right away?

Well, to destroy an effect you need an already existing effect. Which is why we create an effect... to destroy it!

Point is, the editor will never destroy an effect (Few exceptions may apply...) until it reaches a full "cycle" of action.

Which means, it has to "play" his whole animation before dying.

SO, it saves a function call and it works anyway. Use it!

The thing you did previously didn't clean the leak.

> Don't expect consistency from me. Expect it to work.

I'm criticizing your code!

> Boo! Hiss! I refuse to define X's and Y's.

CreateUnitAtLoc anyone?

It's a native too, you can use it!

> Consistency....

Gha...! (n_04)

 

[Ghan]

> I'll go in deep explanations of "what" and "why".

Cool. All I really needed to see was the two code comparisons and the Destroy part.

> I'm criticizing your code!

Yes! It's just that bad!

> CreateUnitAtLoc anyone?

Hmm... I could do that.

> Gha...! (n_04)

What? Don't look at me like that. It works.

 

[Sim]

> It works.

It is my philosophy too.

BUT, I had to criticize your work. (I was forced by... *insert unknown reason here*)

As for the GUI...

It works good without leaks? Fine.

 

[Ghan]

> It works good without leaks? Fine.

Works good? Debatable. Not MUI. The pillar animation can get bugged a bit. Doesn't affect the spell's execution, but may cause eye torture.

Without leaks? Yes.

 

[Sim]

MUI is not a requirement

> The pillar animation can get bugged a bit.

Didn't notice that.

 

[0zaru]

> You could use the native directly by first setting TempGroup to "CreateGroup()" and then calling the function "GroupEnumUnitsInRangeOfLocMatching" (NOT setting the variable to the function. Call it and give it the created group).


No idea what you mean there.
Why would I want to create the group when I just set the variable?

He means something like this

local grup g=CreateGroup()
call GroupEnumUnitsInRangeOfLocMatching(all arguments here...)

>Interesting. What does it do? How can it destroy an effect that has not been created?


it creates the effect and destroy it playing the effect death animation (With some effects it doesn't work)

It's like this

call RemoveUnit(CreateUnit(bla bla))

It creates the unit and then removes it

> If you're going to use "GetLastCreatedUnit()" many times, you're better off setting it to a variable to prevent useless function calls.

Oh, now you're just being silly.
Don't expect consistency from me. Expect it to work.

You can even do this directly
set bj_lastCreatedUnit=CreateUnit(arguments bla bla...) X's and Y's are easy to set

The "GetLastCreatedUnit()" function just returns bj_lastCreatedUnit

 

[Ghan]

@ Daxtreme:

Yes. Completely random. Difficult to prevent. I've tried. See the latest version.

@ 0zaru:

Already got it, but thanks anyway.

 

[PurgeandFire]

Yup, the master Purge has come to Purge your code, and renew it in an optimized way! Muahahahaa!

Here it is, optimized:

Just update your map and remove the globals. I really optimized your code, it was a big hassle, but I optimized it anyways!!

//Constant functions, you may edit these//
constant function POL_rawcode takes nothing returns integer
    return 'A000' //The rawcode of the spell//
    //POL means Pillar_Of_Lightning//
endfunction

constant function POL_ThunderClap takes nothing returns string
    return "Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl"
endfunction

constant function LightningIntervals takes nothing returns integer
    return 50
endfunction
constant function NumberofTargets takes nothing returns integer
    return 3
endfunction
constant function ChanceforBolt takes nothing returns integer
    return 20
endfunction
constant function BoltRange takes nothing returns real
    return 600.
endfunction
//Do NOT edit past this point unless you know what you are doing//

function Pillar_Of_Lightning_UnitEnemy takes nothing returns boolean
    return ( IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(GetTriggerUnit())) == true )
endfunction

function Trig_Pillar_of_Lightning_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == POL_rawcode()
endfunction

function Trig_Pillar_of_Lightning_Actions takes nothing returns nothing
    local unit array Wisps
    local location TempPoint
    local unit Caster
    local unit Target
    local group TempGroup
    local integer i                      = 0   
    local integer i2                     = 0 
    set TempPoint = GetSpellTargetLoc()
    call DestroyEffect(AddSpecialEffectLoc(POL_ThunderClap(), TempPoint  ))
    set i = 1
    loop
        exitwhen i > 10
        set Wisps<i> = CreateUnitAtLoc(GetOwningPlayer(GetTriggerUnit()) , &#039;e000&#039;, TempPoint, bj_UNIT_FACING )
        call IssueImmediateOrder( Wisps<i>, &quot;stop&quot; )
        call SetUnitAnimation( Wisps<i>, &quot;stand&quot; )
        call ResetUnitAnimation( Wisps<i> )
        call SetUnitFlyHeight( Wisps<i>, ( 50.00 * ( I2R(i) - 1 ) ), 500.00 )
        set i = i + 1
    endloop
    call TriggerSleepAction( 0.10 )
    set i = 1
    loop
        exitwhen i &gt; LightningIntervals()
        set i2 = 1
        loop
            exitwhen i2 &gt; NumberofTargets()
            if (i2 == 1 or GetRandomInt(1,100) &lt;= ChanceforBolt()) then
                set Caster = CreateUnitAtLoc(GetOwningPlayer(GetTriggerUnit()) , &#039;e000&#039;, TempPoint, bj_UNIT_FACING )
                call ShowUnitHide( Caster )
                call UnitApplyTimedLife(Caster, &#039;BTLF&#039;, 3.00 )
                call SetUnitFlyHeight( Caster, GetRandomReal(100.00, 450.00), 4000.00 )
                set TempGroup = CreateGroup()
                call GroupEnumUnitsInRangeOfLoc(TempGroup, TempPoint, BoltRange(), Condition(function Pillar_Of_Lightning_UnitEnemy))
                set Target = GroupPickRandomUnit(TempGroup)
                call IssueTargetOrder( Caster, &quot;chainlightning&quot;, Target )
                call DestroyGroup(TempGroup)
                set TempGroup            = null
                set Caster               = null
                set Target               = null
            endif
            set i2 = i2 + 1
        endloop
        call TriggerSleepAction( GetRandomReal(1.00, 3.00) )
        set i = i + 1
    endloop
    set i = 1
    loop
        exitwhen i &gt; 10
        call SetUnitFlyHeight( Wisps<i>, 0.00, 300.00 )
        set i = i + 1
    endloop
    call TriggerSleepAction( 2.50 )
    set i = 1
    loop
        exitwhen i &gt; 10
        call RemoveUnit( Wisps<i> )
        set Wisps<i>                     = null
        set i = i + 1
    endloop
    call RemoveLocation(TempPoint)
    set TempPoint                        = null
endfunction

//===========================================================================
function InitTrig_Pillar_of_Lightning takes nothing returns nothing
    set gg_trg_Pillar_of_Lightning = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Pillar_of_Lightning, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition(gg_trg_Pillar_of_Lightning,Condition(function Trig_Pillar_of_Lightning_Conditions))
    call TriggerAddAction( gg_trg_Pillar_of_Lightning, function Trig_Pillar_of_Lightning_Actions )
endfunction</i></i></i></i></i></i></i></i>

 

[Ghan]

Constant Functions? We don't need constant functions.

No, seriously. How are people supposed to be able to set the globals? You don't even include them. I left them for a reason.

I guess it's just as easy to edit them in the code with them not being globals, but it would be easier if they could set them with GUI for the newer mappers.

Either way works.

Thanks for the optimization.

 

[PurgeandFire]

Well, I think I understand you correctly. See, the global variables should only be for the GUI version. Instead of using locals that are set to globals, you can just make constant functions. It is much more easier to edit. You just need to type. Not click the value and go through all those selection junk.

Since you are setting locals to globals, why not just use the globals? Since you don't have two triggers or functions in which those globals are needed, why use the globals? It just adds more implementation difficulty.

Besides, constant functions are so easy to edit. In fact, I should make a tutorial about it.

~Reserved tutorial idea until further notice~

Your welcome! Thanks for making the spell!