Snippet PlayerColor()

[Ryuu]

This simple snippet colors your text into player colors.
Supports neutral players.

function PlayerColor takes player whichPlayer, string whichString returns string
local string array c
local integer i = GetConvertedPlayerId(whichPlayer)
local string s = whichString
local integer Index = 0
set c[1] = "|CFF0303"
set c[2] = "|C0042FF"
set c[3] = "|CFF1CB619"
set c[4] = "|CFF540081"
set c[5] = "|CFFFFFF01"
set c[6] = "|CFFFE8A0E"
set c[7] = "|CFF20C000"
set c[8] = "|CFFE55BB0"
set c[9] = "|CFF959697"
set c[10] = "|CFF7EBFF1"
set c[11] = "|CFF106246"
set c[12] = "|CFF4E2A04"
set c[13] = "|CFF000000"
return c<i>+s+&quot;|r&quot;
endfunction</i>

This can be achieved by calling the function:

call PlayerColor(player whichPlayer, string whichString)

For example, this

call PlayerColor("hahahahaha!", Player(0))

will return:

Spoiler

hahahahaha!

Additional credits go to Darthfett for help on 'return values'.

"Do not condemn me; this is what I had made and what I plan to share. You have three choices: take it, leave it or take it and leave."

 

[Vestras]

Ever heard about loops and elseifs?
And your little example will show nothing else than compile errors.

 

[Ryuu]

I'm still a beginner
I'm still a beginner in Jass

 

[Flare]

Do you have to indent everything so far? You could do

if whichPlayer == Player (0) then
   return something
elseif whichPlayer == Player (1) then
...
elseif whichPlayer == Player (2) then
...
elseif ...
//And so on

Would make it much simpler to read, and then you would only have to indent the return lines with a single tab

 

[Darthfett]

Why not store each string in an array, and just return the GetPlayerId(whichPlayer) indexed value?

At the very least, set a local integer to the Player's Id, and compare the Id to the numbers, instead of calling the Player(#) function until it reaches the correct player.

For example, this

call PlayerColor("hahahahaha!", Player(0))

will display:

Spoiler

hahahahaha!

Well not EXACTLY. It returns that string, but that doesn't necessarily display it. It is useful for a DisplayTextToPlayer/Force or BJDebugMsg function call, though.

 

[Romek]

This is very inefficient..
First off, you could use:

local integer p = GetPlayerId(whichPlayer)

Then compare the integers. Less function calls.

What's with all those elses? Just use elseif.

Or a better alternative, as Darth said would be to use arrays.

globals
  string array Colours
endglobals

function Init...
   set Colours[0] = "|CFFFF0303"
   // etc
endfunction

function GetColour ...
   return Colours[GetPlayerId(whichPlayer)] + whichString + "|r"
endfunction

That's about as good as this type of snippet can get, and it's been made like that before...

 

[Ryuu]

> Do you have to indent everything so far?

Well no.​

> Why not store each string in an array, and just return the GetPlayerId(whichPlayer) indexed value?

Good suggestion.​

> It returns that string, but that doesn't necessarily display it.

Right.​

> compare the integers.

That's what I did.​

> use elseif.

Why not use loops?​

> and it's been made like that before...

And it has been lost somewhere deep in this forum, only accessible by search ​

Really, my main purpose on making this snippet is for my own personal use but I find it saves a whole load of time so I shared with you guys. Never expecting myself to receive much correction, though.

Thanks for all the corrections.
I learnt something myself

 

[Romek]

local string s = whichString

Why? Just use whichString directly.

local integer i = GetConvertedPlayerId(whichPlayer)

Should be:

local integer i = GetPlayerId(whichPlayer)

And the strings start from 0. Saves a function call, and looks cleaner. (In Jass, players start from 0, not 1)

loop
        exitwhen Index > 16
        set Index = (Index + 1)
        if (i == Index) then
                return c[Index]+s+"|r"
        else
                return ""
        endif
endloop

Could be:

return c<i>+s+&quot;|r&quot;</i>

No need for loops or "Index" at all.
And it would be impossible for "i" be too high or low if you added the grey "Neutral" colour.

On a related note, did you even test this new one? It wouldn't work for any player other than Player(0) because it returns "" immediately.

 

[Gwypaas]

> and it's been made like that before...

And it has been lost somewhere deep in this forum, only accessible by search ​

http://www.wc3campaigns.net/showthread.php?t=101692

That system also contains player hex codes.

 

[cr4xzZz]

local string array c
set c[1] = "|CFF0303"
// etc.
local integer i = GetConvertedPlayerId(whichPlayer)

That's not even possible... How can you set variables and declare locals right after?

 

[Romek]

Clearly you didn't test this before submitting it.

 

[Ryuu]

I couldn't test it due to computer lag.

EDIT:
Happy new year!

 

[Furby]

function PlayerColor takes player whichPlayer, string whichString returns string
local string array c
local integer i = GetConvertedPlayerId(whichPlayer)
local string s = whichString
local integer Index = 0
set c[1] = "|CFF0303"
set c[2] = "|C0042FF"
set c[3] = "|CFF1CB619"
set c[4] = "|CFF540081"
set c[5] = "|CFFFFFF01"
set c[6] = "|CFFFE8A0E"
set c[7] = "|CFF20C000"
set c[8] = "|CFFE55BB0"
set c[9] = "|CFF959697"
set c[10] = "|CFF7EBFF1"
set c[11] = "|CFF106246"
set c[12] = "|CFF4E2A04"
set c[13] = "|CFF000000"
return c<i>+s+&quot;|r&quot;
endfunction</i>

Did you know arrays start at 0? It doesn't even need BJ function then.
string s, integer Index... useless

This can be achieved by calling the function:

call PlayerColor(player whichPlayer, string whichString)

For example, this

call PlayerColor("hahahahaha!", Player(0))

will return:

Spoiler

hahahahaha!

Uh?? Are you sure? Because I did not know "hahahahaha!" is type player and Player(0) returns string...

 

[Flare]

Did you know arrays start at 0? It doesn't even need BJ function then.

Replace the BJ call with 'GetPlayerId (whichPlayer) + 1', and leave the arrays as they are? Problem solved. Would be a bit pointless to re-do the arrays for the sake of something small