Please tell me where the code leacks

JJooKKoo

New Member
this is the code
Code:
 private function moveMe4 takes nothing returns nothing
        local location tempLoc
        local location tempLoc1
 
 
        //call BJDebugMsg("me4")
 
     
        set tempLoc = GetUnitLoc(GetEnumUnit())
        set tempLoc1 = PolarProjectionBJ(tempLoc, 4.50, GetUnitFacing(GetEnumUnit()))
        call SetUnitPositionLoc( GetEnumUnit(), tempLoc1 )
        call RemoveLocation(tempLoc)
        call RemoveLocation(tempLoc1)
     
        //call GroupRemoveUnit(GetEnumUnit())
 
    endfunction
 
 
 
    private function add_and_move_Letq6tMe4Timer takes nothing returns boolean
        local SpiningUltS SU = KT_GetData()
        local MyUnitStruct uData
        local unit me4
        local location tempLoc
 
        if(GetRandomInt(1, 100) <= 40) then
            set tempLoc = GetUnitLoc(SU.caster)
            set me4 = CreateUnitAtLoc( SU.p,'h002',  tempLoc, GetRandomDirectionDeg() )
            set uData = GetUnitUserData(me4)
            call RemoveLocation(tempLoc)
 
 
            call UnitApplyTimedLife(me4,'BTLF',1.0)
            set uData.needRemove = true
            set uData.removeFromGroup = SU.me4oveG         
            call SetUnitUserData(me4, uData )
            if(SU.test == 0) then
                call GroupAddUnit(SU.me4oveG, me4)
             
                set SU.test = 0
            endif
        endif
     
        //call KillUnit(me4)
        call ForGroup( SU.me4oveG, function moveMe4 )   
     
     
        return false
 
 
    endfunction
the problem apears to be in call ForGroup( SU.me4oveG, function moveMe4 ) i found one tutorial and used global group with this function -
Code:
call GroupEnumUnitsInRect(EnumGroup, bj_mapInitialPlayableArea, Filter(function moveMe4))
. but the map still lags after short time .When i comment the
Code:
call ForGroup( SU.me4oveG, function moveMe4 )
.The lag stops.Help with solution please
 

Tyrulan

Ultra Cool Member
A couple of things.

You should assign GetEnumUnit() to a local variable at the top of moveMe4 so you don't have to keep grabbing it.

Second, you should remove any and all bj's out of moveMe4 (PolarProjectionBJ). To do this, you should replace the BJ with the wrapped functions that it is calling. (If you don't know how to do this, I can show you.)

Further, you should set all local variables to null (even after using RemoveLocation).
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Seeing J4L is definitely a blast from the past.
  • Jesus4Lyf Jesus4Lyf:
    Oh hey Ghan! Long time. :)
    +1
  • jonas jonas:
    J4L! What has happened in your life
  • Jesus4Lyf Jesus4Lyf:
    Hmm, how to summarize... Moved to the USA and got married. Became a professional software engineer and solution lead. Learning Godot for game dev. :)
  • jonas jonas:
    So you are pursuing game dev as a hobby? What industry is your dayjob in?
  • jonas jonas:
    FAANG?
  • Jesus4Lyf Jesus4Lyf:
    Not quite FAANG, less pay for a less hours/stress. Yeah, game dev as a hobby.
  • jonas jonas:
    makes sense. Do we have a hobby game dev subforum to showcase some work?
  • Blackveiled Blackveiled:
    Happy Thursday
    +1
  • The Helper The Helper:
    Happy Thursday!
  • The Helper The Helper:
    TGIF!
  • The Helper The Helper:
    hey tom_mai please do not archive anymore news
  • Ghan Ghan:
    AMD Ryzen 7000 next week :D
    +1
  • The Helper The Helper:
    noice!
  • tom_mai78101 tom_mai78101:
    "hey tom_mai please do not archive anymore news" ----> Got it. What should we do with the "News Archive" subforum?
  • The Helper The Helper:
    I think leave it for real old news that cannot be sorted the reason we had it in the first place was a server issue that we do not have anymore. I don't want to get rid of the archive just not put anything in it for now until we figure it out more
  • The Helper The Helper:
    The side chat has nothing on the discord. it is not possible but the biggest thing on my wish list right now is a sidechat channel on the disord that hooks up to this...
  • Ghan Ghan:
    I've been selected for the Diablo IV beta.
    +1
  • Ghan Ghan:
    Woo!
    +1
  • The Helper The Helper:
    that is so cool
  • V-SNES V-SNES:
    Eh just noticed the new discord section on the side. Looks great!
    +1
  • Blackveiled Blackveiled:
    :( feels bad I can't ever get selected for any beta I sign up for. It's annoying as heck.
    +1
  • The Helper The Helper:
    Hello mgarcia! Happy Monday everyone!

    The Helper Discord

    Staff online

    Members online

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top