System PUI - Perfect Unit Indexing

Discussion in 'Systems and Snippets' started by Cohadar, Dec 1, 2007.

  1. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    AIDS structs, of course. :)
    >I believe in "don't fix if it is not broken" phylosophy.
    >PUI works as it should and it works well, I have no intention of wasting my time on maybe-improvements.

    What are you talking about? PUI is broken as hell by your logic. And it DOESN'T free indexes after 5 seconds. See demo map. Your algorithm vs mine.

    By the way, that's only the average index. Would you like to see the max?
    Edit: If so...
    JASS:
    library TestPUI initializer test uses PUI, Mod
        private function periodic takes nothing returns nothing
            globals
                private integer PUI_Max=0
                private integer Mod_Max=0
                private integer Index
                
                private unit u
            endglobals
            
            set u=CreateUnit(Player(0),'hfoo',0,0,0)
            set Index=GetUnitIndex(u)
            if Index>PUI_Max then
                set PUI_Max=Index
            endif
            call RemoveUnit(u)
            
            set u=CreateUnit(Player(0),'hfoo',0,0,0)
            set Index=Mod_GetUnitIndex(u)
            if Index>Mod_Max then
                set Mod_Max=Index
            endif
            call RemoveUnit(u)
            
            call BJDebugMsg("Max Indexes: PUI: "+I2S(PUI_Max)+" | Modded: "+I2S(Mod_Max)+".")
        endfunction
        private function test takes nothing returns nothing
            call TimerStart(CreateTimer(),0.02,true,function periodic)
        endfunction
    endlibrary

    Shows that PUI with your algorithm breaks when my algorithm is only on about index 3300. (Yes, 8100 to 3300, roughly.)
     

    Attached Files:

  2. Cohadar

    Cohadar master of fugue

    Ratings:
    +209 / 0 / -0
    It frees indexes after 5-10 seconds, big deal.
    PUI was the first indexing system out there, and by my logic it was and still is the best indexing system ever made.
    A lot of really good map makers seems to agree with me on that one too.

    I really don't care about your test maps because I have previous experience with you tiliting the results in your favour (TT vs KT2 thing)
    so I am not going to waste any more of my time with this.

    Please go develop your system in your own thread.
     
  3. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    Don't even try that. We ran your tests and had the same results as mine.

    If I say PUI is broken, you know what I'm talking about. Your index recycling is wrong, as shown in the above test maps.

    All the same, thanks for your time. I do value it more than a couple of nanoseconds from my computer. :)
     
  4. kingkingyyk3

    kingkingyyk3 Visitor (Welcome to the Jungle, Baby!)

    Ratings:
    +216 / 0 / -0
    Huh? I downloaded the map and put my unit indexing system as competitor. At early stage, moded PUI had lowest value.. But after 1 minute, I found my one has lowest value! lol. I had same decay time, recycler period....
     
  5. Romek

    Romek Super Moderator Staff Member

    Ratings:
    +961 / 0 / -0
    @kingkingyyk3:
    Chances are, your indexing system is crap.
     
    • Like Like x 1
  6. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    kingkingyyk3 owns PUI?

    No, that test map was a demonstration of recycling algorithms, not unit indexing systems.

    Actually, if you recycled faster than Modded PUI, on the same period, then your recycler is probably doing too much work. :p
     
  7. Cohadar

    Cohadar master of fugue

    Ratings:
    +209 / 0 / -0
    Ye you are talking about imaginary world in your head.

    Because what you say must be true and the fact that me and Builder Bob have tested PUI extensively and that PUI had been used in all kinds of maps for almost 4 years without any errors/performance issues does not really matter.

    It also does not matter that I explained to you (for the third time now) that optimizing property A of the system does not necessarily make the system better because it can fuck up properties B and C and D...

    It also does not matter that you make your test maps in such a way as to compare one property of the system while disregarding others (intentionally) and thus giving a false impression of the entire sys.

    Really I don't get why people who make modified/alternate versions of my systems always feel the need to prove to me that they are better somehow.
    Prove it to yourself and prove it to the people who might want to use it and leave me alone.

    If I see anyone else talking about their indexing system in my thread I am reporting him for trolling.
     
    • Like Like x 1
  8. kingkingyyk3

    kingkingyyk3 Visitor (Welcome to the Jungle, Baby!)

    Ratings:
    +216 / 0 / -0
    My system only went up to 255 when PUI was full.

    My recycle here. (similar with TT callback) :p
    JASS:
            if GetUnitUserData(INDEXED_UNITS[Index]) == 0 then
                if DECAY_TICK[Index] > 0 then
                    set DECAY_TICK[Index] = DECAY_TICK[Index] - 1
                else
                    set INDEXED_UNITS[Index] = INDEXED_UNITS[COUNTER]
                    set DECAY_TICK[Index] = DECAY_TICK[COUNTER]
                    set INDEXED_UNITS[COUNTER] = null
                    set DECAY_TICK[COUNTER] = 0
                    set COUNTER = COUNTER - 1
                    set LAST_FREE_INDEX = COUNTER
                endif
            endif
    //Crap recycling :D
     
  9. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    @kingkingyyk3
    Your system is broken, you recycle more than 32 indexes per second.
    Your code is horrible. :( You should switch to a real system, it will do significantly less processing in the background, and you don't have to write it yourself.

    [​IMG]

    Also, your code has nothing to do with TT.
     
  10. kingkingyyk3

    kingkingyyk3 Visitor (Welcome to the Jungle, Baby!)

    Ratings:
    +216 / 0 / -0
    Yeah, I recycle all indexed units. :p
     
  11. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    I assume you mean cycle through them all, every iteration?
     
  12. Joker(Div)

    Joker(Div) Always Here..

    Ratings:
    +86 / 0 / -0
    There must be a bug of some sort b/c I am getting units with the same index and the CHECK value also becomes bugged with it.
    JASS:
    scope Checkpoint initializer Init
    
        //! runtextmacro PUI_PROPERTY( "", "integer", "CHECK", "-1" )
    
        globals
            private constant integer MAX_CHECKPOINTS = 8
        endglobals
        //======================================================
        
        globals
            private integer array CHECKPOINTS[MAX_PLAYERS] 
            
            public rect array AREA[MAX_CHECKPOINTS]
        endglobals
        //======================================================
        
        private function Conditions takes nothing returns boolean
            return CHECK[GetTriggerUnit()] > -1
        endfunction
        
        private function Actions takes nothing returns nothing
            local unit a = GetTriggerUnit()
            local player p = GetOwningPlayer( a )
            local integer c = CHECK[a] + 1
            local real x = GetRectCenterX( AREA[c] )
            local real y = GetRectCenterY( AREA[c] )
            
            if IsPointInRegion( GetTriggeringRegion(), x, y ) then
            
                if (c + 1) >= MAX_CHECKPOINTS then
                    set c = GetPlayerId( p )
                    set CHECKPOINTS[c] = CHECKPOINTS[c] + 1
                    call BoardUpdateText( 2, c + 1, "  " + I2S( CHECKPOINTS[c] ) )
                    
                    set c = 0
                    set CHECK[a] = c
                    set x = GetRectCenterX( AREA[c] )
                    set y = GetRectCenterY( AREA[c] )
                endif
                
                set CHECK[a] = -1
                call ShowUnit( a, false )
                call SetUnitExploded( a, true )
                call UnitApplyTimedLife( a, 'BTLF', 1. )
                //Pretty sure its PUI b/c it does not bug if I do not kill the entering unit.
                
                set a = CreateUnitEx( p, x, y )
                set CHECK[a] = c
                
                if p == GetLocalPlayer() then
                    call ClearSelection()
                    call SelectUnit( a, true )
                    call PanCameraToTimed( x, y, 0. )
                endif
            endif
            
            set a = null
        endfunction
        //======================================================
        
        private function Init takes nothing returns nothing
            local integer i = 0
            
            set AREA[0] = Rect( -2624., -1888., -704.,   32. )
            set AREA[1] = Rect( -830.,   575.,   415.,   1760. )
            set AREA[2] = Rect( -4225.,  670.,  -3135.,  1790. )
            set AREA[3] = Rect( -4225., -3138., -3232., -2496. )
            set AREA[4] = Rect(  1092., -3171.,  1543., -2624. )
            set AREA[5] = Rect(  1230.,  2264.,  1550.,  2688. )
            set AREA[6] = Rect( -5056.,  2464., -4632.,  2688. )
            set AREA[7] = Rect( -5056., -3232., -4732., -3096. )
            
            loop
                call UnitEnterEvent( Condition( function Conditions ), function Actions, AREA[i] )
                set i = i + 1
                exitwhen i >= MAX_CHECKPOINTS
            endloop
        endfunction
    
    endscope
     
  13. Cohadar

    Cohadar master of fugue

    Ratings:
    +209 / 0 / -0
    Tell me how am I goint to reproduce your error from that script?
    Please make me a demo map that demonstrates the bug.

    Are you using UnitUserData directly somewhere?
     
  14. Joker(Div)

    Joker(Div) Always Here..

    Ratings:
    +86 / 0 / -0
    Test map.

    Maybe I'm doing something really weird with the unit replacement. Made a Demo of the bug.

    EDIT: I found that the "BUGGED" msg gives out false-positives every once in a while when you don't kill the entering units.
     

    Attached Files:

    • Like Like x 1
  15. Cohadar

    Cohadar master of fugue

    Ratings:
    +209 / 0 / -0
    Very strange thing, it really is an PUI error.
    It was introduced with 5.2, version 5.1 works fine.

    I have reattached 5.1 to first post, use that until I release 5.3
    Thanks for finding this Joker(Div)

    EDIT:
    fixed, version 5.3 is out.
    In case someone cares the problem was that I forgot to shift one index from free index section to used index section when indexes are recycled.
    This was a problem because used and free indexes were kept in same array "to save space"..
    This was very stupid of me because it complicated algorithm and thus caused me to miss this bug.
    And I am the one that always tells people that they overdo with optimization...:banghead:
     
    • Like Like x 2
  16. 13lade619

    13lade619 is now a game developer :)

    Ratings:
    +399 / 0 / -0
    hmm.. i was using 5.2 up till a while ago.

    i integrated PUI into my creep revival system and sometimes it bugged (some units didnt register into pui).

    but i updated to 5.3 and it seems to be working fine now.
     
  17. Karawasa

    Karawasa Element Tower Defense

    Ratings:
    +38 / 0 / -0
    PUI really is the best.
     
  18. NetherHawk

    NetherHawk New Member

    Ratings:
    +26 / 0 / -0
    hi.. pui only recycles indexes when a unit is removed right? that means that an index set for a hero will nvr become 0. Is that right?
     
  19. kingkingyyk3

    kingkingyyk3 Visitor (Welcome to the Jungle, Baby!)

    Ratings:
    +216 / 0 / -0
    Yep. ;)
     
  20. NetherHawk

    NetherHawk New Member

    Ratings:
    +26 / 0 / -0
    thanks
     

Share This Page