-random tutorial is broken

[carbonduck]

http://world-editor-tutorials.thehelper.net/herotavern.php

My -random command is exactly the same as the one given in that tutorial. The tutorial claims that with this command, the same hero will not be randomed more than once. Well... that's not true. It's possible to random the same hero more than once and I'm not really sure how to fix it.

I've been working at this for a couple days and nothing is working. Through some debugging, it seems that the bug (randoming a hero who has already been randomed) becomes a possibility when a hero at the end of the array has been randomed.

Any help? :banghead:

• Actions
  • Set HS_RandomHero = (Random integer number between 1 and HS_RandomCount)
  • Unit - Create 1 HS_HeroArray[HS_RandomData[HS_RandomHero]] for (Triggering player) at (Center of MapSelection) facing Default building facing degrees
  • Set SelectedHeroArray[(Player number of (Triggering player))] = (Last created unit)
  • Player Group - Pick every player in Players and do (Actions)
    • Loop - Actions
      • Player - Make (Unit-type of (Last created unit)) Unavailable for training/construction by (Picked player)
  • Selection - Select (Last created unit) for (Triggering player)
  • Set HS_RandomData[HS_RandomHero] = HS_RandomCount
  • Set HS_RandomCount = (HS_RandomCount - 1)

 

[LoveTD's]

please post your trigger before asking us to help Maybe it does work but you made a little mistake...

 

[Vylatin]

I had this problem long time ago

Go "File" -> "Preferences..." -> "Test Map" -> Uncheck "Use Fixed Random Seed"

 

[LoveTD's]

lol y or you can do what Vylatin said, I forgot that since I always have it unchecked XD

 

[carbonduck]

"Use Fixed Random Seed" is not checked. The order of heroes that are chosen at random is not the same every time, so that's not really the problem.

I updated my original post with my trigger (took out extraneous information unrelated to the issue). Please let me know if you see something!

 

[LoveTD's]

this is what happens:

in init:
you put randomdata[1] = 1
randomdata[2]=2 etc...

first time:
random between 1 and 8

number appears to be 6

create 1 hero[randomdata[6] which is hero number 6
set hero in a array
remove hero from training

set randomdata[6]=randomcount (which is 8 as I have seen in the tutorial, which means now randomdata[6] has a number attached which is 8)
set randomcount=randomcount-1

second time:
random number between 1 and 7

number appears to be 6 again

create 1 hero[randomdata[6] which is hero number 7
set hero in a array
remove hero from training
set RandomData[6] = randomcount (which is 7 now)
set randomcount = randomcount-1

third time:
random between 1 and 6
random number appears to be 6 again
create 1 hero[randomdata[6] which is hero number 6

etc.... I hope you understand where I'm going
as you can see the hero number 6 has been removed from training... BUT! using an action to create the hero doesn't matter when a hero has been removed from training... since your not training it but creating it via actions... So yeah that system prolly fails...

 

[carbonduck]

Yeah, that's exactly the problem. The system doesn't work. Anyone know how to implement a working -random command?

Would the system work if the HS_RandomData array was an array of Heroes and it just swapped the heroes in the array (the same way the numbers are swapped in the current array)? I think it would work if it was like that.

EDIT: Just tried it and I believe my change works. I'll update if it doesn't...

Thanks for the help guys. +rep.