System Replace Terrain

Troll-Brain · Jan 1, 2009

Romek said:
You can change them when needed though.
So if all players enter some dungeon or something, change the terrain type in there. Then change it back to dirt and stuff.

Does anyone know if changing terrain types desyncs if used with GetLocalPlayer()?

Well i'm to lazy to test your solution.
About the GetLocalPlayer it should desycn with blight for some obvious reasons.
For the others i dunno but at least noobs users would be able to make desync code.

Flare · Jan 1, 2009

My guess is yes (or, at least it could cause a desync from other stuff)

1) Terrain-type comparisons, not sure if they will directly cause a desync or not, but it's likely that it could be caused by something else later

2) What if you replaced unbuildable terrain with buildable terrain for a local player? Not sure of result, but it doesn't sound like it's going to end well

Viikuna · Jan 1, 2009

Yes. If something affects gameplay, it will desync when used with GetLocalPlayer.

Tyrande_ma3x · Jan 22, 2009

Darthfett said:

JASS:

library TTs

//-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
//-=-=-= List of Terrain Types =-=-=-
//-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
//-=-=-=-= Thanks to Romek  -=-=-=-=-
//-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
scope LORDAERONSUMMER
// Lordaeron Summer
globals
    public constant integer DIRT = &#039;Ldrt&#039;
    public constant integer ROUGH_DIRT = &#039;Ldro&#039;
    public constant integer GRASSY_DIRT = &#039;Ldrg&#039;
    public constant integer ROCK = &#039;Lrok&#039;
    public constant integer GRASS = &#039;Lgrs&#039;
    public constant integer DARK_GRASS = &#039;Lgrd&#039;
    public constant integer DIRT_CLIFF = &#039;cLc2&#039;
    public constant integer GRASS_CLIFF = &#039;cLc1&#039;
endglobals

endscope

scope LORDAERONFALL
// Lordaeron Fall
globals
    public constant integer DIRT = &#039;Fdrt&#039;
    public constant integer ROUGH_DIRT = &#039;Fdro&#039;
    public constant integer GRASSY_DIRT = &#039;Fdrg&#039;
    public constant integer ROCK = &#039;Frok&#039;
    public constant integer GRASS = &#039;Fgrs&#039;
    public constant integer DARK_GRASS = &#039;Fgrd&#039;
    public constant integer DIRT_CLIFF = &#039;cFc2&#039;
    public constant integer GRASS_CLIFF = &#039;cFc1&#039;
endglobals

endscope

scope LORDAERONWINTER
// Lordaeron Winter
globals
    public constant integer DIRT = &#039;Wdrt&#039;
    public constant integer ROUGH_DIRT = &#039;Wdro&#039;
    public constant integer GRASSY_SNOW = &#039;Wsng&#039;
    public constant integer ROCK = &#039;Wrok&#039;
    public constant integer GRASS = &#039;Wgrs&#039;
    public constant integer SNOW = &#039;Wsnw&#039;
    public constant integer GRASS_CLIFF = &#039;cWc2&#039;
    public constant integer SNOW_CLIFF = &#039;cWc1&#039;
endglobals

endscope

scope BARRENS
// Barrens
globals
    public constant integer DIRT = &#039;Bdrt&#039;
    public constant integer ROUGH_DIRT = &#039;Bdrh&#039;
    public constant integer PEBBLES = &#039;Bdrr&#039;
    public constant integer GRASSY_DIRT = &#039;Bdrg&#039;
    public constant integer DESERT = &#039;Bdsr&#039;
    public constant integer DARK_DESERT = &#039;Bdsd&#039;
    public constant integer ROCK = &#039;Bflr&#039;
    public constant integer GRASS = &#039;Bgrr&#039;
    public constant integer DESERT_CLIFF = &#039;cBc2&#039;
    public constant integer GRASS_CLIFF = &#039;cBc1&#039;
endglobals

endscope

scope ASHENVALE
// Ashenvale
globals
    public constant integer DIRT = &#039;Adrt&#039;
    public constant integer ROUGH_DIRT = &#039;Adrd&#039;
    public constant integer GRASS = &#039;Agrs&#039;
    public constant integer ROCK = &#039;Arck&#039;
    public constant integer LUMPY_GRASS = &#039;Agrd&#039;
    public constant integer VINES = &#039;Avin&#039;
    public constant integer GRASSY_DIRT = &#039;Adrg&#039;
    public constant integer LEAVES = &#039;Alvd&#039;
    public constant integer DIRT_CLIFF = &#039;cAc2&#039;
    public constant integer GRASS_CLIFF = &#039;cAc1&#039;
endglobals

endscope

scope FELWOOD
// Felwood
globals
    public constant integer DIRT = &#039;Cdrt&#039;
    public constant integer ROUGH_DIRT = &#039;Cdrd&#039;
    public constant integer POISON = &#039;Cpos&#039;
    public constant integer ROCK = &#039;Crck&#039;
    public constant integer VINES = &#039;Cvin&#039;
    public constant integer GRASS = &#039;Cgrs&#039;
    public constant integer LEAVES = &#039;Clvg&#039;
    public constant integer DIRT_CLIFF = &#039;cCc2&#039;
    public constant integer GRASS_CLIFF = &#039;cCc1&#039;
endglobals

endscope

scope NORTHREND
// Northrend
globals
    public constant integer DIRT = &#039;Ndrt&#039;
    public constant integer DARK_DIRT = &#039;Ndrd&#039;
    public constant integer ROCK = &#039;Nrck&#039;
    public constant integer GRASS = &#039;Ngrs&#039;
    public constant integer ICE = &#039;Nice&#039;
    public constant integer SNOW = &#039;Nsnw&#039;
    public constant integer ROCKY_SNOW = &#039;Nsnr&#039;
    public constant integer DIRT_CLIFF = &#039;cNc2&#039;
    public constant integer SNOW_CLIFF = &#039;cNc1&#039;
endglobals

endscope

scope CITYSCAPE
// Cityscape
globals
    public constant integer DIRT = &#039;Ydrt&#039;
    public constant integer ROUGH_DIRT = &#039;Ydtr&#039;
    public constant integer BLACK_MARBLE = &#039;Yblm&#039;
    public constant integer BRICK = &#039;Ybtl&#039;
    public constant integer SQUARE_TILES = &#039;Ysqd&#039;
    public constant integer ROUND_TILES = &#039;Yrtl&#039;
    public constant integer GRASS = &#039;Ygsb&#039;
    public constant integer GRASS_TRIM = &#039;Yhdg&#039;
    public constant integer WHITE_MARBLE = &#039;Ywmb&#039;
    public constant integer DIRT_CLIFF = &#039;cYc2&#039;
    public constant integer SQUARE_TILES_CLIFF = &#039;cYc1&#039;
endglobals

endscope

scope VILLAGE
// Village
globals
    public constant integer DIRT = &#039;Vdrt&#039;
    public constant integer ROUGH_DIRT = &#039;Vdrr&#039;
    public constant integer CROPS = &#039;Vcrp&#039;
    public constant integer COBBLE_PATH = &#039;Vcbp&#039;
    public constant integer STONE_PATH = &#039;Vstp&#039;
    public constant integer SHORT_GRASS = &#039;Vgrs&#039;
    public constant integer ROCKS = &#039;Vrck&#039;
    public constant integer THICK_GRASS = &#039;Vgrt&#039;
    public constant integer DIRT_CLIFF = &#039;cVc2&#039;
    public constant integer GRASS_THICK_CLIFF = &#039;cVc1&#039;
endglobals

endscope

scope VILLAGEFALL
// Village Fall
globals
    public constant integer DIRT = &#039;Qdrt&#039;
    public constant integer ROUGH_DIRT = &#039;Qdrr&#039;
    public constant integer CROPS = &#039;Qcrp&#039;
    public constant integer COBBLE_PATH = &#039;Qcbp&#039;
    public constant integer STONE_PATH = &#039;Qstp&#039;
    public constant integer SHORT_GRASS = &#039;Qgrs&#039;
    public constant integer ROCKS = &#039;Qrck&#039;
    public constant integer THICK_GRASS = &#039;Qgrt&#039;
    public constant integer DIRT_CLIFF = &#039;cQc2&#039;
    public constant integer GRASS_THICK_CLIFF = &#039;cQc1&#039;
endglobals

endscope

scope DALARAN
// Dalaran
globals
    public constant integer DIRT = &#039;Xdrt&#039;
    public constant integer ROUGH_DIRT = &#039;Xdtr&#039;
    public constant integer BLACK_MARBLE = &#039;Xblm&#039;
    public constant integer BRICK_TILES = &#039;Xbtl&#039;
    public constant integer SQUARE_TILES = &#039;Xsqd&#039;
    public constant integer ROUND_TILES = &#039;Xrtl&#039;
    public constant integer GRASS = &#039;Xgsb&#039;
    public constant integer TRIM_GRASS = &#039;Xhdg&#039;
    public constant integer WHITE_MARBLE = &#039;Xwmb&#039;
    public constant integer DIRT_CLIFF = &#039;cXc2&#039;
    public constant integer SQUARE_TILES_CLIFF = &#039;cXc1&#039;
endglobals

endscope

scope DUNGEON
// Dungeon
globals
    public constant integer DIRT = &#039;Ddrt&#039;
    public constant integer BRICK = &#039;Dbrk&#039;
    public constant integer RED_STONES = &#039;Drds&#039;
    public constant integer LAVA_CRACKS = &#039;Dlvc&#039;
    public constant integer LAVA = &#039;Dlav&#039;
    public constant integer DARK_ROCKS = &#039;Ddkr&#039;
    public constant integer GREY_STONES = &#039;Dgrs&#039;
    public constant integer SQUARE_TILES = &#039;Dsqd&#039;
    public constant integer DIRT_CLIFF = &#039;cDc2&#039;
    public constant integer SQUARE_TILES_CLIFF = &#039;cDc1&#039;
endglobals

endscope

scope UNDERGROUND
// Underground
globals
    public constant integer DIRT = &#039;Gdrt&#039;
    public constant integer BRICK = &#039;Gbrk&#039;
    public constant integer RED_STONES = &#039;Grds&#039;
    public constant integer LAVA_CRACKS = &#039;Glvc&#039;
    public constant integer LAVA = &#039;Glav&#039;
    public constant integer DARK_ROCKS = &#039;Gdkr&#039;
    public constant integer GREY_STONES = &#039;Ggrs&#039;
    public constant integer SQUARE_TILES = &#039;Gsqd&#039;
    public constant integer DIRT_CLIFF = &#039;cGc2&#039;
    public constant integer SQUARE_TILES_CLIFF = &#039;cGc1&#039;
endglobals

endscope

scope SUNKENRUINS
// Sunken Ruins
globals
    public constant integer DIRT = &#039;Zdrt&#039;
    public constant integer ROUGH_DIRT = &#039;Zdtr&#039;
    public constant integer GRASSY_DIRT = &#039;Zdrg&#039;
    public constant integer SMALL_BRICKS = &#039;Zbks&#039;
    public constant integer SAND = &#039;Zsan&#039;
    public constant integer LARGE_BRICKS = &#039;Zbkl&#039;
    public constant integer ROUND_TILES = &#039;Ztil&#039;
    public constant integer GRASS = &#039;Zgrs&#039;
    public constant integer DARK_GRASS = &#039;Zvin&#039;
    public constant integer DIRT_CLIFF = &#039;cZc2&#039;
    public constant integer LARGE_BRICKS_CLIFF = &#039;cZc1&#039;
endglobals

endscope

scope ICECROWNGLACIER
// Icecrown Glacier
globals
    public constant integer DIRT = &#039;Idrt&#039;
    public constant integer ROUGH_DIRT = &#039;Idtr&#039;
    public constant integer DARK_ICE = &#039;Idki&#039;
    public constant integer BLACK_BRICKS = &#039;Ibkb&#039;
    public constant integer RUNE_BRICKS = &#039;Irbk&#039;
    public constant integer TILED_BRICKS = &#039;Itbk&#039;
    public constant integer ICE = &#039;Iice&#039;
    public constant integer BLACK_SQUARES = &#039;Ibsq&#039;
    public constant integer SNOW = &#039;Isnw&#039;
    public constant integer RUNE_BRICKS_CLIFF = &#039;cIc2&#039;
    public constant integer SNOW_CLIFF = &#039;cIc1&#039;
endglobals

endscope

scope OUTLAND
// Outland
globals
    public constant integer DIRT = &#039;Odrt&#039;
    public constant integer LIGHT_DIRT = &#039;Odtr&#039;
    public constant integer ROUGH_DIRT = &#039;Osmb&#039;
    public constant integer CRACKED_DIRT = &#039;Ofst&#039;
    public constant integer FLAT_STONES = &#039;Olgb&#039;
    public constant integer ROCK = &#039;Orok&#039;
    public constant integer LIGHT_FLAT_STONES = &#039;Ofsl&#039;
    public constant integer ABYSS = &#039;Oaby&#039;
    public constant integer ABYSS_CLIFF = &#039;cOc1&#039;
    public constant integer ROUGH_DIRT_CLIFF = &#039;cOc2&#039;
endglobals

endscope

scope BLACKCITADEL
// Black Citadel
globals
    public constant integer DIRT = &#039;Kdrt&#039;
    public constant integer LIGHT_DIRT = &#039;Kfsl&#039;
    public constant integer ROUGH_DIRT = &#039;Kdtr&#039;
    public constant integer FLAT_STONES = &#039;Kfst&#039;
    public constant integer SMALL_BRICKS = &#039;Ksmb&#039;
    public constant integer LARGE_BRICKS = &#039;Klgb&#039;
    public constant integer SQUARE_TILES = &#039;Ksqt&#039;
    public constant integer DARK_TILES = &#039;Kdkt&#039;
    public constant integer DIRT_CLIFF = &#039;cKc1&#039;
    public constant integer DARK_TILES_CLIFF = &#039;cKc2&#039;
endglobals

endscope

scope DALARANRUINS
// Dalaran Ruins
globals
    public constant integer DIRT = &#039;Jdrt&#039;
    public constant integer ROUGH_DIRT = &#039;Jdtr&#039;
    public constant integer BLACK_MARBLE =  &#039;Jblm&#039;
    public constant integer BRICK_TILES = &#039;Jbtl&#039;
    public constant integer SQUARE_TILES = &#039;Jsqd&#039;
    public constant integer ROUND_TILES = &#039;Jrtl&#039;
    public constant integer GRASS = &#039;Jgsb&#039;
    public constant integer TRIM_GRASS = &#039;Jhdg&#039;
    public constant integer WHITE_MARBLE = &#039;Jwmb&#039;
    public constant integer DIRT_CLIFF = &#039;cJc2&#039;
    public constant integer SQUARE_TILES_CLIFF = &#039;cJc1&#039;
endglobals

endscope

endlibrary

You can't nest scopes in libraries.

No big deal, the user could just remove the library/endlibrary keywords. Very neat system, I'm using it at the moment for my map.

Azlier · Jan 22, 2009

You can't nest scopes in libraries.

What? Of course you can! You can even nest scopes inside other scopes. But what you can't do is nest libraries.

Tyrande_ma3x · Jan 22, 2009

> What? Of course you can!

Line X: Scopes with initializers cannot allow nested scopes

> You can even nest scopes inside other scopes.
That I know, however it seems like you can't nest scopes in libraries.

Flare · Jan 22, 2009

Line X: Scopes with initializers cannot allow nested scopes

When azlier said "What? Of course you can!", he was responding to

You can't nest scopes in libraries.

Nesting scopes in libraries != nesting scopes in scopes with initializers

Vestras · Jan 22, 2009

You leak GetWorldBounds().

Tyrande_ma3x · Jan 22, 2009

Line X: Scopes with initializers cannot allow nested scopes

This error appears when I put the library TTs in my map... That's why I got rid of the library/endlibrary.

Tyrande_ma3x · Apr 22, 2009

Can you make this also support terrain changes for individual players?

Romek · Apr 22, 2009

I will if/when I update this.
It's not coded to my standards at the moment anyway.

(See my archive)

Chocobo · Apr 22, 2009

super good for this, however it seems to freeze my computer for about 20-25s when i'm doing this on your demo map, is it normal? (20-25s is not a lag spike ><)

Troll-Brain · Apr 22, 2009

You leak a rect each time you use GetWorldsBound() you should use a private global rect initialized to GetWorldsBound() instead.

But anyway instead of using this rect you should use bj_mapInitialPlayableArea, because correct me if i'm wrong but you can't change the terrain type outside the playable map area, right ?
I didn't test, but war3 doesn't crash when you try it (probably not, i hope you test your functions

) ?
Because it crash when you try to change the pathing outside the playable map area, however it isn't the same thing i know.
You will win efficiency, since this rect is always smaller than GetWorldsBound()

EDIT : Oh and about change the terrain locally for a player, i think it's a bad idea it can easily make a desynchronisation (pathing of the terrain type, allow or not flying/ground units and so one)

EDIT 2 :

About the lag issue, can you reduce the number of execute or will it fail if you do something like that :

JASS:

globals
    private integer I = 0
    private constant integer maxIterations = 10
endglobals

function ReplaceTerrainTypeEx takes integer OldTerrain, integer NewTerrain, rect WhichRect returns nothing
        local real MinX = GetRectMinX(WhichRect)
        local real MaxX = GetRectMaxX(WhichRect)
        local real MinY = GetRectMinY(WhichRect)
        local real MaxY = GetRectMaxY(WhichRect)       
        loop
            set I = I+1
            exitwhen MinY &gt; MaxY
                if I == I/maxIterations*maxIterations then
                    call RT1.execute(MinX, MaxX, MinY, OldTerrain, NewTerrain)
                else
                    call RT1(MinX, MaxX, MinY, OldTerrain, NewTerrain) // but it should be a textmacro instead, or directly the code, imho
                endif
            set MinY = MinY + 128
        endloop
endfunction

And plz don't talk about overflow the max value of an integer is pretty huge

Romek · Apr 22, 2009

I'm aware of all the problems with this code, as well as the desynchronisation problem that could be related to locally changing terrain.
As I said, this is a Navy link on my archive, which means it's not up to scratch. It was back when I made it, but my standards are much higher now.

UAC recently became a black link from a navy link.

Troll-Brain · Apr 22, 2009

UAC means ?

Also it should be graveyard for the moment so.
What about reduce the number of execute calling ?
Is it possible or will it fail ? I could test it myself ofc, but maybe you have more knowledge about that than me.

Romek · Apr 22, 2009

It's still approval worthy I think.
It's just not up to scratch.

And, really, no need to comment on the code and such any more.
I know one of the functions is useless, I know it leaks.

> And plz don't talk about overflow the max value of an integer is pretty huge
The op. limit however, isn't.

Troll-Brain · Apr 22, 2009

Hmm you didn't answer my question, i guess i will test it myself

Something with a leak that can be easily solved have no place in a submission forum in my mind, but i'm a simple user of this forum anyway, so don't listen me.

Romek · Apr 22, 2009

> Hmm you didn't answer my question, i guess i will test it myself

Here:
"I know one of the functions is useless" - (-1 exec call)
"The op. limit however, isn't." - Can't get any less.

I'll fix the leak in a few minutes as you're obsessing about it.
Though I'd rather fix it all at once. =|

Romek · Apr 23, 2009

Updated.
This is now a Black Link on my archive.

Fixed the leak, made the Global functions more efficient, and it now starts a completely new thread when called.
I also think it may be a little faster.

Next up for fixing: Panda Roll.

Troll-Brain · Apr 23, 2009

So you can change the terrain type outside the playable map area ?

System Replace Terrain

You can change this now in User CP.

Stops copies me!

No Marlo no game.

.

Old World Ghost

.

Stops copies me!

Retired

.

.

Super Moderator

White-Flower

You can change this now in User CP.

Super Moderator

You can change this now in User CP.

Super Moderator

You can change this now in User CP.

Super Moderator

Super Moderator

You can change this now in User CP.

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors