# Review my Code!

#### priest170234

##### New Member
Okay, I tried to code this myself. (Perhaps the first time I am coding myself, without help). Review this for me!
This is a function to check whether a number is prime or not.

Definition of Prime number: A number whose factors are 1 and itself
Numbers less than or equal to 1 are not prime.

JASS:
``````scope CheckPrime
globals
integer int                 // Constant, does not change at ALL until checked = false
integer int_2               // Changes
boolean checked = false
boolean isPrime
endglobals

function CheckPrime takes integer number returns boolean
if(number&lt;=1) then
call BJDebugMsg(&quot;Please enter a value larger than 1!&quot;)
set isPrime = false
else
////////////////////////////////////////////
if(checked == false) then
set checked = true
set int = number
endif
////////////////////////////////////////////
set int_2 = number

if (ModuloInteger(int, int_2) == 0) and (int != int_2) then // Divisible, and int not equal to int_2, NOT PRIME
set int_2 = 0
endif

if (int_2 == 0) then        // If Its not a Prime Number
call BJDebugMsg(I2S(int)+&quot; is NOT Prime!&quot;)
set checked = false
set isPrime = false
else                        // Checking...
if(int_2-1 == 1) then   // If the next number becomes 1, and so far it still prime, then the number IS PRIME!
call BJDebugMsg(I2S(int)+&quot; IS Prime!&quot;)
set checked = false
set isPrime = true
else
set int_2 = int_2 - 1
call CheckPrime(int_2)
endif
endif
endif
return isPrime
endfunction

endscope``````

#### BlackRose

##### Forum User
JASS:
``````.
if(isPrime == true) then
return true
else
return false
endif``````

Can simply become [ljass]return isPrime[/ljass].

I also suggest you drop that header style, it looks terrible! May I also suggest you add a space after each [ljass]//[/ljass]? It looks neater.

#### DioD

##### New Member
JASS:
``int_2-1 == 1``

vs
JASS:
``int_2 == 2``

and what is PRIME and what this code doing, i personally dont understand it.

#### priest170234

##### New Member
I stated in the Description.

PRIME is a number whose factors is ONLY itself and 1 where integers below 2 are not considered prime.

General chit-chat
Help Users
• No one is chatting at the moment.
• The Helper:
I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
• The Helper:
What is up Old Mountain Shadow?
• The Helper:
Happy Thursday!
+1
• Varine:
Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
• Varine:
I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
• Varine:
Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
• Varine:
So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
• Varine:
I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
• Varine:
Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
• Varine:
Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
• Ghan:
Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
• The Helper:
Power back on finally - all is good here no damage
+2
• V-SNES:
Happy Friday!
+1
• The Helper:
New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
• The Helper:
I think we need to add something to the bottom of the front page that shows the Headline News forum that has a link to go to the News Forum Index so people can see there is more news. Do you guys see what I am saying, lets say you read all the articles on the front page and you get to the end and it just ends, no kind of link for MOAR!
• The Helper:
Happy Wednesday!
+1
• V-SNES:
Happy Friday!
+1
• The Helper:
Sticking with the desserts for now the latest recipe is Fried Apple Pies - https://www.thehelper.net/threads/recipe-fried-apple-pies.194297/
• The Helper:
Finally finding about some of the bots that are flooding the users online - bytespider apparently is a huge offender here - ignores robots.txt and comes in from a ton of different IPs