Ryoko's Reviving Creep Bug

[Caldwerl]

I found a bug with Ryoko's Revive creep trigger.

Let's say I killed a rabbit and a dog at the SAME time. The rabbit WON'T respawn. But the dog will spawn twice.

http://www.thehelper.net/forums/showthread.php?t=8296

Go there and scroll down to Ryoko's second post. The "Ryoko Heroes, Creeps, and Items 2.w3x" thing is what I downloaded.

 

[0cossin77]

cause ur using "last died unit" and such, sence the dog died "last" it spawns 2 of them

 

[SD_Ryoko]

No, I'm using 'GetDyingUnit()'.

It worked fine just now when i tested it, everything came back correctly.

Are you sure you copy and pasted the JASS code exactly, and didn't create your own version?

The code uses LOCAL variables, so theres no way it could overwrite itself.

function Trig_Revive_Creeps_Actions takes nothing returns nothing
    local integer CUSTOM
    set CUSTOM = GetUnitUserData(GetDyingUnit())
    call TriggerSleepAction( 60.00 )
    call CreateNUnitsAtLoc( 1, udg_Creep_Type[CUSTOM], Player(PLAYER_NEUTRAL_AGGRESSIVE), udg_Creep_Position[CUSTOM], bj_UNIT_FACING )
    call SetUnitUserData( GetLastCreatedUnit(), CUSTOM )
endfunction

//===========================================================================
function InitTrig_Revive_Creeps takes nothing returns nothing
    set gg_trg_Revive_Creeps = CreateTrigger(  )
    call TriggerRegisterPlayerUnitEventSimple( gg_trg_Revive_Creeps, Player(PLAYER_NEUTRAL_AGGRESSIVE), EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( gg_trg_Revive_Creeps, function Trig_Revive_Creeps_Actions )
endfunction

 

[Caldwerl]

Well I'm pretty sure what I did was something it didn't like. I used an area affect on them and it did it. If you try using an area affect that kills them at like the same exact time then I think that creates the bug. I used the exact same thing from your trigger. Everything is the same. Try doing what I said. 'Cause it still does it.

Here's my game.

Look at the triggers and stuff. Also try using an area affect on a dog and rabbit. You'll see what I'm talking about.

 

[phyrex1an]

The only thing that can bug Ryokos trigger is (if you didnt make something wrong when you copied it) to use "set custom vaule of unit" on a unit that is supposed to respawn.

 

[Caldwerl]

What do you mean phyrex1an? Explain yourself I have to go.

 

[SD_Ryoko]

OHH I see. I didn't know you used an AOE.

Then its GetDyingUnit() that could be a problem.

Change that part of the code to:

GetTriggerUnit()

And let me know.

 

[phyrex1an]

OHH I see. I didn't know you used an AOE.

Then its GetDyingUnit() that could be a problem.

Change that part of the code to:

GetTriggerUnit()

And let me know.

Is there a differens beetwen GetDyingUnit() and GetTriggerUnit() in a trigger fired by an death event? Didnt know that.

 

[SD_Ryoko]

My best guess is sometimes there is more than one triggering unit, so you can use 'dying unit', 'entering unit' etc.

In this case, I might guess, there are multiple 'dying units'.

So I don't have a solid answer, but thats what I would try first - to see if it works properly.

 

[Caldwerl]

I used it and it worked. ok, thanks for your help.