Snippet Set Hero Level

Nestharus

o-o
Reaction score
84
SetHeroLevel is buggy. SetHeroLevel(6553) will set it to the max level. Anything above 6553 doesn't work. You have to set to 6553 (max level) and then strip to get down to correct level between 6553 and 10000.

JASS:

library SetHeroLevelX
    function SetHeroLevelX takes unit whichUnit, integer level returns nothing
        if (level<6553) then
            call SetHeroLevel(whichUnit,level,false)
        else
            call SetHeroLevel(whichUnit,6553,false)
            if (GetHeroLevel(whichUnit)!=level) then
                call UnitStripHeroLevel(whichUnit,GetHeroLevel(whichUnit)-level)
            endif
        endif
    endfunction
endlibrary
 

Furby

Current occupation: News poster
Reaction score
144
At least write one sentence about it. Why would someone want to use it?
 

Laiev

Hey Listen!!
Reaction score
188
Can I suggest you to do a system with things about Level? ^_^

Instead of snipped's?
 

Frozenhelfir

set Gwypaas = Guhveepaws
Reaction score
56
I suggest adding a boolean to the argument list to loop the level set. If a map has any triggers in it that fire on a hero level up the triggers only fire once when you SetHeroLevel. If someone has something like triggered attributes or anything that requires doing every level this wont meet requirements.
 

Nestharus

o-o
Reaction score
84
With default xp settings, at level 6552, the xp is at 2146584576. The reason 6553 turns into 10,000 is because the xp overflows (2^31, or 2147483648 is max).


xp is stored in an unsigned int. If you look at a level 9268, you see this
4294734080 out of 693248

unsigned limit: 4294967296


so it overflows. The real value is 693248+4294967296


If you added 233216, it shows
0 out of 693248


What this means is that in order to get actual required xp for a given level, you have to do it in this format

xp+4294967296^power

However, because integers are signed

xp+(2^31)^power1+(2^32)^power2

so you'd have 3 values to represent proper xp.


When adding xp, it bugs due to overflow errors. If you were to add 2^31-1 xp to a level 1, it would go to level 10,000 due to overflow errors. We saw that level 9268 required 4294734080 xp.

2147483647 out of
4294734080

Clearly, the unit with 2147483647 is not even at level 9268.


10,000 requires 704825856 xp (bugged overflow). In order to see how wc3 handles the max level, I now add 704825856-1

resulting level: 3754

I now add 704825857

resulting level: 3754 with 704825856 xp

What this means is that you can only safely add hero max level xp at a time up to when it overflows. However, because it overflows at a level that requires less xp than 2^31, this means that wc3 was coded stupidly. wc3 uses integers when computing levels but stores the actual xp in an unsigned int. This would explain why when adding 704825856 many times results in a level 6502 that is not into its level at all (adding -xp just sends it to minimum xp for level) whereas adding it 3x results in a 6502 that is almost level 6503.



What this means is that a couple of my own libs do not currently work correctly

-> UnitStatePercent
-> SetHeroLevelX


I will be fixing them though =).



Now, the next bug to address is why UnitStripHeroLevel gives more -regen than necessary. If you continue to strip down from 10,000, your hero will eventually have -xp (very, very, very strange considering the ints should be unsigned, unless ofc they have an extra bit for the sign).


I will hopefully get this library fixed to reflect latest research into how wc3 handles xp.


This ofc means that UnitStatePercent is bugged too.


It also means that GetHeroXP is bugged... it's all bugged : (
 

Nestharus

o-o
Reaction score
84
Ok, this will only work with default settings. I'm actually working on a library that fixes hero levels so that this will not be needed eventually. It also improves bounty and lumber (since a lot of overhead can be saved by addressing bounty/lumber as well as hero levels).


Only prob is this new library is using UnitIndexer, so it won't be making it to thehelper :\.
 

Bribe

vJass errors are legion
Reaction score
67
I hope someone makes a cure for AIDS. The API's unsightliness blights my eyes.
 

Dirac

22710180
Reaction score
147
I hope someone makes a cure for AIDS.
This made my day.

But bribe is correct, you can't ask Nes to make a version for aids when he has his own fully functional and faster system that people refuse to use because, well, nes did it
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top