System SingleTimer

Status
Not open for further replies.

Dirac

22710180
Reaction score
147
This is very insane, but i already did it and i find no reason to not post it.
JASS:
library SingleTimer
//**************************************************
//SingleTimer

//A system that allows you to fire timers and attach data to them.
//      -Uses only 1 timer for the entire system
//      -Does not uses hahstables
//      -Timers don't have to be initialized or destroyed

//How to implement?
//  -Create a new trigger called SingleTimer and copy-paste
//  this library into it
//  -It requires JNGP

//API:
//  function STimer takes integer Data, real Timeout, function Code
//      -Puts a timer in a queue, fires it after the timeout completes,
//      this timer can't be stopped once fired.
//  function GetExpiredTimerData takes nothing returns integer
//      -Returns the data attached to the timer, use only at the code that
//      the timer fires when finished.
//**************************************************

    globals
        private timer mt=CreateTimer()
    endglobals
    
    private struct ST
        thistype prev
        thistype next
        
        real e
        trigger t
        integer i
        
        static thistype first=0
        static thistype data
        
        private static method onInit takes nothing returns nothing
            //this is not a magic number
            set thistype(0).e=36000
        endmethod
    endstruct
    
    private function hookTimer takes nothing returns nothing
        local ST this=ST.first
        local ST prev=this
        
        //Removes the instance from the chain
        set this.prev.next=this.next
        set this.next.prev=this.prev
        
        //Prepares to start the next timer
        set this=this.next
        set ST.first=this
        
        //This reduces the time remaining of each timer after a timer ends
        loop
            exitwhen this==0
            set this.e=this.e-prev.e
            set this=this.next
        endloop
        
        //Start the next timer
        if ST.first>0 then
            call TimerStart(mt,ST.first.e,false,function hookTimer)
        endif
        
        //Fires the code attached to the timer
        set ST.data=prev
        call TriggerEvaluate(prev.t)
        call DestroyTrigger(prev.t)
        call prev.destroy()
    endfunction
    
    function GetExpiredTimerData takes nothing returns integer
        return ST.data.i
    endfunction
    
    function STimer takes integer i,real d,code c returns nothing
        local real r=TimerGetElapsed(mt)
        local ST this=ST.create()
        local ST prev=this
        
        //Linked-list magic
        set ST(0).next.prev=this
        set this.next=ST(0).next
        set ST(0).next=this
        set this.prev=ST(0)

        set this.i=i
        if d>r then
            set this.e=d-r
        else
            set this.e=d
        endif
        //I hate to have to do this
        set this.t=CreateTrigger()
        call TriggerAddCondition(this.t,Condition(c))
        
        //This magic loop orders the chain according to this.e
        loop
            exitwhen this==0
            if this.next.e<this.e then
                set this.next.prev=this.prev
                set this.prev=this.next
                set this.next=this.next.next
                set this.prev.next=this
                set this.next.prev=this
                set this.prev.prev.next=this.prev
            else
                set this=this.next
            endif
        endloop
        
        //if the previous member of this instance is 0 that means it's the first timer
        if prev.prev==0 then
            set ST.first.e=ST.first.e-r
            set ST.first=prev
            call TimerStart(mt,ST.first.e,false,function hookTimer)
        endif
    endfunction
endlibrary
 

Nestharus

o-o
Reaction score
84
This is horribly done and would be incredibly worse than using standard JASS timers with a hashtable + get handle id call.


This is thus 100% worthless and should be gy'd.


A proper 1 timer system makes use of a minimum binary heap of queues. If that design is over your head, then don't bother trying to make a timer system as anything you make will be bad.


I'll be getting to the single timer system eventually =).
 

Dirac

22710180
Reaction score
147
You're mostly right, as i said in the main post, this is very insane.

>then don't bother trying to make a timer system as anything you make will be bad.

this was very mean, i just posted it to see what happened, tried to create a thread around the JASS help section and got no replies at all. I just thought the idea of creating a system that uses only 1 timer would be cool, this is nothing more than an experiment. Also i would like you to point out why is it bad, that is the point of replies to things posted in this area.

EDIT: i would like a moderator to delete this thread
 

Nestharus

o-o
Reaction score
84
A tip..

don't submit something as a resource that you know is crap and that you know is never going to get approved. If you want tips or w/e, show it at the JASS Help section.



And as for what's bad in your resource, it's every single line of code. The entire resource, 100%, is bad.


The only line you did right was this
[ljass]private timer mt=CreateTimer()[/ljass]


I already told you in the previous post what a proper 1 timer system does. As your system isn't even remotely like that, it obviously needs to be 100% scrapped.
 
Status
Not open for further replies.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top