Special effect problem

[Kazuga]

Ok I got this small problem once again^^ I must have coded wrong but I don't know how to fix it.. The error only says "Syntax error"=/

scope Lightnings
private function Conditions takes nothing returns boolean
return GetSpellAbilityId() == 'AEbl'
endfunction
private function Actions takes nothing returns nothing
    call AddSpecialEffectLocBJ(( 0 , 0), "Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl" )
    call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), PolarProjectionBJ(0,0), 256, 0), bj_UNIT_FACING )
endfunction

//===========================================================================
public function InitTrig takes nothing returns nothing
 local trigger trig = CreateTrigger()
 call TriggerRegisterAnyUnitEventBJ(trig, EVENT_PLAYER_UNIT_SPELL_EFFECT )
 call TriggerAddCondition (trig, Condition (function Conditions ) )
 call TriggerAddAction (trig, function Actions )
endfunction

endscope

Any help would be mostly apriciated:thup:
Thanks on beforehand, have a nice continiued evening^^

 

[Larcenist]

Change

"Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl"

to

"Abilities\\Spells\\Undead\\AnimateDead\\AnimateDeadTarget.mdl"

You can also use

call DestroyEffect(AddSpecialEffect(...))

 

[Flare]

call AddSpecialEffectLocBJ(( 0 , 0), "Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl" )

The (0, 0) bit is invalid. Should be Location (0, 0)

 

[Kazuga]

Ah, thanks both of you^^
How do I set points so it doesn't leak?
And also what should be changed in this action/function or whatever it's called^^

    call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), PolarProjectionBJ(0,0), 256, 0), bj_UNIT_FACING )

Error message is Syntax error as usual =/

 

[Larcenist]

    call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), PolarProjectionBJ(0,0), 256, 0), bj_UNIT_FACING )

Should be:

    call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), PolarProjectionBJ(0,0), 256, 0, bj_UNIT_FACING )

Remove that extra ")".

 

[AdamGriffith]

Should be:

call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), PolarProjectionBJ(Location(0, 0), 256, 0), bj_UNIT_FACING )

Different answers... who is right? ;p
It's so going to be me!

EDIT: You shouldn't get a syntax error. You should get some form of argument error.

 

[Larcenist]

Oh yeah it should.

Though one thing about JASS is that it's faster than GUI if you make it like that. Avoid BJs, that's the first key to success. In your function list you can search for the BJs and see what they call, then work your way around it. PolarProjectionBJ for example:

px = GetLocationX(Source) + Distance * Cos(Angle * bj_DEGTORAD)
py = GetLocationY(Source) + Distance * Sin(Angle * bj_DEGTORAD)

return Location(px, py)

Different answers... who is right? ;p
It's so going to be me!

My excuse is that I refrain from using BJs D:

 

[Kazuga]

That actually made it much more complicated.. I'm not very good with Sin and cos. Why is bj:s bad? (Was converted into it from gui)

 

[Knight7770]

Why is bj:s bad? (Was converted into it from gui)

From what I gather, it's because they're made crappily, and all they do is call other functions. Which is bad.

 

[AdamGriffith]

A BJ refers to a function in Blizzard.j

Taken from Blizzard.j:

//===========================================================================
function PolarProjectionBJ takes location source, real dist, real angle returns location
    local real x = GetLocationX(source) + dist * Cos(angle * bj_DEGTORAD)
    local real y = GetLocationY(source) + dist * Sin(angle * bj_DEGTORAD)
    return Location(x, y)
endfunction

So when you use the function PolarProjectionBJ is calls this function and returns you a point as shown above.

Basically, if you put that straight into your code, it is faster than the game searching for this BJ function.
(I hope I have explainded it right).

 

[Larcenist]

BJs call natives, and the more function calls a code has got the slower it'll get.

Also try to use X and Y values rather than locations, XY are faster than locations too.

Instead of using GetUnitLoc() just do:

local unit Unit = GetTriggerUnit()
local real x = GetUnitX(Unit)
local real y = GetUnity(Unit)
local unit Unit2 = CreateUnit(GetOwningPlayer(Unit), 'hfoo', x, y, 0)

And you successfully created a unit on top of Unit, without even creating a location that has to be removed and nulled.

 

[Kazuga]

Ah, finally something I do understand^^ Ok thanks, great explenation about the BJ:s btw:thup:

 

[AdamGriffith]

Except arn't you supposed to null locals?

For future reference this would be a workaround:

    local location source = GetRectCenter(GetPlayableMapRect())
    local real dist = 256
    local real angle = 45
    local real x = GetLocationX(source) + dist * Cos(angle * bj_DEGTORAD)
    local real y = GetLocationY(source) + dist * Sin(angle * bj_DEGTORAD)
    local location point = Location(x, y)

Even though that still has two bj's in it!

 

[Larcenist]

You're supposed to null locals that extends handles, examples are units, locations, groups, timers etc.

 

[AdamGriffith]

Aha!
Thanks

(Sorry, taken over your thread)

 

[Kazuga]

I'm sorry for the massive amounts of questions^^
How do you set a pont with polar offset and then use it for example creating an special effect there?

 

[AdamGriffith]

Confused?
Just create the special effect at the point?

    local location p1
    local location p1
    set p1 = ...
    set p2 = PolarProjectionBJ(p1, 256, 0)
    call AddSpecialEffectLocBJ( p2, "Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl" )

Is that what your asking?

EDIT: Or maybe:

    set bj_lastCreatedEffect = AddSpecialEffectLoc(modelName, where)

 

[Kazuga]

Hm but shoudn't I try to avoid the bj?

Edit: Hm somethings wrong..

local location point1 = GetUnitLoc(GetTriggerUnit)
local location point2 = PolarProjectionBJ(point1,300,0)

He says "Undeclared variable GetTriggerUnit"...

 

[PurgeandFire]

GetTriggerUnit[U][I][B]()[/B][/I][/U]

 

[Kazuga]

Hehe I allways forgot about those^^
However, how do you add values to integers and reals? Also is this the correct way to write out the angle value in a polar offset?

scope Lightnings
private function Conditions takes nothing returns boolean
return GetSpellAbilityId() == 'AEbl'
endfunction
private function Actions takes nothing returns nothing
local real real1 = GetUnitFacing(GetTriggerUnit())
real1=real1+90
local location point1 = GetUnitLoc(GetTriggerUnit())
local location point2 = PolarProjectionBJ(point1,300,real1+35)
call AddSpecialEffectLocBJ(point2,"Abilities\\Spells\\Undead\\AnimateDead\\AnimateDeadTarget.mdl")
local location point1 = GetUnitLocGetTriggerUnit())
local location point2 = PolarProjectionBJ(point1,200,real1+35
endfunction

//===========================================================================
public function InitTrig takes nothing returns nothing
 local trigger trig = CreateTrigger()
 call TriggerRegisterAnyUnitEventBJ(trig, EVENT_PLAYER_UNIT_SPELL_EFFECT )
 call TriggerAddCondition (trig, Condition (function Conditions ) )
 call TriggerAddAction (trig, function Actions )
endfunction

endscope