sry but, were do i put this?

S

sunshinex3

You can change this now in User CP.
Reaction score
7
call UnitMakeAbilityPermanent(unit, true, ability)

// i need to make abilities given permanent; were do i place the line above into the trigger below?

function Trig_unit_bonuses_Conditions takes nothing returns boolean
if ( not ( IsUnitType(GetKillingUnitBJ(), UNIT_TYPE_HERO) == false ) ) then
return false
endif
return true
endfunction

function Trig_unit_bonuses_Func001Func001C takes nothing returns boolean
if ( not ( GetUnitAbilityLevelSwapped('A0Z2', GetKillingUnitBJ()) <= 100 ) ) then
return false
endif
return true
endfunction

function Trig_unit_bonuses_Func001C takes nothing returns boolean
if ( not ( GetUnitAbilityLevelSwapped('A0Z2', GetKillingUnitBJ()) < 1 ) ) then
return false
endif
return true
endfunction

function Trig_unit_bonuses_Actions takes nothing returns nothing
if ( Trig_unit_bonuses_Func001C() ) then
call UnitAddAbilityBJ( 'A0Z2', GetKillingUnitBJ() )
call UnitAddAbilityBJ( 'A0Z3', GetKillingUnitBJ() )
call UnitAddAbilityBJ( 'A0Z5', GetKillingUnitBJ() )
else
if ( Trig_unit_bonuses_Func001Func001C() ) then
call IncUnitAbilityLevelSwapped( 'A0Z2', GetKillingUnitBJ() )
call IncUnitAbilityLevelSwapped( 'A0Z3', GetKillingUnitBJ() )
call IncUnitAbilityLevelSwapped( 'A0Z5', GetKillingUnitBJ() )
else
call DoNothing( )
endif
endif
endfunction

//===========================================================================
function InitTrig_unit_bonuses takes nothing returns nothing
set gg_trg_unit_bonuses = CreateTrigger( )
call TriggerRegisterAnyUnitEventBJ( gg_trg_unit_bonuses, EVENT_PLAYER_UNIT_DEATH )
call TriggerAddCondition( gg_trg_unit_bonuses, Condition( function Trig_unit_bonuses_Conditions ) )
call TriggerAddAction( gg_trg_unit_bonuses, function Trig_unit_bonuses_Actions )
endfunction


// this is the trigger above, where do i place the line?; call UnitMakeAbilityPermanent(unit, true, ability)
 
jonas

jonas

Ultra Cool Member
Reaction score
47
You don't have to convert the whole trigger to JASS to insert a single line. There is a "custom script" action in the trigger editor.
 
S

sunshinex3

You can change this now in User CP.
Reaction score
7
unit bonuses
Events
Unit - A unit Dies
Conditions
((Killing unit) is A Hero) Equal to False
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Level of Damage Bonus (all units) for (Killing unit)) Less than 1
Then - Actions
Unit - Add Damage Bonus (all units) to (Killing unit)
Unit - Add Armor Bonus (All Units) to (Killing unit)
Unit - Add Attack Speed Bonus (All Units) to (Killing unit)
Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Level of Damage Bonus (all units) for (Killing unit)) Less than or equal to 100
Then - Actions
Unit - Increase level of Damage Bonus (all units) for (Killing unit)
Unit - Increase level of Armor Bonus (All Units) for (Killing unit)
Unit - Increase level of Attack Speed Bonus (All Units) for (Killing unit)
Else - Actions
Do nothing

lol, im so stupid, were do i put it in the custom script in?
 
S

sunshinex3

You can change this now in User CP.
Reaction score
7
also for the part call (unit, true, ability) do i need to alter unit, to be killing unit and the ability to be the name of the actual ability.
 
jonas

jonas

Ultra Cool Member
Reaction score
47
sunshinex3 said:
also for the part call (unit, true, ability) do i need to alter unit, to be killing unit and the ability to be the name of the actual ability.
Click to expand...
Yes.

I would asume you want to put it below the Add Ability
 
S

sunshinex3

You can change this now in User CP.
Reaction score
7
finally figured it out. will make a new post explaining it. (post name: MakeAbilityPermanent)

this is the end trigger:
Code: 
[noparse]
unit bonuses
  Events
  Unit - A unit Dies
  Conditions
  ((Killing unit) is A Hero) Equal to False
  Actions
  If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  If - Conditions
  (Level of Damage Bonus (all units) for (Killing unit)) Less than 1
  Then - Actions
  Unit - Add Damage Bonus (all units) to (Killing unit)
  Custom script:  call UnitMakeAbilityPermanent(GetKillingUnitBJ() , true, 'A0Z2')
  Unit - Add Armor Bonus (All Units) to (Killing unit)
  Custom script:  call UnitMakeAbilityPermanent(GetKillingUnitBJ() , true, 'A0Z3')
  Unit - Add Attack Speed Bonus (All Units) to (Killing unit)
  Custom script:  call UnitMakeAbilityPermanent(GetKillingUnitBJ() , true, 'A0Z5')
  Else - Actions
  If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  If - Conditions
  (Level of Damage Bonus (all units) for (Killing unit)) Less than 100
  Then - Actions
  Unit - Increase level of Damage Bonus (all units) for (Killing unit)
  Unit - Increase level of Armor Bonus (All Units) for (Killing unit)
  Unit - Increase level of Attack Speed Bonus (All Units) for (Killing unit)
  Else - Actions
  Do nothing
[B]
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    Starting this upcoming Thursday, I will be in Japan for 10 days.
  • tom_mai78101 tom_mai78101:
    Thursday - Friday will be my Japan arrival flight. 9 days later, on a Sunday, will be my return departure flight.
     +2
  • The Helper The Helper:
    Hope you have safe travels my friend!
     +1
  • vypur85 vypur85:
    Wow spring time in Japan is awesome. Enjoy!
  • The Helper The Helper:
    Hopefully it will be more pleasure than work
  • mgarcia mgarcia:
    you might want to inform your discord users about this: https://twitter.com/nukboii/status/1634186742415646720?t=_Ctwln_t4s7dzwH8IbmaDA&s=19
     +1
  • The Helper The Helper:
    https://www.youtube.com/watch?v=Kn0HH-81daA
     +1
  • vypur85 vypur85:
    Recently tried out ChatGPT about WE triggering. Wow it's capable of giving a somewhat legitimate response.
  • The Helper The Helper:
    I am sure it has read all the info on the forums here
  • The Helper The Helper:
    i think triggering is just scripting and chatgpt is real good at code
  • vypur85 vypur85:
    Yeah I suppose so. It's interesting how it can explain in so much detail.
  • vypur85 vypur85:
    But yet it won't work.
  • The Helper The Helper:
    it does a bad ass job doing excel vba code it has leveled me up at my job when I deal with excel that is for sure
  • vypur85 vypur85:
    Nice! I love Excel coding as well. Has always been using Google to help me. Maybe I'll use ChatGPT next time when I need it.
  • The Helper The Helper:
    yeah whatever it puts out even if it is not perfect I can fix it and the latest version of chatgpt can create websites from pictures it will not be long until it can do that with almost all the tools
     +1
  • The Helper The Helper:
    These new Chat AI programs are going to change everything everyone better Buckle the Fuck Up!
  • The Helper The Helper:
    oh and Happy Tuesday Evening! :)
     +1
  • jonas jonas:
    Im worried they'll change things for worse
  • jonas jonas:
    A lot more low quality content, a lot more half-baked stuff.
  • jonas jonas:
    If you're good enough to spot the mistakes of the answers you don't need it in the first place. If you aren't good enough, you're gonna rely on some half-correct stuff
  • The Helper The Helper:
    the earlier AI is and has been used extensively for publishing news and other content for a while now
  • jonas jonas:
    I used to be active on quora, it's now flooded with extremely similar, superficial answers that often miss the point of the question
  • N NJJ:
    hi
  • N NJJ:
    Hello, gathering all my old accounts… :)
     +1
  • The Helper The Helper:
    by all means gather it all up!

    The Helper Discord

    Members online

    Online now:
    128 (members: 1, guests: 127)

    Share this page

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top