Storm Bolt trigger not working

[Jordguitar]

Hello, I'm trying to make a trigger for the ability "Storm Bolt", but I can't seem to get it to work.
It's supposed to have the mountain king being able to detect when a hero drops below a certain amount of health, and then storm bolt them.
But instead he just throws storm bolts at anything at full health and even at random footmen.

Thanks for help!


Storm Bolt
Events
Unit - A unit Is attacked
Conditions
((Attacked unit) is A Hero) Equal to True
(Distance between (Position of Unit_MountainKing) and (Position of (Attacked unit))) Less than or equal to 800.00
((Attacked unit) belongs to an enemy of Player_MountainKing) Equal to True
(Mana of Unit_MountainKing) Greater than or equal to 75.00
Actions
Hero - Learn skill for Unit_MountainKing: Human Mountain King - Storm Bolt
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Level of Storm Bolt for Unit_MountainKing) Equal to 1
Then - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Life of (Attacked unit)) Less than or equal to 100.00
Then - Actions
Unit - Order Unit_MountainKing to Human Mountain King - Storm Bolt (Attacked unit)
Else - Actions
Do nothing
Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Level of Storm Bolt for Unit_MountainKing) Equal to 2
Then - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Life of (Attacked unit)) Less than or equal to 225.00
Then - Actions
Unit - Order Unit_MountainKing to Human Mountain King - Storm Bolt (Attacked unit)
Else - Actions
Do nothing
Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Level of Storm Bolt for Unit_MountainKing) Equal to 3
Then - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Life of (Attacked unit)) Less than or equal to 350.00
Then - Actions
Unit - Order Unit_MountainKing to Human Mountain King - Storm Bolt (Attacked unit)
Else - Actions
Do nothing
Else - Actions
Do nothing

 

[Jordguitar]

I have three abilities now that doesn't work properly, they all have in common that they trigger when something is attacked, but it doesn't seem like they check for conditions. Not sure what I'm doing wrong

 

[Jordguitar]

This doesn't work either, he keeps storm bolting random units, not heros.

MOUNTAIN KING
Events
Time - Every 0.10 seconds of game time
Conditions
Actions
Hero - Learn skill for Unit_MountainKing: Human Mountain King - Storm Bolt
Unit Group - Pick every unit in (Units within 800.00 of (Position of Unit_MountainKing) matching ((((Owner of (Matching unit)) is an enemy of Player_MountainKing) Equal to True) and ((((Matching unit) is A Hero) Equal to True) and ((Life of (Matching unit)) Less than 100.00)))) and do (Actions)
Loop - Actions
Unit - Order Unit_MountainKing to Human Mountain King - Storm Bolt (Picked unit)

 

[Accname]

Why do you learn the ability every 0.1 seconds?

Could it be that other triggers mess with this one?

Both of these versions work perfectly fine for me:

• StormBolt
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Attacking unit) Equal to Mountain King 0000 <gen>
    • ((Triggering unit) is A Hero) Equal to True
    • ((Triggering unit) belongs to an enemy of (Owner of Mountain King 0000 <gen>)) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Life of (Triggering unit)) Less than or equal to 350.00
      • Then - Actions
        • Unit - Order Mountain King 0000 <gen> to Human Mountain King - Storm Bolt (Triggering unit)
      • Else - Actions

• StormBolt
  • Events
    • Time - Every 0.75 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units within 512.00 of (Position of Mountain King 0000 <gen>) matching ((((Matching unit) is A Hero) Equal to True) and ((((Matching unit) is alive) Equal to True) and ((Life of (Matching unit)) Less than or equal to 300.00)))) and do (Actions)
      • Loop - Actions
        • Unit - Order Mountain King 0000 <gen> to Human Mountain King - Storm Bolt (Picked unit)

 

[Jordguitar]

That was just so he levels the ability to do maximum damage all the time
I don't think other triggers are messing with it, I've checked everything. Maybe it could be because of memory leaks? Not sure if that's possible.
In your first trigger, why is

• (Life of (Triggering unit)) Less than or equal to 350.00
  
  In a seperate condition?
  And what's the difference of the triggering and attacking unit in "a unit is attacked" event?
  Just trying to understand, quite new to map making x)

 

[Jordguitar]

I've been working on a better one, but he keeps storm bolting full life heros, and random ghouls for a reason I don't understand


Storm Bolt
Events
Unit - A unit Is attacked
Conditions
((Attacked unit) is A Hero) Equal to True
((Attacked unit) belongs to an enemy of (Owner of Unit_MountainKing)) Equal to True
(Attacked unit) Not equal to Unit_MountainKing
(Percentage life of (Attacked unit)) Less than 30.00
(Mana of Unit_MountainKing) Greater than 75.00
Actions
Set StormBoltAttacked_Unit = (Attacked unit)
Set StormBolt_Point[0] = (Position of StormBoltAttacked_Unit)
Set StormBolt_Point[1] = (Position of Unit_MountainKing)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Unspent skill points of Unit_MountainKing) Greater than or equal to 0
Then - Actions
Hero - Learn skill for Unit_MountainKing: Storm Bolt (Mountain King)
Else - Actions
Do nothing
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Distance between StormBolt_Point[0] and StormBolt_Point[1]) Less than 800.00
Then - Actions
Unit - Order Unit_MountainKing to Human Mountain King - Storm Bolt StormBoltAttacked_Unit
Unit - Order Unit_MountainKing to Attack StormBoltAttacked_Unit
Else - Actions
Do nothing
Custom script: call RemoveLocation(udg_StormBolt_Point[0])
Custom script: call RemoveLocation(udg_StormBolt_Point[1])
Set StormBoltAttacked_Unit = No unit
Trigger - Turn off (This trigger)
Wait 9.00 seconds
Trigger - Turn on (This trigger)

 

[Accname]

That was just so he levels the ability to do maximum damage all the time
I don't think other triggers are messing with it, I've checked everything. Maybe it could be because of memory leaks? Not sure if that's possible.
In your first trigger, why is

• (Life of (Triggering unit)) Less than or equal to 350.00
  
  In a seperate condition?
  And what's the difference of the triggering and attacking unit in "a unit is attacked" event?
  Just trying to understand, quite new to map making x)

Memory leaks will only make your map lag after some time. Its thrown away memory (RAM) that can no longer be used until the game is over. They have no effect on what will actually happen during the game.

There is no real reason why I put the condition for the life-value into a separate condition. The trigger looked different at first and then I gradually changed it to test a few things.

It is always recommended to use "triggering unit" whenever possible. The "triggering unit" variable is local to each invocation of a trigger and can not be overwritten. All other variables are globals which might be overwritten when you use a "wait" action or call a different trigger directly.



In your latest trigger try to change

• (Percentage life of (Attacked unit)) Less than 30.00

to

• (Percentage life of (Attacked unit)) Less than 0.30

because 100% is 1.0 and 30% is 0.3.

By the way, this

• (Attacked unit) Not equal to Unit_MountainKing

is also a pretty useless line of code.
And you may also want to test whether the mana of the mountain king is greater than OR EQUAL to 75. Otherwise you would need at least 76 mana to use Storm Bolt which is probably not what you want.

 

[Jordguitar]

Oh, but he storm bolts alright, so I don't think it's a problem with the mana.
And

• (Attacked unit) Not equal to Unit_MountainKing
  
  Is to make sure he doesn't target himself with it.
  
  After changing that, he completely ignores heros with low hp, letting one run right pass him and then he storm bolted a ghoul again. Hahah. Stupid mountain king.

 

[Jordguitar]

In your latest trigger try to change
Trigger:

• (Percentage life of (Attacked unit)) Less than 30.00

to
Trigger:

• (Percentage life of (Attacked unit)) Less than 0.30

because 100% is 1.0 and 30% is 0.3.

By the way, this

Are you sure this is true? Because I have another trigger that makes enemy hero units run away once they're below 30% life, and that works well