Tag Script not properly rescuing.

B

Blackrage

Ultra Cool Member
Reaction score
25
For some reason, the part where it rescues (TraditionalActions) doesnt work. Can anyone tell me why that happens?

Runner is a variable from a different trigger.

JASS:
library Tag initializer Init requires BoolexprUtils
    globals
        private constant integer WispId = 'n000'
        group TaggedGroup = CreateGroup()
        private integer array RunnerType
        integer TaggedAmt = 0
    endglobals
    
    private function TraditionalActions takes nothing returns nothing
        local unit u = GetEnteringUnit()
        local unit PickedUnit
        local integer i = 0
        if IsUnitType(u, UNIT_TYPE_PEON) == true then
            loop
                set PickedUnit = FirstOfGroup(TaggedGroup)
                exitwhen PickedUnit == null
                set TaggedAmt = TaggedAmt - 1
                set i = i + 1
                call SetUnitX(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], GetUnitX(PickedUnit))
                call SetUnitY(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], GetUnitY(PickedUnit))
                call ShowUnit(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], true)
                call PauseUnit(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], false)
                call IssueImmediateOrder(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], "stop")
                if (GetLocalPlayer() == Runner[GetPlayerId(GetOwningPlayer(PickedUnit))]) then
                    call ClearSelection()
                    call SelectUnit(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], true)
                endif
                call GroupRemoveUnit(TaggedGroup, PickedUnit)
                call RemoveUnit(PickedUnit)
            endloop
            
            if i > 0 then
                set i = 0
                loop
                    call DisplayTextToPlayer(Player(i), 0, 0, "|c"+PlayerColors[GetPlayerId(GetOwningPlayer(u))]+GetPlayerName(GetOwningPlayer(u))+ColorEnd+" has released the prisoners.")
                    exitwhen i == 11
                    set i = i + 1
                endloop
            endif
        endif
        set u = null
    endfunction
    
    private function SwitchTag takes nothing returns nothing
    endfunction
    
    private function FreezeTag takes nothing returns nothing
    endfunction
    
    private function Action takes nothing returns nothing
        local unit u = GetTriggerUnit()
        local unit k = GetEventDamageSource()
        local player p = GetOwningPlayer(u)
        local unit PickedUnit = null
        local group g = CreateGroup()
        local integer i = 0
        local integer PUI
        local unit w
        
        if IsUnitType(u, UNIT_TYPE_PEON) == true and GetUnitAbilityLevel(u, 'B000') == 0 and GetUnitAbilityLevel(u, 'B003') == 0 then
            if IsUnitAlly(k, GetOwningPlayer(u)) != true then
                set TaggedAmt = TaggedAmt + 1
                call ShowUnit(u, false)
                call PauseUnit(u, true)
                
                call GroupEnumUnitsOfPlayer(g, p, BOOLEXPR_TRUE)
                
                loop
                    set PickedUnit = FirstOfGroup(g)
                    exitwhen PickedUnit == null
                    if IsUnitType(PickedUnit, UNIT_TYPE_STRUCTURE) == true then
                        call KillUnit(PickedUnit)
                    endif
                endloop
                
                loop
                    call DisplayTextToPlayer(Player(i), 0, 0, "|c"+PlayerColors[GetPlayerId(GetOwningPlayer(k))]+GetPlayerName(GetOwningPlayer(k))+ColorEnd+" has tagged "+"|c"+PlayerColors[GetPlayerId(GetOwningPlayer(u))]+GetPlayerName(GetOwningPlayer(u))+ColorEnd+".")
                    exitwhen i == 11
                    set i = i + 1
                endloop
                
                set w = CreateUnit(p, WispId, GetStartLocationX(GetPlayerStartLocation(p)), GetStartLocationX(GetPlayerStartLocation(p)), 0)
                call GroupAddUnit(TaggedGroup, w)
            endif
        endif
        
        set u = null
        set w = null
        set k = null
    endfunction
    
    function AddTag takes unit u returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterUnitEvent(t, u, EVENT_UNIT_DAMAGED)
        call TriggerAddAction(t, function Action)
    endfunction
    
    private function Init takes nothing returns nothing
        local trigger t = CreateTrigger()
        local trigger trig = CreateTrigger()
        local region TagRegion = CreateRegion()
        call RegionAddRect(TagRegion, gg_rct_TagZone)
        call TriggerRegisterEnterRegion(trig, TagRegion, BOOLEXPR_TRUE)
        call TriggerAddAction(trig, function TraditionalActions)
        call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_DEATH)
        call TriggerAddAction(t, function Action)
    endfunction
endlibrary
 
B

Builder Bob

Live free or don't
Reaction score
249
"Doesn't work" doesn't say much.

I don't know what's supposed to happen, what happens, and what doesn't happen as it should.

Maybe if I played Tag games I would understand. I'll try to help if I can get more information.
 
B

Blackrage

Ultra Cool Member
Reaction score
25
K, my tag system works like this:

You get initialized into the tag trigger when you pick your runner. Then, it will detect whenever you get damaged and run the Action function for that unit. It will hide the unit and pause it and create a wisp at the center of the map. The wisp can move around freely with 0 collision (and foot movement pathing). When someone goes into the center rect (gg_rct_TagZone), they will resurrect all the people who got tagged at their wisp's current x and y coordinates.

However, the trigger where someone goes into the center doesn't trigger at all.
 
B

Builder Bob

Live free or don't
Reaction score
249
Alright.

I'm assuming you call AddTag when you pick your runner as you say, and that the wisps are created when you get damaged.

The TagRegion looks like it is created correctly, so as long as the region is called TagZone, units entering should trigger the function TraditionalActions when they enter it.

I think maybe the problem lies in the function TraditionalActions itself.

What do you see printed on the screen if you try replacing it with this version of TraditionalActions?

JASS:
private function TraditionalActions takes nothing returns nothing
	local unit u = GetEnteringUnit()
	local unit PickedUnit
	local integer i = 0
	call BJDebugMsg("TraditionalActions has fired")
	if IsUnitType(u, UNIT_TYPE_PEON) == true then
		call BJDebugMsg("Entering UNIT_TYPE_PEON == true")
		loop
			set PickedUnit = FirstOfGroup(TaggedGroup)
			exitwhen PickedUnit == null
			call BJDebugMsg(GetUnitName(PickedUnit) + " has been rescued")
			set TaggedAmt = TaggedAmt - 1
			set i = i + 1
			call SetUnitX(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], GetUnitX(PickedUnit))
			call SetUnitY(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], GetUnitY(PickedUnit))
			call ShowUnit(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], true)
			call PauseUnit(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], false)
			call IssueImmediateOrder(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], "stop")
			if (GetLocalPlayer() == Runner[GetPlayerId(GetOwningPlayer(PickedUnit))]) then
				call ClearSelection()
				call SelectUnit(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], true)
			endif
			call GroupRemoveUnit(TaggedGroup, PickedUnit)
			call RemoveUnit(PickedUnit)
		endloop
		call BJDebugMsg("checkpoint 1 reached")
		if i > 0 then
			set i = 0
			loop
				call DisplayTextToPlayer(Player(i), 0, 0, "|c"+PlayerColors[GetPlayerId(GetOwningPlayer(u))]+GetPlayerName(GetOwningPlayer(u))+ColorEnd+" has released the prisoners.")
				exitwhen i == 11
				set i = i + 1
			endloop
		endif
		call BJDebugMsg("checkpoint 2 reached")
	else
		call BJDebugMsg("Entering UNIT_TYPE_PEON == false")
	endif
	set u = null
endfunction
 
B

Blackrage

Ultra Cool Member
Reaction score
25
Hm, it stops working after a while. I have a replay:
 

Attachments

  • Not Working.w3g
    164.9 KB · Views: 83
W

wraithseeker

Tired.
Reaction score
122
Not related to your problem but

JASS:
call SetUnitX(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], GetUnitX(PickedUnit))
                        call SetUnitY(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], GetUnitY(PickedUnit))
                        call ShowUnit(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], true)
                        call PauseUnit(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], false)
                        call IssueImmediateOrder(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], "stop")
                        if (GetLocalPlayer() == Runner[GetPlayerId(GetOwningPlayer(PickedUnit))]) then
                                call ClearSelection()
                                call SelectUnit(Runner[GetPlayerId(GetOwningPlayer(PickedUnit))], true)


Why are you using GetPlayerId? They look nasty.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    The bots will show up as users online in the forum software but they do not show up in my stats tracking. I am sure there are bots in the stats but the way alot of the bots treat the site do not show up on the stats
  • The Helper The Helper:
    New recipe is Shipwreck Dinner - https://www.thehelper.net/threads/recipe-shipwreck-dinner.193511/
  • Varine Varine:
    I want to build a filtration system for my 3d printer, and that shit is so much more complicated than I thought it would be
  • Varine Varine:
    Apparently ABS emits styrene particulates which can be like .2 micrometers, which idk if the VOC detectors I have can even catch that
  • Varine Varine:
    Anyway I need to get some of those sensors and two air pressure sensors installed before an after the filters, which I need to figure out how to calculate the necessary pressure for and I have yet to find anything that tells me how to actually do that, just the cfm ratings
  • Varine Varine:
    And then I have to set up an arduino board to read those sensors, which I also don't know very much about but I have a whole bunch of crash course things for that
  • Varine Varine:
    These sensors are also a lot more than I thought they would be. Like 5 to 10 each, idk why but I assumed they would be like 2 dollars
  • Varine Varine:
    Another issue I'm learning is that a lot of the air quality sensors don't work at very high ambient temperatures. I'm planning on heating this enclosure to like 60C or so, and that's the upper limit of their functionality
  • Varine Varine:
    Although I don't know if I need to actually actively heat it or just let the plate and hotend bring the ambient temp to whatever it will, but even then I need to figure out an exfiltration for hot air. I think I kind of know what to do but it's still fucking confusing
  • The Helper The Helper:
    Maybe you could find some of that information from AC tech - like how they detect freon and such
  • Varine Varine:
    That's mostly what I've been looking at
  • Varine Varine:
    I don't think I'm dealing with quite the same pressures though, at the very least its a significantly smaller system. For the time being I'm just going to put together a quick scrubby box though and hope it works good enough to not make my house toxic
  • Varine Varine:
    I mean I don't use this enough to pose any significant danger I don't think, but I would still rather not be throwing styrene all over the air
  • The Helper The Helper:
    New dessert added to recipes Southern Pecan Praline Cake https://www.thehelper.net/threads/recipe-southern-pecan-praline-cake.193555/
  • The Helper The Helper:
    Another bot invasion 493 members online most of them bots that do not show up on stats
  • Varine Varine:
    I'm looking at a solid 378 guests, but 3 members. Of which two are me and VSNES. The third is unlisted, which makes me think its a ghost.
     +1
  • The Helper The Helper:
    Some members choose invisibility mode
     +1
  • The Helper The Helper:
    Latest Recipe is Garlic Parmesan Chicken https://www.thehelper.net/threads/recipe-garlic-parmesan-chicken.193575/
  • The Helper The Helper:
    I bitch about Xenforo sometimes but it really is full featured you just have to really know what you are doing to get the most out of it.
  • The Helper The Helper:
    It is just not easy to fix styles and customize but it definitely can be done
  • The Helper The Helper:
    I do know this - xenforo dropped the ball by not keeping the vbulletin reputation comments as a feature. The loss of the Reputation comments data when we switched to Xenforo really was the death knell for the site when it came to all the users that left. I know I missed it so much and I got way less interested in the site when that feature was gone and I run the site.
  • Blackveiled Blackveiled:
    People love rep, lol
     +1
  • The Helper The Helper:
    The recipe today is Sloppy Joe Casserole - one of my faves LOL https://www.thehelper.net/threads/sloppy-joe-casserole-with-manwich.193585/
  • The Helper The Helper:
    Decided to put up a healthier type recipe to mix it up - Honey Garlic Shrimp Stir-Fry https://www.thehelper.net/threads/recipe-honey-garlic-shrimp-stir-fry.193595/
  • The Helper The Helper:
    Here is another comfort food favorite - Million Dollar Casserole - https://www.thehelper.net/threads/recipe-million-dollar-casserole.193614/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      272 (members: 1, guests: 271)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top