Spell Temporal Vortex

[Kenny]

The SFX is pwn, who wouldn't want to use it

I hardly believe thats a valid excuss, but it is your spell, so i will leave you too it.

And the walk animation I play so that the unit doesn't continue his casting animation.

Wouldn't the "stand" animation be a bit more subtle?

private function Stop takes nothing returns nothing
    call PauseUnit(GetTriggeringUnit(),true)
    call IssueImmediateOrder(GetTriggerUnit(),"stop")
    call PauseUnit(GetTriggeringUnit(),false)
    call SetUnitAnimation(GetTriggeringUnit(),"stand")
    // call SimError(GetOwningPlayer(GetTriggeringUnit(),"This spell is only auto-castable.")
endfunction

And a SimError creates the little yellow writing at the bottom of your screen, saying that something cannot be done, or that there is.. well.. an error . Makes things look very professional.

But as i said before, this is yours, and all in all it is fine, so yeah whatever .

EDIT:

Also:

 private function DefTRYConditions takes nothing returns boolean
        return GetSpellAbilityId() == ability_TVid
    endfunction

    private function DefTRYActions takes nothing returns nothing
        local unit tryU = GetTriggerUnit()
        call IssueImmediateOrder(tryU, "holdposition")
        call TriggerSleepAction(0.01)
        call SetUnitAnimation(tryU, "walk")
        set tryU = null
    endfunction


    private function OffTRYConditions takes nothing returns boolean
        return GetSpellAbilityId() == ability_OFFTVid
    endfunction

    private function OffTRYActions takes nothing returns nothing
        local unit OFFTRYU = GetTriggerUnit()
        call IssueImmediateOrder(OFFTRYU, "holdposition")
        call TriggerSleepAction(0.01)
        call SetUnitAnimation(OFFTRYU, "walk")
        set OFFTRYU = null
    endfunction

The above can be put into one trigger condition, it would save heaps of space and be more efficient.

private function OffTRYActions takes nothing returns boolean
    local unit OFFTRYU = GetTriggerUnit()

    if GetSpellAbilityId() == ability_TVid or GetSpellAbilityId() == ability_OFFTVid then
        call PauseUnit(OFFTRYU,true)
        call IssueImmediateOrder(OFFTRYU,"stop")
        call PauseUnit(OFFTRYU,false)
        call SetUnitAnimation(OFFTRYU,"stand")
    endif

    set OFFTRYU = null

    return false
endfunction

I think that would work.

 

[WolfieeifloW]

Update

Changelog
v1.7
- Code touchup
- Fixed a minor bug

 

[Azlier]

call AddSpecialEffectTarget(OFFSFX, offU, SFXAttach)
call DestroyEffect(bj_lastCreatedEffect)

You are aware that this leaks, right?

But, the effect you chose does not show if you destroy it immediately after creation. Yours shows because it never gets destroyed .

The best I could reccommend is to keep in in a variable, and destroy it at the end with either a wait or a timer.

 

[Prometheus]

call AddSpecialEffectTarget(OFFSFX, offU, SFXAttach)
call DestroyEffect(bj_lastCreatedEffect)

Does not leak!
Could be more efficient.

call DestroyEffect(AddSpecialEffectTarget(OFFSFX, offU, SFXAttach))

 

[Flare]

Does not leak!

Actually, it does - native functions don't set a value for bj_last..., and AddSpecialEffectTarget is no exception. Must be

set var = AddSpecialEffectTarget (...)
call DestroyEffect (var)

or

call DestroyEffect (AddSpecialEffectTarget (...))

Could be more efficient.

Saving space =/= improvement in efficiency - both functions still have to be called either way

 

[GooS]

Looks good, is quite unique (imo) and I can't find any real big problems with it (though I'm quite newb at JASS). Though it seems kinda lengthy for something that is rather simple, but I've not checked what everything does, all in all great spell!

 

[WolfieeifloW]

I'll fix that SFX later.

@GooS: Don't forget, this spell is actually two skills.
And it isn't that "simple" .

 

[WolfieeifloW]

Update

Changelog
v1.7b
- Fixed SFX leak

 

[WolfieeifloW]

Update
I'm currently reworking this entire spell.
I'm aiming to have it done before Friday (March 6th) .

 

[WolfieeifloW]

A little late;
Better late then never though .

Update

Changelog
v2.0
- Major code revamp
- You now click the spell to change between the Defense/Offense modes
- Added map boundaries so units don't teleport outside the map (Thanks DrEvil)

 

[GetTriggerUnit-]

Offense still bug for me. When it cast the mountain king get at the paladin's position. Always.

 

[WolfieeifloW]

?
It's supposed to pull unit's into the Paladin.

 

[WolfieeifloW]

Bump.

 

[WolfieeifloW]

Bump.

 

[FootysMaXeD]

I'm an old-school Footmen gamer and I used to help with Footmen Unleashed versions.
I'm now making my own map from scratch and I really appreciate your work on this spell.

I have no experience with JASS, but i'd like to implement this spell on one of my heroes.

Do you have any recomendations for programs that I need to better be able to mapmake? I plan on spending a lot of time working on my map and becoming very familiar with world editor (whichever version is best). I'm already about half done with my map, can i still use a different editor?

Thanks!

 

[Kenny]

If you don't already have it (which it sounds like you don't), you should get the NewGen World Editor.

It is needed if you want to implement this spell, and many other higher quality spells from this site and others.