Spellpack The Dark Lady

[mapguy]

OH MY GOOOOOOOOOOOOOOD!

AWESOME!

this hero is a real awesome hero, almost everything perfect.

here is my opinions:

- silence for 2.5 seconds on attack with blades is too much, try reducing to 1.5.
- tainted soul is a poor spell, didn't liked it.
- the idea of running and cutting enemies and also silencing if you have blades buff is great.
- your Ultimate, I think, is one of the 10% best spells I've ever seen, awesome!:thup:

 

[Blackrage]

mapguy, the user can change the abilities in the end so it doesnt matter if its overpowered in the testmap.

 

[Crazy_Dead]

mapguy, the user can change the abilities in the end so it doesnt matter if its overpowered in the testmap.

Yes, he is so negative, so it doesnt exists.

 

[Ayanami]

Version 1.4 released.

Changelog

[B]Version 1.4[/B]
- Added the actual Dark Lady's soundset.

And yes, I do know that the map file is ridiculously huge. If anyone knows a way to compress the sound files, let me know. And more feedback will be appreciated. Thanks.

 

[Angel_Island]

You should make Charging Strikes have instant cast time.

 

[Ayanami]

You should make Charging Strikes have instant cast time.

Well, I would if there is any spell that's instant target point, similar to Berserk. Anyone has any ideas?

 

[Laiev]

windwalk

 

[Ayanami]

windwalk

Wait, wind walk isn't target point. :O

 

[Weep]

Windwalk isn't point targeted.

Blink is instant point-targeted if you set both durations to 0, and won't move the caster if you set the min. range to 0 and max. range to 0.01. It will, however, have the side effect of causing all WC3 missiles flying toward the caster to miss.

 

[Laiev]

._. oh.. you want target point

fail

 

[Ayanami]

Version 1.5 released.

Requirement removed

• GDD

Requirements added

• NewGen
• Event
• AIDS
• Key Timers 2
• Recycle
• Damage

Changelog

[B]Version 1.5[/B]
- Rewrote the spell triggers into vJASS

Note that this is my first time ever creating a spell pack vJASS. Thus, constructive feedback will be appreciated.

 

[13lade619]

Cool. Now you GUI worshipers will hate you. . lol.

anyway, i recommend you use the 'clean wrappers' for Damage.

Damage_Physical(), Damage_Spell() and Damage_Pure()

 

[Laiev]

Looking for this, I found something which you don't need and others which you can add to configure part

your dummy system:

private function InitTrig takes nothing returns nothing
    local trigger t = CreateTrigger() //you don't need this
    set dummy = CreateUnit(Player(0), DUMMY_ID, 0.00, 0.00, 0.00)
endfunction

Dark Blades:

    if PLAYSOUND then
        call StartSound(gg_snd_DarkBlades) // should be in global config? <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue    :p" loading="lazy" data-shortname=":p" />
    endif

Taint Soul

You know you execute all the local variable and so when you cast EVERY spell, right?
Probably make no change since you null everything but just to you know, you can ignore the locals and just check the ability and damage with the unit, since you just use it one time.

EDIT: Oo' in demomap, the ultimate removes 100% of the vision lol

 

[Tyman2007]

One improvement that I can see is this part right here

if PLAYSOUND then
    call StartSound(gg_snd_DarkBlades)
endif

should be [ljass]static if PLAYSOUND then[/ljass]

if it's false, it won't compile saving a little space.
if it's true, it will compile, but the if and the endif will be removed

if it's an if/then/else, it will keep checking if the constant variable (variable that will NEVER change) is true or not. in a static if, it will only check once and that's during the compile.

See what I mean?