Spellpack The Frost Revenant

[Faust]

just a question for Freezing Field

How to edit the number of pulse ?

In the H2 function at the beginning there is a line:

 local integer times = R2I(I2R(GetUnitAbilityLevel(dat.caster, FFID)) + 1) / 2

The integer variable called times is the one you are looking for.

Also note at the end of the same function

if dat.ticks == 24 * times then
     call dat.destroy()
    endif

To tell you the truth I don't know what happens if you edit the 24 part...
I made the spell pretty long ago and I just don't quite remember how it works, even the times integer took me 30 minutes to find heh.
I hope I could help.

 

[Jesus4Lyf]

>call DestroyTimer(.clock)
I like to check what people do for timer systems...
And apparently there's nothing worse than DestroyTimer, right? :thdown:

(Didn't look at the spells at all, just happened to see some code.)

 

[Faust]

>call DestroyTimer(.clock)
And apparently there's nothing worse than DestroyTimer, right? :thdown:

Apparently, yes there is.
And it is; not looking at the spells at all, just seeing some code.

And by the way I don't see anything wrong with it.

 

[Jesus4Lyf]

>And it is; not looking at the spells at all, just seeing some code
Well excuse me for doing the opposite of everyone else in this thread (except Flare?) and reading the code to check its quality.

>I don't see anything wrong with it
It's bad practise. DestroyTimer bugs have been around for a long time. Although I actually believe your code there is perfectly fine (in terms of avoiding handle stack corruption), there's much better alternatives to destroying timers for other reasons such as efficiency.
Did you know there's even ABCT, which is apparently just ABC but specifically for timers?

Some comments on DestroyTimer for educationalisticism (which is not a real word, I hope).
http://www.wc3c.net/showthread.php?t=104926 (Especially post #10)

*Shrugs* Carry on...

 

[Weep]

Missing demo map...?