Discussion Total JassHelper overhaul project

Should JassHelper be updated?

  • Yes

    Votes: 15 60.0%
  • No

    Votes: 6 24.0%
  • Wait for Vexorian

    Votes: 4 16.0%

  • Total voters
    25

Lyerae

I keep popping up on this site from time to time.
I'm starting to think indentation-based code might be a good thing for the JASS community. You won't have to deal with completely unreadable scripts, as the compiler will enforce a strict indentation-style.
 

Narks

Vastly intelligent whale-like being from the stars
a strict indentation style which prevents coders from compacting code

eg.

JASS:
if (b == true) { a = 1; } else { a = 0; }

as opposed to

JASS:
if (b == true)
    a = 1
else
    a = 0


JASS:
message = "Hello world" + CONST_SPACE_THING + "some other stuff" 
    + CONST_OBNOXIOUS_NAME + "very long indeed" + CONST_I_HATE_PHP 
    + "this could go on for a fair bit" + GetPlayerName(GetTriggerPlayer()) 
    + GetColor(GetPlayerId(GetTriggerPlayer()));


opposed to

JASS:
message = "Hello world" + CONST_SPACE_THING + "some other stuff" + CONST_OBNOXIOUS_NAME + "very long indeed" + CONST_I_HATE_PHP + "this could go on for a fair bit" + GetPlayerName(GetTriggerPlayer()) + GetColor(GetPlayerId(GetTriggerPlayer()))



how anyone can find this readable is beyond me:
JASS:
	$inputUsername = trim($_POST['inputLoginUsername'], "|")
	$inputPassword = trim($_POST['inputLoginPassword'], "|")
	$filename = "customers.txt"
	
	if (is_readable($filename))

		if (!$file = fopen($filename, "r")) 
			echo "<p>Cannot open customers.txt!</p>"
			exit
		
		$record = explode("|", fgets($file))

		while (!feof($file))
			$username = $record[1];
			$password = $record[2];

			if ($inputUsername == $username && $inputPassword == $password)
				$_SESSION['currentLogin'] = $username
				fclose($file)
				header("location:home.php")

			$record = explode("|", fgets($file))
		
		fclose($file)
		header("location:login_failed.php")
		exit
	else
		echo "<p>Could not read customers.txt - does it exist, and is it
		readable?</p>"
		exit
	echo "hello world"
 

Bribe

vJass errors are legion
What language is that? Looks like a mix of PHP and Python with a touch of "huh?"

Anyway, perhaps I should reveal what the syntax looks like when properly highlighted:

 

tooltiperror

Super Moderator
Staff member
That is some seriously ugly syntax highlighting.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    that sucks
  • jonas jonas:
    @midnight8 how is it looking
  • midnight8 midnight8:
    meh, me, wife and her friend thaty traveled with us all have covid, seems to be winding down some for me at least. Felt like complete shit, been sleeping a lot, just bieng lazy as hell. I feel like that today has probably been like 11 or 12 days since exposure. Have not had any fever today, and have not taken any meds, so hopefully by monday or tuesday I will be good to go, sadly have passed it on to our teen son, I guess that was pretty much unavoidable
  • The Helper The Helper:
    hope you get to feeling better and get vaccinated my friend
  • midnight8 midnight8:
    I will at some point, but so many vaccinated people still getting it. One of the bands we watch in vegas, all 4 had been vaccinated and are now positive.
  • Ghan Ghan:
    Symptoms?
  • Ghan Ghan:
    I think the symptoms are typically less severe if previously vaccinated.
  • midnight8 midnight8:
    I have had all of the symptoms, taste is slightly starting to come back, but smell, no. Honestly, just been a little miserable, have never felt in any danger from it. Being trapped at home sucks. lol
  • midnight8 midnight8:
    meh, got a little fever again this morning, guess gonna be a few more days
  • The Helper The Helper:
    I went to Comicon this last weekend I hope I dont get it I feel fine and I am not vaccinated and did not wear a mask
  • The Helper The Helper:
    Comicon really was not packed though like it was in the past. I am not really worried though it was the most people I have been around in a year.
  • tom_mai78101 tom_mai78101:
    Still, getting vaccinated is a good idea. We're getting Delta variant spikes here in Boston.
  • The Helper The Helper:
    I am not against vaccination at all I just have a serious procrastination problem I plan on getting vaccinated soon
  • midnight8 midnight8:
    was kinda same with me, I was gonna do it, and life got in the way.
  • midnight8 midnight8:
    we wore mask in some places, but at 118 degrees outside, little rough. :)
  • The Helper The Helper:
    yeah i had another friend in Vegas talking about that heat damn
  • The Helper The Helper:
    Well I do not think I got Covid from the Comicon
    +1
  • tom_mai78101 tom_mai78101:
    Pushed out a new Pokemon Walking algorithm build. With a new system in place, I'll probably start tackling triggers and NPCs,
    +1
  • Varine Varine:
    Is it fucking hot everywhere?
  • Varine Varine:
    What's a pokemon walking algorithm?
  • jonas jonas:
    it's an engine for pokemon games that closely emulates the walking behavior of pokemon red/blue/yellow
  • jonas jonas:
    basically if you wanted to implement pokemon yellow from scratch, and you'd want it to feel as close as possible to the real thing, you'd start with that
  • Varine Varine:
    Like from the Gameboy games? I'm not at all familiar with Pokemon.
  • jonas jonas:
    yeah
  • The Helper The Helper:
    I only played the Pokemon games on the Gamecube and Wii and such not on the portables my kids had all those games but I never really played on the portables. Now that I think about maybe once sooooo long ago.

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome
    Top