Trigger Giving Error

[Leazy]

Hello, I made a trigger that is suppose to cast a spell at units on a special terrain type (in this case Lava Bricks). However, the trigger gives me error.
This is the trigger:

Take Damage On Lava
    Events
        Time - Every 0.10 seconds of game time
    Conditions
    Actions
        Set UnitGroup[1] = (Units in (Playable map area))
        Unit Group - Pick every unit in UnitGroup[1] and do (Actions)
            Loop - Actions
                Set Point[1] = (Position of (Picked unit))
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        And - All (Conditions) are true
                            Conditions
                                (Terrain type at Point[1]) Equal to Dungeon - Lava Cracks
                                ((Picked unit) has buff Lava ) Equal to False
                    Then - Actions
                        Unit - Create 1 Dummy Unit for (Player((Custom value of (Picked unit)))) at Point[1] facing Default building facing degrees
                        Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
                        Unit - Add Damage on Lava  to (Last created unit)
                        Unit - Order (Last created unit) to Undead Necromancer - Unholy Frenzy (Picked unit)
                    Else - Actions
        Custom script:   call RemoveLocation (udg_Point[1])
        Custom script:   call DestroyGroup(udg_UnitGroup[1])

 

[[email protected]_no_Wyrm]

Take Damage On Lava
    Events
        Time - Every 0.10 seconds of game time
    Conditions
    Actions
        Set UnitGroup[1] = (Units in (Playable map area))
        Unit Group - Pick every unit in UnitGroup[1] and do (Actions)
            Loop - Actions
                Set Point[1] = (Position of (Picked unit))
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        And - All (Conditions) are true
                            Conditions
                                (Terrain type at Point[1]) Equal to Dungeon - Lava Cracks
                                ((Picked unit) has buff Lava ) Equal to False
                    Then - Actions
                        Unit - Create 1 Dummy Unit for (Player((Custom value of (Picked unit)))) at Point[1] facing Default building facing degrees
                        Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
                        Unit - Add Damage on Lava  to (Last created unit)
                        Unit - Order (Last created unit) to Undead Necromancer - Unholy Frenzy (Picked unit)
                    Else - Actions
        [del]Custom script:   call RemoveLocation (udg_Point[1])[/del]<-- Put it so it loops as the picked unit loops
        Custom script:   call DestroyGroup(udg_UnitGroup[1])

Does all units in the map have custom value?

 

[LightChaosma]

units with no custom value have custom value 0

 

[Flare]

units with no custom value have custom value 0

I believe using an invalid Player number (e.g. <1, or >16 in GUI, <0 or >15 in JASS) can cause problems (I get the feeling it can crash the game, not sure)

 

[LightChaosma]

that could very well be.

why not give that created unit to neutral extra?

 

[Leazy]

I added two conditions to clear it up, thanks for all the help. The trigger is now working and looking like this:

Take Damage On Lava
    Events
        Time - Every 0.10 seconds of game time
    Conditions
    Actions
        Set UnitGroup[1] = (Units in (Playable map area) matching (((Matching unit) is alive) Equal to True))
        Unit Group - Pick every unit in UnitGroup[1] and do (Actions)
            Loop - Actions
                Set Point[1] = (Position of (Picked unit))
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        And - All (Conditions) are true
                            Conditions
                                (Terrain type at Point[1]) Equal to Dungeon - Lava Cracks
                                ((Picked unit) has buff Lava ) Equal to False
                    Then - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Custom value of (Picked unit)) Greater than or equal to 1
                                (Custom value of (Picked unit)) Less than or equal to 12
                            Then - Actions
                                Unit - Create 1 Dummy Unit for (Player((Custom value of (Picked unit)))) at Point[1] facing Default building facing degrees
                            Else - Actions
                                Unit - Create 1 Dummy Unit for Neutral Hostile at Point[1] facing Default building facing degrees
                        Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
                        Unit - Add Damage on Lava  to (Last created unit)
                        Unit - Order (Last created unit) to Undead Necromancer - Unholy Frenzy (Picked unit)
                    Else - Actions
                Custom script:   call RemoveLocation (udg_Point[1])
        Custom script:   call DestroyGroup(udg_UnitGroup[1])