Triggers causing random other things to happen?

[Guard]

I'm currently making a set of D&D/RP triggers. On my test map, i have random units and 3 heros laying around.
When i was playing around, i tried my size trigger out:

Size
Events
Player - Player 1 (Red) types a chat message containing size as A substring
Conditions
(Substring((Entered chat string), 1, 4)) Equal to size
Actions
Set temp = (Integer((Substring((Entered chat string), 6, 9))))
Unit Group - Pick every unit in (Units currently selected by Player 1 (Red)) and do (Actions)
Loop - Actions
Animation - Change (Picked unit)'s size to ((Real(temp))%, (Real(temp))%, (Real(temp))%) of its original size


I did size 20 only a priest, and somehow one of the heros also got resized to 20 (was definately not selected) and began to auto-follow the priest. Any idea what would cause actions like this?

I also had something like this happen with the tint command, where instead of the selected unit becoming tinted, another unit i had selected before became tinted instead.

 

[Heptameron]

You might try this; it could be slightly safer. But, yeah, selections seem to be flakey sometimes.

Set Size
    Events
        Player - Player 1 (Red) types a chat message containing size as A substring
    Conditions
    Actions
        Set TempUnitGroup = (Units currently selected by Player 1 (Red))
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 1, 4)) Equal to size
                (Number of units in TempUnitGroup) Greater than 0
            Then - Actions
                Set TempReal = (Real((Substring((Entered chat string), 6, (Length of (Entered chat string))))))
                Custom script:   set bj_wantDestroyGroup = true
                Unit Group - Pick every unit in TempUnitGroup and do (Actions)
                    Loop - Actions
                        Animation - Change (Picked unit)'s size to (TempReal%, TempReal%, TempReal%) of its original size
            Else - Actions

 

[Guard]

Thanks. I'll work that through my code and hope it fixes the problems.

 

[AceHart]

In the unlikely event that it wouldn't, try replacing
"Units currently selected by Player 1 (Red)"
with
"Units owned by Player 1 (Red) matching (((Matching unit) is selected by Player 1 (Red)) Equal to True)".

 

[Heptameron]

In the unlikely event that it wouldn't, try replacing
"Units currently selected by Player 1 (Red)"
with
"Units owned by Player 1 (Red) matching (((Matching unit) is selected by Player 1 (Red)) Equal to True)".

Or dynamically build a group of the selected units by responding to events.

 

[Guard]

so what does set bj_wantDestroyGroup = true do? Trigger seems to work fine, but I only noticed the selection mess ups last time when i had a 2nd player in the game before showing them what everything did.

 

[Heptameron]

so what does set bj_wantDestroyGroup = true do?

Prevents a memory leak. You can remove it and it'll still work.