Triggers causing split server?

Kazuga

Let the game begin...
Reaction score
110
Hello, me and my friend are creating a map together, but when we tested it out now just recently we noticed that he got disconnected when some of the triggers ran. We tested several times and it was always the same trigger that caused it. (+ one more at the ending of our tests.)

This is the trigger that causes most of our problems:

JASS:
scope OrcShieldSlam initializer Lightning
//! runtextmacro HAIL_CreateProperty ("Data", "integer", "private")
globals
private constant integer raw           = 'A011'  
private constant integer offset        = 20
private constant integer RD            = 200    flyger iväg
private constant real Arc               = 1.3  
private constant integer damage        = 200   
private constant real aoe           = 400  


endglobals


private struct TestStruct
    timer Timer
    unit caster
    real angle
    group z
    integer counter
    effect special1
    unit dummy
    location EP
    real distance
    effect fire1
    integer traveled
endstruct



private function Conditions takes nothing returns boolean
return GetSpellAbilityId() == raw
endfunction

private function Parabola takes real dist, real maxdist returns real
    local real t = (dist*2)/maxdist-1
    return (-t*t+1)*(maxdist/Arc)
endfunction

function Trig_OrcShieldSlam_FilterCondition takes nothing returns boolean
    return UnitHasBuffBJ(GetFilterUnit(),'B005') == true
endfunction

private function Knockback takes nothing returns nothing
    local TestStruct data = GetData (GetExpiredTimer ())
    local unit Unit = data.caster
    local group g = CreateGroup()
    local unit affected
    local real tx
    local real ty 
    local real cx = GetUnitX(Unit)
    local real cy = GetUnitY(Unit)
    local real nx 
    local real ny 
    local real angle
    
    //call BJDebugMsg(I2S(CountUnitsInGroup(data.z)))
    call GroupEnumUnitsInRange(g,cx,cy,aoe*2,Condition(function Trig_OrcShieldSlam_FilterCondition))
    
    set data.traveled = data.traveled + offset
    if data.traveled >= RD + I2R(GetHeroStr(udg_PlayerHero[GetConvertedPlayerId(GetOwningPlayer(Unit))],true)) then
        call PauseTimer (data.Timer)
        call ResetData (data.Timer)
        call DestroyTimer (data.Timer)
        call DestroyGroup(data.z)
    else
        //call BJDebugMsg(I2S(CountUnitsInGroup(g)))
        //call BJDebugMsg("endif")
        loop
            set affected = FirstOfGroup(g)
            exitwhen affected == null
                //call BJDebugMsg("boom")
                set tx = GetUnitX(affected)
                set ty = GetUnitY(affected)
                
                set angle = Atan2(ty-cy,tx-cx)
                
                set nx = tx + offset * Cos(angle)
                set ny = ty + offset * Sin(angle)
                
                call SetUnitX(affected,nx)
                call SetUnitY(affected,ny)
            
            call GroupRemoveUnit(g,affected)
        endloop
       // call ForGroup(z,function slide(p))
    endif
endfunction





private function Actions takes nothing returns nothing
    local sound SimError
    local TestStruct data = TestStruct.create ()
    local unit Unit = GetTriggerUnit()
    local location CP = GetUnitLoc(Unit)
    local real cx = GetUnitX(Unit)
    local real cy = GetUnitY(Unit)
    
    set data.caster = Unit
    set triggering = Unit
    set data.z = CreateGroup()
    call GroupEnumUnitsInRange(data.z,cx,cy,aoe,Condition(function Trig_OrcShieldSlam_FilterCondition))
 
    set data.Timer = CreateTimer()
    call TimerStart (data.Timer,0.03,true, function Knockback)
    call SetData (data.Timer, data)


endfunction

//===========================================================================
private function SafeFilt takes nothing returns boolean
return true
endfunction
private function Lightning takes nothing returns nothing
 local trigger trig = CreateTrigger()
     call TriggerRegisterPlayerUnitEvent(trig,GetLocalPlayer(),EVENT_PLAYER_UNIT_SPELL_EFFECT,Condition(function SafeFilt))

 call TriggerAddCondition (trig, Condition (function Conditions ) )
 call TriggerAddAction (trig, function Actions )
 endfunction
endscope

The trigger does everything it's supposed to do, except that it disconnects other players. Is there anything in the code that might cause this?
 

Artificial

Without Intelligence
Reaction score
326
> [ljass]call TriggerRegisterPlayerUnitEvent(trig,/*!->*/GetLocalPlayer()/*<-!*/,EVENT_PLAYER_UNIT_SPELL_EFFECT,Condition(function SafeFilt))[/ljass]
Well if you only register the event for the local player, it kinda like only gets registered for the local player, meaning when Player(0)'s unit triggers the event, the trigger only runs for Player(0), not for any other players.

Just use [ljass]TriggerRegisterAnyUnitEventBJ[/ljass]. ;p
 

Kazuga

Let the game begin...
Reaction score
110
Ah thanks guys, this solved a real lot of my problems!<3

The triggers works even after I replaced the getlocalplayer part with the part you posted, gonna test the map with my friend later on again to make sure he doesn't disconnect. :)
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    The bots will show up as users online in the forum software but they do not show up in my stats tracking. I am sure there are bots in the stats but the way alot of the bots treat the site do not show up on the stats
  • Varine Varine:
    I want to build a filtration system for my 3d printer, and that shit is so much more complicated than I thought it would be
  • Varine Varine:
    Apparently ABS emits styrene particulates which can be like .2 micrometers, which idk if the VOC detectors I have can even catch that
  • Varine Varine:
    Anyway I need to get some of those sensors and two air pressure sensors installed before an after the filters, which I need to figure out how to calculate the necessary pressure for and I have yet to find anything that tells me how to actually do that, just the cfm ratings
  • Varine Varine:
    And then I have to set up an arduino board to read those sensors, which I also don't know very much about but I have a whole bunch of crash course things for that
  • Varine Varine:
    These sensors are also a lot more than I thought they would be. Like 5 to 10 each, idk why but I assumed they would be like 2 dollars
  • Varine Varine:
    Another issue I'm learning is that a lot of the air quality sensors don't work at very high ambient temperatures. I'm planning on heating this enclosure to like 60C or so, and that's the upper limit of their functionality
  • Varine Varine:
    Although I don't know if I need to actually actively heat it or just let the plate and hotend bring the ambient temp to whatever it will, but even then I need to figure out an exfiltration for hot air. I think I kind of know what to do but it's still fucking confusing
  • The Helper The Helper:
    Maybe you could find some of that information from AC tech - like how they detect freon and such
  • Varine Varine:
    That's mostly what I've been looking at
  • Varine Varine:
    I don't think I'm dealing with quite the same pressures though, at the very least its a significantly smaller system. For the time being I'm just going to put together a quick scrubby box though and hope it works good enough to not make my house toxic
  • Varine Varine:
    I mean I don't use this enough to pose any significant danger I don't think, but I would still rather not be throwing styrene all over the air
  • The Helper The Helper:
    New dessert added to recipes Southern Pecan Praline Cake https://www.thehelper.net/threads/recipe-southern-pecan-praline-cake.193555/
  • The Helper The Helper:
    Another bot invasion 493 members online most of them bots that do not show up on stats
  • Varine Varine:
    I'm looking at a solid 378 guests, but 3 members. Of which two are me and VSNES. The third is unlisted, which makes me think its a ghost.
    +1
  • The Helper The Helper:
    Some members choose invisibility mode
    +1
  • The Helper The Helper:
    I bitch about Xenforo sometimes but it really is full featured you just have to really know what you are doing to get the most out of it.
  • The Helper The Helper:
    It is just not easy to fix styles and customize but it definitely can be done
  • The Helper The Helper:
    I do know this - xenforo dropped the ball by not keeping the vbulletin reputation comments as a feature. The loss of the Reputation comments data when we switched to Xenforo really was the death knell for the site when it came to all the users that left. I know I missed it so much and I got way less interested in the site when that feature was gone and I run the site.
  • Blackveiled Blackveiled:
    People love rep, lol
    +1
  • The Helper The Helper:
    The recipe today is Sloppy Joe Casserole - one of my faves LOL https://www.thehelper.net/threads/sloppy-joe-casserole-with-manwich.193585/
  • The Helper The Helper:
    Decided to put up a healthier type recipe to mix it up - Honey Garlic Shrimp Stir-Fry https://www.thehelper.net/threads/recipe-honey-garlic-shrimp-stir-fry.193595/
  • The Helper The Helper:
    Here is another comfort food favorite - Million Dollar Casserole - https://www.thehelper.net/threads/recipe-million-dollar-casserole.193614/

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top