Spellpack Undying

[The_Kingpin]

Yeah, nvm.

 

[~GaLs~]

>>Yeah, nvm.
It is not that I copy anyone else's idea. I am just following what DotA(Ice Frog) does.

 

[NetherHawk]

nvm ahaha =/

i wanted to learn how to use structs from your map... but it seems u use ABC, which i dunno also... argh =/

 

[~GaLs~]

**Bump**

>>i wanted to learn how to use structs from your map... but it seems u use ABC, which i dunno also... argh =/
They are just like handle vars.
In my situnation, my struct act like a large wrapper which wrap up every variable.

It is my routine to bump this now..

 

[Cohadar]

I think this should not be approved until you make raise dead as well

 

[~GaLs~]

>>I think this should not be approved until you make raise dead as well
I didn't said I wanted to submit a DotA hero.
I just wanted to submit spell pack, why does it have matter to the Raise Dead?

 

[Cohadar]

Because it is natural for it to be there, and because you need to learn to finish what you started (education and stuff...)

EDIT:

private function tAct takes nothing returns nothing
local timer t = GetExpiredTimer()
local Soul_Rip SR = GetTimerStructA(t)

    call ClearTimerStructA(t)
    call SR.destroy()
    
call DestroyTimer(t)
set t = null
endfunction

private function tAct takes nothing returns nothing
local timer t = GetExpiredTimer()
local Soul_Rip SR = ClearTimerStructA(t) // <---- small trick

    call SR.destroy()
    
call DestroyTimer(t)
set t = null
endfunction

    method onDestroy takes nothing returns nothing
    set .caster = null
    set .target = null
    call DestroyTrigger(.Infect)
    call DestroyTrigger(.Amplify)
    call DestroyGroup(.reg)
    set .Infect = null
    set .Amplify = null
    set .reg = null
    endmethod

    method onDestroy takes nothing returns nothing
    //set .caster = null   // Don't null struct members they are not locals.
    //set .target = null
    call DestroyTrigger(.Infect)
    call DestroyTrigger(.Amplify)
    call DestroyGroup(.reg)
    //set .Infect = null
    //set .Amplify = null
    //set .reg = null
    endmethod

Disabled versions of some of your icons are not showing properly.
Do you know why is this?

EDIT:
You are also using constant functions for ability codes instead of constant globals.
functions in spells are just for stuff that have level as parameter, for example:

function AOE takes integer level returns real
    return 100. + level*200.
endfunction

 

[duyen]

You don't need to trigger Raise Dead, base it off Summon Lava Spawn and change units and art.

 

[~GaLs~]

>>@Cohadar
I already finished what you said currently, but I won't update now. I am making Raise Dead.

>>You don't need to trigger Raise Dead, base it off Summon Lava Spawn and change units and art.
Hmm, right. I am currently base off that spell. But, how do you do about the Heal 50 hitpoints thing?
I don't see there is an option for it, or am I blinded?

 

[Cohadar]

I stopped playing dota before that hero was added,
but if you describe what that rise dead does,
I am sure I could give a couple hints...

 

[~GaLs~]

Undying's Personal Information

 

[Somatic]

Just detect when the unit type of summoned unit died, create a unit to use fan of knive, with negative damage (for the healing) and cast it targeting own player unit.

 

[Cohadar]

Ok here is the PUI part:

struct ZombieData
    unit hero // owner of zombie
    unit zombie
    integer counter // for attack six times thing
    private static ZombieData array PUI
    
    static method create takes unit hero, unit zombie returns ZombieData
        local ZombieData ret = ZombieData.allocate()
        set ret.hero = hero
        set ret.zombie = zombie
        set ret.counter = 0
        set ZombieData.PUI[GetUnitIndex(zombie)] = ret // zombie -> ZombieData link
        return ret
    endmethod
    
    static method Get takes unit zombie returns ZombieData
        return ZombieData.PUI[GetUnitIndex(zombie)]
    endmethod
    
    method onDestroy takes nothing returns nothing
        set ZombieData.PUI[GetUnitIndex(.zombie)] = 0 // break the link
    endmethod
endstruct

You register on attack trigger and if attacking unit is zombie you increase it's counter. if counter gets to 6 you raise a new zombie.

How do you keep track of number of zombies?
Well I will leave that as a homework

EDIT: fixed some typos in code.

 

[~GaLs~]

>>You register on attack trigger and if attacking unit is zombie you increase it's counter. if counter gets to 6 you raise a new zombie.
Sorry bro.
In DotA, it is registered in EVENT_UNIT_DAMAGED. The "S" bug won't work with this spell. So... I think that in DotA, this spell was base on Lava Spawn. (IceFrog loves to use original spell of Blizzard, right? )

The problem was the healing 50 hp thingy...

 

[Cohadar]

Irrelevant, you steel need ZombieData.

function ZombyDiesActions takes nothing returns nothing
    local ZombieData data = ZombieData.Get(GetTriggerUnit())
    call SetUnitState(data.hero, UNIT_STATE_LIFE, GetUnitState(data.hero, UNIT_STATE_LIFE) + 50.0)
    call data.destroy()
endfunction

Simple as that.

 

[~GaLs~]

>>Irrelevant, you steel need ZombieData.
-.-lll
There is a missle effect that moving towards the Hero when a zombie die.
The +50 hp effect will only happen when the missle reach the Hero.


And, in the other hand... I need 3 trigger for 1 spell again..?
1. Your PUI. (PUI is an insult in chinese you know?)
2. Your ZombieData (You said everything need 1 trigger right?)
3. Main Trigger.

>>Simple as that.
You think so?

 

[Cohadar]

ZombieData is a struct not a trigger ffs, just put it in spells trigger.
Heal effect is a dummy caster death-coil or something like that.
So when zombie dies use dummy caster to cast 50 heal on hero.

I said every scope should have it's own trigger.


EDIT:
I just looked at lava spawn spell.
You were right, that is how IceFrog did it, the only problem is that if you use lava spawn ability spell will not be MUI (it will be only multi-player instancable)

So you basically need to do this:

Forget about ZombieData

Base Raise dead on summon lava spawns

globals
    unit array Dirges  // connects player <-> dirge
endglobals

When Dirge casts a summon spell you do:

function RaiseDeadActions takes nothing returns nothing
    set Dirges[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))] = GetTriggerUnit()
endfunction

And when spawn dies:

function ZombieDiesActions takes nothing returns nothing
    local unit zombie = GetTriggerUnit
    local unit hero = Dirges[GetPlayerId(GetOwningPlayer(zombie))]
    local real x = GetUnitX(zombie)
    local real y = GetUnitY(zombie)

    // Cast some heal magic on hero from the position of dying unit
endfunction

 

[emjlr3]

not bad, a few things however

Soul Rip:

• should use a timer stack, CSSafety is common for people
  
• could use a global group, and remove the need of creating and destroying/nulling each time
  
• no need to make comparisons, just add a not in front of it
  
• the group can grab the target itself....
  
• do not need to null lightning varaible on destroying the struct
  
• damage/unit should be level dependant
  
• rest is good

Hearstopper

• could use a global group, and remove the need of creating and destroying/nulling each time
  
• rest is good

Plague:

• infect range and duration should be level dependant
  
• timer stack needed
  
• could again use global groups
  
• dont need to null structs variables
  
• rest looks good

anyhow, needs some updates IMO

good job though

 

[duyen]

Ah, forgot about the healing while dead, but just create a dummy, give it an expiration timer and order it to cast death coil on Undying.

 

[~GaLs~]

Spoiler

I have gone to some sort of camp, sorry for late reply.. I just came back today.

>>@Cohadar
Hmm, I see.

>>should use a timer stack, CSSafety is common for people
I used it before, but ABC gives alot debug messages to me.
After I change from NewTimer to CreateTimer, this fixed the debug warning.

>>could use a global group, and remove the need of creating and destroying/nulling each time
I see.

>>no need to make comparisons, just add a not in front of it
Hmm? not?
Using not in where..?

>>the group can grab the target itself....
Argh, I have forgoten in DotA, it has no including the caster itself.

>>do not need to null lightning varaible on destroying the struct
I see.

>>damage/unit should be level dependant
I'll see what I can do about it.

Spoiler

Actually, what is dependant means? I see boolean option in ObjectEditor says something like Independance or something alike.

>> * infect range and duration should be level dependant
* timer stack needed
* could again use global groups
* dont need to null structs variables
* rest looks good

oK!

>>Ah, forgot about the healing while dead, but just create a dummy, give it an expiration timer and order it to cast death coil on Undying.
The problem is... You don't know who is the caster of the zombie when the zombie dies.