vJass Help Syntax Error

Fire-Wolf

Fire-Wolf

S.P.D Smoke Pot Daily, Legalize It!
Reaction score
54
Ok I need some help with this. I'm making my first vJass spell. Its a basic one, it is just a chain lightning spell. And I'm only getting one syntax error. Here is the code:
JASS:
scope LW

    local Caster = GetSpellAbilityUnit()
    local array Target[0] = GetSpellTargetUnit()
    local array Target[1] = GetSpellTargetUnit()
    local group Targets

private function Trig_LW_Func008Func001002003001 takes nothing returns boolean
    return ( GetFilterUnit() != Caster )
endfunction

private function Trig_LW_Func008Func001002003002001 takes nothing returns boolean
    return ( GetFilterUnit() != Target[0] )
endfunction

private function Trig_LW_Func008Func001002003002002 takes nothing returns boolean
    return ( IsUnitAliveBJ(GetFilterUnit()) == true )
endfunction

private function Trig_LW_Func008Func001002003002 takes nothing returns boolean
    return GetBooleanAnd( Trig_LW_Func008Func001002003002001(), Trig_LW_Func008Func001002003002002() )
endfunction

private function Trig_LW_Func008Func001002003 takes nothing returns boolean
    return GetBooleanAnd( Trig_LW_Func008Func001002003001(), Trig_LW_Func008Func001002003002() )
endfunction

private function Trig_LW_Actions takes nothing returns nothing
    call AddLightningLoc( "CLPB", GetUnitLoc(Caster), GetUnitLoc(Target[0]) )
    call UnitDamageTargetBJ( Caster, Target[0], 100.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    call TriggerSleepAction( 0.10 )
    call DestroyLightningBJ( GetLastCreatedLightningBJ() )
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 3
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        set local group Targets = GetUnitsInRangeOfLocMatching(500.00, GetUnitLoc(Target[0]), Condition(function Trig_LW_Func008Func001002003))
        set local array Target[0] = GroupPickRandomUnit(Targets)
        call AddLightningLoc( "CLPB", GetUnitLoc(udg_Target[1]), GetUnitLoc(udg_Target[0]) )
        call UnitDamageTargetBJ( udg_Caster, udg_Target[0], 100.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
        call TriggerSleepAction( 0.10 )
        call DestroyLightningBJ( GetLastCreatedLightningBJ() )
        set udg_Target[1] = udg_Target[0]
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    call DestroyGroup( udg_Targets )
endfunction

//===========================================================================
function InitTrig_LW takes nothing returns nothing
    set gg_trg_LW = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_LW, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddAction( gg_trg_LW, function Trig_LW_Actions )
endfunction

endscope
The syntax error is:
set local group Targets = GetUnitsInRangeOfLocMatching(500.00, GetUnitLoc(Target[0]), Condition(function Trig_LW_Func008Func001002003))

Please help!
 
W

_whelp

New Member
Reaction score
54
Man, you can't make locals out of functions. Use globals:
JASS:
globals
    <VISIBILITY> <TYPE> <NAME> <INITIAL VALUE>
endglobals


Oh, and you can't use 'set local group bla =' syntax, you use 'set bla ='.

EDIT: Aww, you beat me to it.
 
W

_whelp

New Member
Reaction score
54
Uhh... stop using GUI coding habits, bj_forLoopAIndex and bj_forLoopAIndexEnd?
Use locals, not blizzard's useless globals for Jass... and remove the GUI generated globals.

One last thing, don't use those useless BJ's like UnitDamageTargetBJ. All it does is removes weapontype and boolean arguments.
For the DestroyLightningBJ, use DestroyLightning(bj_lastCreatedLightning).
 
Romek

Romek

Super Moderator
Reaction score
963
This is quite obviously converted GUI.
You'll find writing it from scratch much easier to be honest.

Converted GUI is uglier than Paris Hilton.
 
Fire-Wolf

Fire-Wolf

S.P.D Smoke Pot Daily, Legalize It!
Reaction score
54
Sorry I'm still just learning vJass so i just made a spell in Gui converted it to Jass then tried to convert it to vJass. But I fail.

EDIT: Here is the new trigger. Im getting 10 Compile errors now though. I think I made the script a bit better.
JASS:
scope LW initializer InitTrig_LW

private function Trig_LW_Func008Func001002003001 takes nothing returns boolean
    return ( GetFilterUnit() != Caster )
endfunction

private function Trig_LW_Func008Func001002003002001 takes nothing returns boolean
    return ( GetFilterUnit() != Target[0] )
endfunction
private function Trig_LW_Func008Func001002003002002 takes nothing returns boolean
    return ( IsUnitAliveBJ(GetFilterUnit()) == true )
endfunction

private function Trig_LW_Func008Func001002003002 takes nothing returns boolean
    return GetBooleanAnd( Trig_LW_Func008Func001002003002001(), Trig_LW_Func008Func001002003002002() )
endfunction

private function Trig_LW_Func008Func001002003 takes nothing returns boolean
    return GetBooleanAnd( Trig_LW_Func008Func001002003001(), Trig_LW_Func008Func001002003002() )
endfunction

private function Trig_LW_Actions takes nothing returns nothing
    local integer l = 1
    local unit Caster = GetSpellAbilityUnit()
    local unit array Target
    local group Targets
    set Target[0]  = GetSpellTargetUnit()
    set Target[1] = GetSpellTargetUnit()
    call AddLightningLoc( "CLPB", GetUnitLoc(Caster), GetUnitLoc(Target[0]) )
    call UnitDamageTargetBJ( Caster, Target[0], 100.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    call TriggerSleepAction( 0.10 )
    call DestroyLightning( bj_lastCreatedLightning)
    loop
        exitwhen l > 3
        set Targets = GetUnitsInRangeOfLocMatching(500.00, GetUnitLoc(Target[0]), Condition(function Trig_LW_Func008Func001002003))
        set Target[0] = GroupPickRandomUnit(Targets)
        call AddLightningLoc( "CLPB", GetUnitLoc(udg_Target[1]), GetUnitLoc(udg_Target[0]) )
        call UnitDamageTargetBJ( udg_Caster, udg_Target[0], 100.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
        call TriggerSleepAction( 0.10 )
        call DestroyLightning(bj_lastCreatedLightning)
        set udg_Target[1] = udg_Target[0]
        set l = l + 1
    endloop
    call DestroyGroup( Targets )
endfunction

//===========================================================================
private function InitTrig_LW takes nothing returns nothing
    set gg_trg_LW = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_LW, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddAction( gg_trg_LW, function Trig_LW_Actions )
endfunction

endscope
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Varine Varine:
    How can you tell the difference between real traffic and indexing or AI generation bots?
  • The Helper The Helper:
    The bots will show up as users online in the forum software but they do not show up in my stats tracking. I am sure there are bots in the stats but the way alot of the bots treat the site do not show up on the stats
  • The Helper The Helper:
    New recipe is Shipwreck Dinner - https://www.thehelper.net/threads/recipe-shipwreck-dinner.193511/
  • Varine Varine:
    I want to build a filtration system for my 3d printer, and that shit is so much more complicated than I thought it would be
  • Varine Varine:
    Apparently ABS emits styrene particulates which can be like .2 micrometers, which idk if the VOC detectors I have can even catch that
  • Varine Varine:
    Anyway I need to get some of those sensors and two air pressure sensors installed before an after the filters, which I need to figure out how to calculate the necessary pressure for and I have yet to find anything that tells me how to actually do that, just the cfm ratings
  • Varine Varine:
    And then I have to set up an arduino board to read those sensors, which I also don't know very much about but I have a whole bunch of crash course things for that
  • Varine Varine:
    These sensors are also a lot more than I thought they would be. Like 5 to 10 each, idk why but I assumed they would be like 2 dollars
  • Varine Varine:
    Another issue I'm learning is that a lot of the air quality sensors don't work at very high ambient temperatures. I'm planning on heating this enclosure to like 60C or so, and that's the upper limit of their functionality
  • Varine Varine:
    Although I don't know if I need to actually actively heat it or just let the plate and hotend bring the ambient temp to whatever it will, but even then I need to figure out an exfiltration for hot air. I think I kind of know what to do but it's still fucking confusing
  • The Helper The Helper:
    Maybe you could find some of that information from AC tech - like how they detect freon and such
  • Varine Varine:
    That's mostly what I've been looking at
  • Varine Varine:
    I don't think I'm dealing with quite the same pressures though, at the very least its a significantly smaller system. For the time being I'm just going to put together a quick scrubby box though and hope it works good enough to not make my house toxic
  • Varine Varine:
    I mean I don't use this enough to pose any significant danger I don't think, but I would still rather not be throwing styrene all over the air
  • The Helper The Helper:
    New dessert added to recipes Southern Pecan Praline Cake https://www.thehelper.net/threads/recipe-southern-pecan-praline-cake.193555/
  • The Helper The Helper:
    Another bot invasion 493 members online most of them bots that do not show up on stats
  • Varine Varine:
    I'm looking at a solid 378 guests, but 3 members. Of which two are me and VSNES. The third is unlisted, which makes me think its a ghost.
     +1
  • The Helper The Helper:
    Some members choose invisibility mode
     +1
  • The Helper The Helper:
    Latest Recipe is Garlic Parmesan Chicken https://www.thehelper.net/threads/recipe-garlic-parmesan-chicken.193575/
  • The Helper The Helper:
    I bitch about Xenforo sometimes but it really is full featured you just have to really know what you are doing to get the most out of it.
  • The Helper The Helper:
    It is just not easy to fix styles and customize but it definitely can be done
  • The Helper The Helper:
    I do know this - xenforo dropped the ball by not keeping the vbulletin reputation comments as a feature. The loss of the Reputation comments data when we switched to Xenforo really was the death knell for the site when it came to all the users that left. I know I missed it so much and I got way less interested in the site when that feature was gone and I run the site.
  • Blackveiled Blackveiled:
    People love rep, lol
     +1
  • The Helper The Helper:
    The recipe today is Sloppy Joe Casserole - one of my faves LOL https://www.thehelper.net/threads/sloppy-joe-casserole-with-manwich.193585/
  • The Helper The Helper:
    Decided to put up a healthier type recipe to mix it up - Honey Garlic Shrimp Stir-Fry https://www.thehelper.net/threads/recipe-honey-garlic-shrimp-stir-fry.193595/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      367 (members: 1, guests: 366)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top