Spell [vJASS]Rupture [v1.2f] by baassee

emjlr3

Change can be a good thing
Reaction score
395
could use same trigger for cast and effect recognition, and differentiate from there

in Conditions, no need to set values to locals, just use them in the create function call

why force the spell hotkey when stopping the cast?

i also thinks its silly to require xe and xedamage when all you are using it for is to deal damage

you should really avoid all fancy maths when uneeded. for instance, you always calcualte distance, even if the spell is over, the target is dead, or its past the damage interval
on top of that, you could remove the SquareRoot call by comparing to a squared break point

what happened to uplaoding two seperate versions?

lastly using T32 for this is silly, as you aren't doing damage all that often - as such, its much less efficient as a by product

sorry I can't approve this right now, not because of the menial change suggestions, as there are bigger, more tangible problems that exist
 

tooltiperror

Super Moderator
Reaction score
231
It's been quite a while since emjlr posted, I think it's safe to say this is inactive.

Graveyarded.
 
General chit-chat
Help Users
  • No one is chatting at the moment.

      The Helper Discord

      Staff online

      • Ghan
        Administrator - Servers are fun

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top