[vJass] Trigger Does Nothing ?

[Carl-Fredrik]

Hey.. I wanted to start map with vJass again (I was starting to learn it) since I've started a new map now, and I want the map to be all visible. So I made this simple trigger.

scope vJass initializer Init

private function Actions takes nothing returns nothing
    call SetMapFlag( MAP_FOG_ALWAYS_VISIBLE, true )
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    local trigger trig = CreateTrigger(  )
    call TriggerAddAction( trig, function Actions )
endfunction
endscope

Well... after some tries, it finally works, the game starts... but well... the map is still dark >.>

Why?

// Carl-Fredrik

 

[Expelliarmus]

No event maybe?

 

[Carl-Fredrik]

I've checked "Run on Map Initilization", so it should be map initilization, or? Forgot to tell, sorry ^^

 

[Trollvottel]

run on map initialization wont work here since there is no "standart-jass-trigger" to run

 

[Carl-Fredrik]

run on map initialization wont work here since there is no "standart-jass-trigger" to run

Eh...

So what do I do?
Add the event that makes the trigger run after 0.01 sec ? ^^

 

[Expelliarmus]

I want the map to be all visible

Well to make the map visible, you can try:

scope vJass initializer Init
private function Actions takes nothing returns nothing
    call FogEnable( false )
    call FogMaskEnable( false )
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    local trigger trig = CreateTrigger(  )
    call TriggerAddAction( trig, function Actions )
endfunction
endscope

 

[Uberplayer]

scope vJass initializer Init

    private function Init takes nothing returns nothing
        call FogEnable(false)
        call FogMaskEnable(false)
    endfunction

endscope

vJass doesn't sound like the best possible scope name.

 

[Carl-Fredrik]

scope vJass initializer Init

private function Actions takes nothing returns nothing
    call FogEnable(false)
    call FogMaskEnable(false)
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    local trigger trig = CreateTrigger(  )
    call TriggerRegisterTimerEventSingle( trig, 0.01 )
    call TriggerAddAction( trig, function Actions )
endfunction
endscope

This works perfectly, thanks everyone for helping!

Edit: Btw, do the scope names matter?

 

[Expelliarmus]

You can remove the trigger with Uberplayer's code. A trigger is not required for Initialization.

 

[Uberplayer]

> Edit: Btw, do the scope names matter?
Does a person's name matter? Yes it does matter.

 

[Carl-Fredrik]

You can remove the trigger with Uberplayer's code. A trigger is not required for Initialization.

What shall I remove? Didn't get that really... u want me to put the code in the Map Script instead maybe?

 

[Expelliarmus]

Exactly what's Jass Tagged in Post #7

 

[Carl-Fredrik]

Exactly what's Jass Tagged in Post #7

... I added those actions and it works, I don't see the point in removing them..?

The Trigger:

scope Visibility initializer Init

private function Actions takes nothing returns nothing
    call FogEnable(false)
    call FogMaskEnable(false)
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    local trigger trig = CreateTrigger(  )
    call TriggerRegisterTimerEventSingle( trig, 0.01 )
    call TriggerAddAction( trig, function Actions )
endfunction
endscope

 

[Expelliarmus]

scope vJass initializer Init

    private function Init takes nothing returns nothing // initializer
        //local trigger trig = CreateTrigger(  )
        //call TriggerAddAction( trig, function Actions )
        call FogEnable(false)
        call FogMaskEnable(false)
        //the actions are in the Initializer
    endfunction

endscope

 

[Carl-Fredrik]

scope vJass initializer Init

    private function Init takes nothing returns nothing // initializer
        //local trigger trig = CreateTrigger(  )
        //call TriggerAddAction( trig, function Actions )
        call FogEnable(false)
        call FogMaskEnable(false)
        //the actions are in the Initializer
    endfunction

endscope

So I put this...

scope vJass initializer Init

    private function Init takes nothing returns nothing
        local trigger trig = CreateTrigger()
        call TriggerAddAction( trig, function Actions )
        call FogEnable(false)
        call FogMaskEnable(false)
    endfunction

endscope

...in the Map Script?

Sry if I don't get it.. I'm new at this

 

[Expelliarmus]

It is the trigger in function Init you don't need. You've called Fog and FogMask when the map initializes, the trigger is not needed anymore.

 

[Carl-Fredrik]

It is the trigger in function Init you don't need. You've called Fog and FogMask when the map initializes, the trigger is not needed anymore.

Ah, I get it now ^^ Ty

 

[Romek]

Basically, when the map starts, you're creating a new trigger, adding an event to it, and then the trigger runs when the event is triggered by doing:

function Init takes nothing returns nothing
   local trigger trig = CreateTrigger()
   call ...etc.
endfunction

Instead of creating the trigger and adding actions, events, etc.
You can just carry out the actions in the function which creates the trigger.

A Jass trigger is a variable type. The GUI trigger is the thing on the side.
Problem is.. the things on the side have no name except "Triggers"