Spell Whirlpool

[Kenny]

Not much I can say about it to be honest.

The spell looks really good (thank god you fixed the "instant" movement once the first spiral finished, it looks much better now).

The coding is pretty good too. From first glance it looks a little clustered though (the 3 line comments in the main part of the spell annoy me), but thats just me.

You can just use SetUnitFacing() instead of SetUnitFacingTimed(), seeing as you are using 0.00 seconds anyway.

Also, you never initialise d.MinSpinDist, you should fix that.

(I will look over the script some more to see if I missed anything.)

Other than that, it looks pretty good. Well done. :thup:

 

[BlackRose]

Recoded entirely :thup:

 

[kingkingyyk3]

-> Change all angle into radian, instead of keep converting them to each other.
-> Add optional requiring for Recycle and GroupUtils.
-> Nothing more.

 

[BlackRose]

Updated.

 

[Ghan]

Approved. Nice spell!

 

[Sharp]

@Edit: Ignore !

 

[BlackRose]

Let me just ask something more technical. How are you using NewGen with HashTables if Hastables were introduced in 1.24 and Grimoire doesn't support it?

I'm not using Hashtables? And I'm only using NewGen for JassHelper?

 

[Sharp]

You're using hashtables for SpellEvent but thanks. I just figured it out.

 

[Chaos_Knight]

Why so many requires?
Perosnally, i think this is very hard to import.

 

[BlackRose]

Why so many requires?
Perosnally, i think this is very hard to import.

It's a matter of copying and pasting. Not that hard. What I find hard is all those GUI ones to import. Ends up having a whole bunch of dummy units.

Also, I'm using everyday modern vJass systems, what's hard about importing it?

 

[Chaos_Knight]

You are right. Copy n Paste.

 

[Sharp]

Liked this spell, BlackRose! Congrats, check out the New Untitled Project in Members Project area.