Spell Whirlpool

Kenny

Back for now.
Reaction score
202
Not much I can say about it to be honest.

The spell looks really good (thank god you fixed the "instant" movement once the first spiral finished, it looks much better now).

The coding is pretty good too. From first glance it looks a little clustered though (the 3 line comments in the main part of the spell annoy me), but thats just me.

You can just use SetUnitFacing() instead of SetUnitFacingTimed(), seeing as you are using 0.00 seconds anyway.

Also, you never initialise d.MinSpinDist, you should fix that.

(I will look over the script some more to see if I missed anything.)

Other than that, it looks pretty good. Well done. :thup:
 

kingkingyyk3

Visitor (Welcome to the Jungle, Baby!)
Reaction score
216
-> Change all angle into radian, instead of keep converting them to each other.
-> Add optional requiring for Recycle and GroupUtils.
-> Nothing more.
 

BlackRose

Forum User
Reaction score
239
Sharp can NOT be ignored :O said:
Let me just ask something more technical. How are you using NewGen with HashTables if Hastables were introduced in 1.24 and Grimoire doesn't support it?

I'm not using Hashtables? And I'm only using NewGen for JassHelper?
 

BlackRose

Forum User
Reaction score
239
Why so many requires?
Perosnally, i think this is very hard to import.

It's a matter of copying and pasting. Not that hard. What I find hard is all those GUI ones to import. Ends up having a whole bunch of dummy units.

Also, I'm using everyday modern vJass systems, what's hard about importing it?
 

Sharp

New Member
Reaction score
5
Liked this spell, BlackRose! Congrats, check out the New Untitled Project in Members Project area.
 
General chit-chat
Help Users
  • No one is chatting at the moment.

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top