Yet, another leak question

XeRo13g

New Member
Reaction score
3
JASS:
function 2 takes nothing returns nothing
local timer t=GetExpiredTimer()
   (do something)
   call PauseTimer(t)
   call DestroyTimer(t)
   set t=null
endfunction

function 1 takes nothing returns nothing
local effect sfx
local timer t

if (condition==true) then
   set sfx=AddSpecialEffect("any effect",x,y)
   set t=CreateTimer()
   (use sfx)
   call DestroyEffect(sfx)
   set sfx=null
   call TimerStart(t,5.,false,function 2)
   set t=null
else
    (other actions)
endif
endfunction


Does function 1 leak the two handles(sfx,timer) in case the condition is false?
Should I use a null value for both at their declaration?

Thanks in advance.-
 
No, they won't leak; you only have to null them if you give them value (besides null)
 
a few tips
[ljass]call DestroyEffect(AddSpecialEffect("any effect",x,y))[/ljass] to avoid local var usage
[ljass]call TimerStart(CreateTimer(),5.,false,function 2)[/ljass] to avoid local var usage
[ljass]call DestroyTimer(GetExpiredTimer())[/ljass] no need to pause the timer when destroyed.
 
Thanks guys, that clear things up.

PS. I can't give rep to any of you. I'll get back to that asap.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    See how we like that.
  • The Helper The Helper:
    I do not see a way to go past the 1st page of posts on the forum though
  • The Helper The Helper:
    It is OK though for the main page to open up on the forum in the view it was before. As long as the portal has its own URL so it can be viewed that way I do want to try it as a regular forum view for a while
  • Ghan Ghan:
    Yeah I'm not sure what the deal is with the pagination.
  • Ghan Ghan:
    It SHOULD be there so I think it might just be an artifact of having an older style.
  • Ghan Ghan:
    I switched it to a "Standard" article forum. This will show the thread list like normal, but the threads themselves will have the first post set up above the rest of the "comments"
  • The Helper The Helper:
    I don't really get that article forum but I think it is because I have never really seen it used on a multi post thread
  • Ghan Ghan:
    RpNation makes more use of it right now as an example: https://www.rpnation.com/news/
  • The Helper The Helper:
  • The Helper The Helper:
    What do you think Tom?
  • tom_mai78101 tom_mai78101:
    I will have to get used to this.
  • tom_mai78101 tom_mai78101:
    The latest news feed looks good
  • The Helper The Helper:
    I would like to see it again like Ghan had it the first time with pagination though - without the pagination that view will not work but with pagination it just might...
  • The Helper The Helper:
    This drink recipe I have had more than a few times back in the day! Mind Eraser https://www.thehelper.net/threads/cocktail-mind-eraser.194720/
  • The Helper The Helper:
    Happy Thursday!
  • Ghan Ghan:
    I'm not so sure, there's still a lot of Thursday left for it to become unhappy.
    +3
  • The Helper The Helper:
    still a few hours
  • The Helper The Helper:
    Its Friday!!!!
    +1
  • Ghan Ghan:
    Thursday 7/10 would Thursday again
    +3
  • The Helper The Helper:
    New forum coming soon going to be for my friend Saylor who is blind and he is doing motivational speaking and has an internet radio show and podcast. I am going to put a forum to promote him and other inspirational speaker stuff going to have some good stuff in it.
  • The Helper The Helper:
    his audio only music mix
  • The Helper The Helper:
    it just makes sense right?

      The Helper Discord

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top