Animating a building - help

[†ALPHA†]

I have a custom lumber mill model that's missing a proper work animation. I already tried transferring the original human lumber mill work anim but that didn't work. So I tried a group of triggers. Unfortunately because the triggers are rather inefficient the removal of the effect doesn't always work since the work anim isn't always the "last created effect"

Could you give me any help on how to make these triggers into one, efficient trigger?

LumberMillUpgradeBegin
    Events
        Unit - A unit Begins research
    Conditions
        (Unit-type of (Triggering unit)) Equal to Lumber Mill
    Actions
        Special Effect - Create a special effect attached to the first large of (Triggering unit) using Abilities\Spells\Items\HealingSalve\HealingSalveTarget.mdl

LumberMillUpgradeFinish
    Events
        Unit - A unit Finishes research
    Conditions
        (Unit-type of (Triggering unit)) Equal to Lumber Mill
    Actions
        Special Effect - Destroy (Last created special effect)

LumberMillUpgradeCancel
    Events
        Unit - A unit Cancels research
    Conditions
        (Unit-type of (Triggering unit)) Equal to Lumber Mill
    Actions
        Special Effect - Destroy (Last created special effect)

-EDIT-
I added variables in order to store the special effect. This prevents these triggers from interfering from other effects but if I happen to have TWO lumber mills...

Set LumberUpgrade = (Last created special effect)  //appended to end of LumberMillUpgradeBegin

Special Effect - Destroy LumberUpgrade  //replaces last line in LumberMillUpgradeFinish and LumberMillUpgradeCancel

 

[†ALPHA†]

-BUMP-
This is the current state of my triggers:

LumberMillUpgradeBegin
    Events
        Unit - A unit Begins research
    Conditions
        (Unit-type of (Triggering unit)) Equal to Lumber Mill
    Actions
        Special Effect - Create a special effect attached to the first large of (Triggering unit) using Abilities\Spells\Items\HealingSalve\HealingSalveTarget.mdl
        Set LumberUpgrade = (Last created special effect)

LumberMillUpgradeFinish
    Events
        Unit - A unit Finishes research
    Conditions
        (Unit-type of (Triggering unit)) Equal to Lumber Mill
    Actions
        Special Effect - Destroy LumberUpgrade

LumberMillUpgradeCancel
    Events
        Unit - A unit Cancels research
    Conditions
        (Unit-type of (Triggering unit)) Equal to Lumber Mill
    Actions
        Special Effect - Destroy LumberUpgrade

 

[Azlier]

I would suggest attaching the effect to the unit. You need an effect array and an integer variable...

• Trig 1
  • Events
    • Unit - A unit Begins research
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to (==) Lumber Mill
  • Actions
    • Special Effect - Create a special effect attached to the first large of (Triggering unit) using Abilities\Spells\Items\HealingSalve\HealingSalveTarget.mdl
    • Set LumberSFX[LumberIndex] = (Last created special effect)
    • Unit - Set the custom value of (Triggering unit) to LumberIndex
    • Set LumberIndex = (LumberIndex + 1)

• Trig 2
  • Events
    • Unit - A unit Cancels research
    • Unit - A unit Finishes research
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to (==) Lumber Mill
  • Actions
    • Special Effect - Destroy LumberSFX[(Custom value of (Triggering unit))]

 

[†ALPHA†]

Thanks azlier! It works great but there is one slight problem...
If the mill begins two different upgrades but then cancels one and continues with the other, the effect completely disappears. This isn't a big problem since I, and my friends, don't tend to ever cancel an upgrade.

If there's a way around that, I'd appreciate it! Thanks again! +rep