Comparing GetPlayerController and PLAYER_SLOT_STATE_PLAYING on Map Init ?

Komaqtion

You can change this now in User CP.
Reaction score
469
Hello ! :D

Ok, so I'm trying to make a "Swap command" system right now, like when you type "-swap 3" you will want to swap your hero for [ljass]Player( 3 )[/ljass]'s hero ;) (From DotA...)

Ok, so to the problem:
I'm trying to check the following on Map Initialization:


Should this work ? :S

Here's the entire code, and the message from the "[ljass]call BJDebugMsg( GetPlayerName( p ) )[/ljass]" line, doesn't show :(

JASS:
library SwapHeroes initializer Init requires SimError, TimerUtils

    globals
        private constant boolean HEROES_ON_INIT = false
    endglobals

    globals
        private group ENUM = CreateGroup()
        
        private integer tempInt = 0
    endglobals

    private struct SwapData extends array
        boolean hasSwapped
        
        unit swapUnit
        unit targetUnit
        
        player swapPlayer
        player targetPlayer
    endstruct
        
    private function SwapActions takes nothing returns boolean
        local player p = GetTriggerPlayer()
        local player pt = Player( S2I( SubString( GetEventPlayerChatString(), 6, StringLength( GetEventPlayerChatString() ) ) ) )
        
        if GetPlayerId( pt ) >= 12 or GetPlayerId( pt ) < 0 or pt == null then
            call SimError( p, "You need to input a valid player-id ! \n Try again, please !" )
            
            return false
        endif
        
        /*if pt != null and p != null and SwapData[ GetPlayerId( p ) ].swapUnit != null and SwapData[ GetPlayerId(  then
            
        endif*/
        
        return false
    endfunction
    
    static if HEROES_ON_INIT then
    
        private function PickInitHeroes takes nothing returns boolean
            local unit u = GetFilterUnit()
            local player p = GetOwningPlayer( u )
            
            if tempint == 0 then
                set SwapHeroes[ GetPlayerId( p ) ].swapUnit = u
                set tempInt = 1
            endif
            
            set u = null
            set p = null
            
            return false
        endfunction
    
        private function OnInitHeroes takes nothing returns nothing
            local integer i = 0
            local player p
            
            loop
                exitwhen i >= 12
                
                set tempInt = 0
                set p = Player( i )
                
                if SwapData[ GetPlayerId( p ) ].swapUnit != null and GetPlayerController( p ) == MAP_CONTROL_USER and GetPlayerController( p ) == PLAYER_SLOT_STATE_PLAYING then
                    call GroupEnumUnitsOfPlayer( ENUM, p, Filter( function PickInitHeroes ) )
                endif
                
                set i = i + 1
            endloop
        
        endfunction
    
    endif
    
    static if DEBUG_MODE then
        private function DebugHero takes nothing returns nothing            
            set SwapData[0].swapUnit = gg_unit_hpea_0001
        endfunction
    endif

    private function Init takes nothing returns nothing
        local trigger t = CreateTrigger()
        local integer i = 0
        local player p = null
        
        loop
            exitwhen i >= 12
            
            set p = Player( i )
            
            if GetPlayerController( p ) == MAP_CONTROL_USER and GetPlayerController( p ) == PLAYER_SLOT_STATE_PLAYING then
                call TriggerRegisterPlayerChatEvent( t, p, "-swap ", true )
                
                call BJDebugMsg( GetPlayerName( p ) )
                
                set SwapData[ GetPlayerId( p ) ].hasSwapped = false
                set SwapData[ GetPlayerId( p ) ].swapPlayer = p
            endif
            
            set i = i + 1
        endloop
        
        call TriggerAddCondition( t, Condition( function SwapActions ) )
        
        static if HEROES_ON_INIT then
            call OnInitHeroes()
        endif
        
        static if DEBUG_MODE then
            call DebugHero()
        endif
        
    endfunction
    
endlibrary


But the thing is, I have also tried to use a great variety of methods using the same trigger, like using a timer and another function for it all, using another trigger, and a periodic event of 0.00, 0.01 and 1.00, simply adding a single action (Though used condition) to a trigger in the init function, but NOTHING of this has worked...

I've also narrowed it down to only being the "[ljass]GetPlayerController( p ) == PLAYER_SLOT_STATE_PLAYING[/ljass]" that's not working, but the VERY wierd part is that I converted a (Originally) GUI trigger with that same condition in it to custom script, and used the event "Map Initialization", and that WORKED ?!?! :S

Is there something I'm missing here, or what ? XD
 

Komaqtion

You can change this now in User CP.
Reaction score
469
OUCH !!!!!!!! XD

Such a silly mistake !!!!!!!!!!! XD

Thanks a bunch, I though the WE flipped on me :p
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top