Could I get some help fixing this memory leak?

Nureru

Nureru

New Member
Reaction score
1
Everything I've tried has broken the trigger, and I'm getting frustrated.

Code: 
Set Did_Chain_Propagate = False
Unit Group - Pick every unit in Chain and do (Actions)
    Loop - Actions
        Player Group - Pick every player in team and do (Actions)
            Loop - Actions
                Set chainlocation = (Position of (Picked unit))
                Unit Group - Pick every unit in (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Not equal to Builder) and ((((Matching unit) is in Chain) Equal to False) and ((Distance between chainlocation and (Position of (Matching unit))) Less than 182.00)))) and do (Actions)
                    Loop - Actions
                        Unit Group - Add (Picked unit) to Chain
                        If ((Y of chainlocation) Less than Chain_min_y) then do (Set Chain_min_y = (Y of chainlocation)) else do (Do nothing)
                        If ((Y of chainlocation) Greater than Chain_max_y) then do (Set Chain_max_y = (Y of chainlocation)) else do (Do nothing)
                        Set Did_Chain_Propagate = True
Custom script:   call RemoveLocation( udg_chainlocation )
If (Did_Chain_Propagate Equal to True) then do (Trigger - Run (This trigger) (checking conditions)) else do (Trigger - Run Chain finished propagating <gen> (checking conditions))

I know using the Position of (Matching Unit) is bad, but I can't figure out how to set that manually before I need to use it there.
 
vypur85

vypur85

Hibernate
Reaction score
803
Code: 
Set Did_Chain_Propagate = False
Unit Group - Pick every unit in Chain and do (Actions)
    Loop - Actions
        Player Group - Pick every player in team and do (Actions)
            Loop - Actions
                Set chainlocation = (Position of (Picked unit))
                Unit Group - Pick every unit in (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Not equal to Builder) and ((((Matching unit) is in Chain) Equal to False) and [del]((Distance between chainlocation and (Position of (Matching unit))) Less than 182.00))))[/del] and do (Actions)
                    Loop - Actions
                       [B]Set SomePoint = Position of (Picked unit)[/B]
                       If then else
                          Condition
                             ((Distance between chainlocation and [B]SomePoint[/B]) Less than 182.00))))
                          Then - Actions
                             Unit Group - Add (Picked unit) to Chain
                             If ((Y of chainlocation) Less than Chain_min_y) then do (Set Chain_min_y = (Y of chainlocation)) else do (Do nothing)
                             If ((Y of chainlocation) Greater than Chain_max_y) then do (Set Chain_max_y = (Y of chainlocation)) else do (Do nothing)
                             Set Did_Chain_Propagate = True
                          Else - Actions
                       [B]Custom script:  call RemoveLocation...[/B]
                Custom script:   call RemoveLocation( udg_chainlocation )
If (Did_Chain_Propagate Equal to True) then do (Trigger - Run (This trigger) (checking conditions)) else do (Trigger - Run Chain finished propagating <gen> (checking conditions))

Try not to use any potentially leaky stuff in the filter function (not in GUI). You need to set the point in the loop itself. Then filter again using ITE.
 
Nureru

Nureru

New Member
Reaction score
1
I guess I fixed it by doing it like this

Trigger:
  • Unit Group - Pick every unit in (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Not equal to Builder) and (((Matching unit) is in Chain) Equal to False))) and do (Actions)
    • Loop - Actions
      • Set matchlocation = (Position of (Picked unit))
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Distance between chainlocation and matchlocation) Less than 182.00
        • Then - Actions
          • Unit Group - Add (Picked unit) to Chain
          • If ((Y of chainlocation) Less than Chain_min_y) then do (Set Chain_min_y = (Y of chainlocation)) else do (Do nothing)
          • If ((Y of chainlocation) Greater than Chain_max_y) then do (Set Chain_max_y = (Y of chainlocation)) else do (Do nothing)
          • Set Did_Chain_Propagate = True
        • Else - Actions


But it's behaving a bit quirky. It works now, but when I check the length of the chain with this trigger
Trigger:
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Chain_max_y - Chain_min_y) Greater than or equal to 1024.00
    • Then - Actions
      • Set walleffect = (Position of (Triggering unit))
      • Special Effect - Create a special effect at walleffect using Abilities\Spells\Human\DispelMagic\DispelMagicTarget.mdl
      • Special Effect - Destroy (Last created special effect)
      • Custom script: call RemoveLocation( udg_walleffect )
      • Unit - Remove (Triggering unit) from the game
      • Player - Add (((Point-value of (Triggering unit)) x 125) / 100) to (Owner of (Triggering unit)) Current gold
      • Game - Display to (All players) for 5.00 seconds the text: (Pipeline blocked; chain length = + (String((Chain_max_y - Chain_min_y))))
    • Else - Actions
      • Game - Display to (All players) for 5.00 seconds the text: (No blocking yet; vertical chain length is only + (String((Chain_max_y - Chain_min_y))))


it takes three towers before it starts increasing the length. Since it works I suppose it's probably nothing to worry about, but any idea why it might be doing that?
 
Defi4nc3

Defi4nc3

Developer of DORPG
Reaction score
20
No you didn't fix it, your missing the most obvious... Unit Groups cause Leaks, you need a Unit Group Variable~

call DestroyGroup(udg_YourUnitGroup) = Remove Unit Groups

call DestroyForce(udg_team) = Removing your Player Group

Your initial Unit Group trigger is not a variable...

Set UnitGroup = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Not equal to Builder) and (((Matching unit) is in Chain) Equal to False))) and do (Actions)

etc... for your start...
 
Nureru

Nureru

New Member
Reaction score
1
How's this
Trigger:
  • Actions
    • Set Did_Chain_Propagate = False
    • Unit Group - Pick every unit in Chain and do (Actions)
      • Loop - Actions
        • Player Group - Pick every player in team and do (Actions)
          • Loop - Actions
            • Set chainlocation = (Position of (Picked unit))
            • Set unitgroup = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Not equal to Builder) and (((Matching unit) is in Chain) Equal to False)))
            • Unit Group - Pick every unit in unitgroup and do (Actions)
              • Loop - Actions
                • Set matchlocation = (Position of (Picked unit))
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Distance between chainlocation and matchlocation) Less than 182.00
                  • Then - Actions
                    • Unit Group - Add (Picked unit) to Chain
                    • If ((Y of chainlocation) Less than Chain_min_y) then do (Set Chain_min_y = (Y of chainlocation)) else do (Do nothing)
                    • If ((Y of chainlocation) Greater than Chain_max_y) then do (Set Chain_max_y = (Y of chainlocation)) else do (Do nothing)
                    • Set Did_Chain_Propagate = True
                  • Else - Actions
    • Custom script: call RemoveLocation( udg_chainlocation )
    • Custom script: call RemoveLocation( udg_matchlocation )
    • Custom script: call DestroyGroup( udg_unitgroup )
    • If (Did_Chain_Propagate Equal to True) then do (Trigger - Run (This trigger) (checking conditions)) else do (Trigger - Run Chain finished propagating &lt;gen&gt; (checking conditions))


I remove the player group in Chain finished propagating
 
vypur85

vypur85

Hibernate
Reaction score
803
This:
Code: 
Actions
    Set Did_Chain_Propagate = False
    Unit Group - Pick every unit in Chain and do (Actions)
        Loop - Actions
            Player Group - Pick every player in team and do (Actions)
                Loop - Actions
                    Set chainlocation = (Position of (Picked unit))
                    Set unitgroup = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Not equal to Builder) and (((Matching unit) is in Chain) Equal to False)))
                    Unit Group - Pick every unit in unitgroup and do (Actions)
                        Loop - Actions
                            Set matchlocation = (Position of (Picked unit))
                            If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                If - Conditions
                                    (Distance between chainlocation and matchlocation) Less than 182.00
                                Then - Actions
                                    Unit Group - Add (Picked unit) to Chain
                                    If ((Y of chainlocation) Less than Chain_min_y) then do (Set Chain_min_y = (Y of chainlocation)) else do (Do nothing)
                                    If ((Y of chainlocation) Greater than Chain_max_y) then do (Set Chain_max_y = (Y of chainlocation)) else do (Do nothing)
                                    Set Did_Chain_Propagate = True
                                Else - Actions
                            [B]Custom script:   call RemoveLocation( udg_matchlocation )
                    Custom script:   call RemoveLocation( udg_chainlocation )
                    Custom script:   call DestroyGroup( udg_unitgroup )[/B]
    If (Did_Chain_Propagate Equal to True) then do (Trigger - Run (This trigger) (checking conditions)) else do (Trigger - Run Chain finished propagating <gen> (checking conditions))

Anyway, does it not crash? Did you try in-game?
 
You must log in or register to reply here.
General chit-chat
Help Users
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      416 (members: 0, guests: 416)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top