Dynamic array/struct problem

U

Uberplayer

-
Reaction score
456
This is not the problem code, but works the same way.

JASS:
library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary


This is the error message:
temp2fc8.png


It seems to give the error for the third and fourth struct ([1][0] and [1][1]).
 
Cohadar

Cohadar

master of fugue
Reaction score
209
grid is a stupid name for matrix.

You forgot to create the matrix:
JASS:

set type2_ar = type2.create()


USE UPPERCASE FOR STRUCT AND TYPE NAMES DOUCHEBAG
 
Vexorian

Vexorian

Why no custom sig?
Reaction score
187
Actually, considering the type names used by normal Jass, I would say lower case for type names is more suitable for a standard.
 
Cohadar

Cohadar

master of fugue
Reaction score
209
I have the same opinion about persons who designed normal jass as of persons who designed cobol.
 
U

Uberplayer

-
Reaction score
456
>You forgot to create the matrix..
I tried, but it gives the same error.

JASS:
library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call BJDebugMsg(I2S(.type2_ar[0][0]))
            call BJDebugMsg(I2S(.type2_ar[0][1]))
            call BJDebugMsg(I2S(.type2_ar[1][0]))
            call BJDebugMsg(I2S(.type2_ar[1][1]))
        
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary


The debug messages, by the way, show:
3
4
3
4
"double free.."
"double free.."
 
B

Builder Bob

Live free or don't
Reaction score
249
You can do it like this.

JASS:
library Problem

	private struct Struct2
	endstruct
	
	private type type1 extends Struct2 array[2]
	private type type2 extends type1 array[2]
	
	struct Struct1
		private type2 type2_ar
		
		method Destroy takes nothing returns nothing
			call BJDebugMsg(I2S(.type2_ar[0][0]))
			call BJDebugMsg(I2S(.type2_ar[0][1]))
			call BJDebugMsg(I2S(.type2_ar[1][0]))
			call BJDebugMsg(I2S(.type2_ar[1][1]))
		
			call .type2_ar[0][0].destroy()
			call .type2_ar[0][1].destroy()
			call .type2_ar[1][0].destroy()
			call .type2_ar[1][1].destroy()
		endmethod
		
		static method create takes nothing returns Struct1
			local Struct1 str = Struct1.allocate()
			local integer i = 0
			set str.type2_ar = type2.create()
			loop
				set str.type2_ar<i> = type1.create()
				set i = i + 1
				exitwhen(i == 2)
			endloop
			set str.type2_ar[0][0] = Struct2.create()
			set str.type2_ar[0][1] = Struct2.create()
			set str.type2_ar[1][0] = Struct2.create()
			set str.type2_ar[1][1] = Struct2.create()
			return str
		endmethod
		
	endstruct
	
	public function InitTrig takes nothing returns nothing
		local Struct1 str = Struct1.create()
		call str.Destroy()
	endfunction

endlibrary</i>
 
B

Builder Bob

Live free or don't
Reaction score
249
I'm afraid I don't know enough about it to say for sure if this is the correct way to do it. I've never used it more than just trying it out.
 
Cohadar

Cohadar

master of fugue
Reaction score
209
Do I have to spell everything.

JASS:

library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
            call .type2_ar.destroy() // destroy the matrix after
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar = type2.create() // create the matrix before
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary
 
Cohadar

Cohadar

master of fugue
Reaction score
209
You are doing something wrong.
TIP: never say "it does not work" without showing the new code.
 
U

Uberplayer

-
Reaction score
456
I used your code. So you did something wrong, obviously.

But if you want to see the code, sure:
Cohadar said:
Do I have to spell everything.

JASS:

library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
            call .type2_ar.destroy() // destroy the matrix after
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar = type2.create() // create the matrix before
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary
Click to expand...
 
B

Builder Bob

Live free or don't
Reaction score
249
The debug messages, by the way, show:
3
4
3
4
"double free.."
"double free.."
Click to expand...
this hardly counts as "it does not work"

I'll take a wild guess and suggest the code
JASS:
library Problem

private struct Struct2
endstruct

private type type1 extends Struct2 array[2]
private type type2 extends type1 array[2]

struct Struct1
	private type2 type2_ar
	
	method Destroy takes nothing returns nothing
		local integer i = 0
		call BJDebugMsg(I2S(.type2_ar[0][0]))
		call BJDebugMsg(I2S(.type2_ar[0][1]))
		call BJDebugMsg(I2S(.type2_ar[1][0]))
		call BJDebugMsg(I2S(.type2_ar[1][1]))
	
		call .type2_ar[0][0].destroy()
		call .type2_ar[0][1].destroy()
		call .type2_ar[1][0].destroy()
		call .type2_ar[1][1].destroy()
		
		loop
			call .type2_ar<i>.destroy()
			set i = i + 1
			exitwhen(i == 2)
		endloop
		call .type2_ar.destroy()
		
	endmethod
	
	static method create takes nothing returns Struct1
		local Struct1 str = Struct1.allocate()
		local integer i = 0
		set str.type2_ar = type2.create()
		loop
			set str.type2_ar<i> = type1.create()
			set i = i + 1
			exitwhen(i == 2)
		endloop
		set str.type2_ar[0][0] = Struct2.create()
		set str.type2_ar[0][1] = Struct2.create()
		set str.type2_ar[1][0] = Struct2.create()
		set str.type2_ar[1][1] = Struct2.create()
		return str
	endmethod
	
endstruct

public function InitTrig takes nothing returns nothing
	local Struct1 str = Struct1.create()
	call str.Destroy()
endfunction

endlibrary</i></i>


Now someone with more knowledge can point out any errors.

It compiles, and shows the error messages:
1
2
3
4
as expected.

question is, is it destroyed correctly and in the right order?

I hope you don't mind me taking interest in this even though I don't know too much about it Uberplayer. I've been wondering about the same thing for a while.
 
TheDamien

TheDamien

_
Reaction score
333
Cohadar's code does not work because "type1"s are not being created.

Try:

JASS:
library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
            call .type2_ar[0].destroy()
            call .type2_ar[1].destroy()
            call .type2_ar.destroy() // destroy the matrix after
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar = type2.create() // create the matrix before
            set .type2_ar[0] = type1.create()
            set .type2_ar[1] = type1.create()
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary
 
Cohadar

Cohadar

master of fugue
Reaction score
209
It looks about right now.

So you must create the matrix, than create all the rows and then individual fields...

for destroying in reverse.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      91 (members: 2, guests: 89)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top