Exploding Arrows, not working

Nexor

...
Reaction score
74
I want to make a spell that will have an exploding part. The units near the explosion will be thrown away from the center of the explosion.
I wrote a code for it, but they won't fly.
the code:

JASS:
scope Explode initializer ExplodeInit

globals
    private constant integer ExplodeID        = 'A550'    // Raw id
    private constant real    ExplodeDamage    = 10.      // Base damage
    private constant real    ExplodeAttribute = 3.        // Attribute multiplier
    private constant real    ExplodeDistance  = 150.
    private constant real    ExplodeSpeed     = 550.
    private constant real    ExplodeRange     = 300.
    private constant real    PERIOD           = 0.04      // TT period
    private constant string  ExplodeEffect    = "Abilities\\Spells\\Human\\FlakCannons\\FlakTarget.mdl"
    private constant string  ExplodeAttach    = "origin"
    private constant real    Arc              = 1.3
    private constant integer CrowForm         = 'Amrf' 
endglobals

private function Parabola takes real dist, real maxdist returns real
    local real t = (dist*2)/maxdist-1
    return (-t*t+1)*(maxdist/Arc)
endfunction

private function ExplodeConditions takes nothing returns boolean
    return GetSpellAbilityId() == ExplodeID
endfunction

private constant function ExplodeDamageCalc takes integer attr returns real
    return ExplodeDamage + (attr*ExplodeAttribute)
endfunction

private struct Boom
    unit u
    real dx
    real dy
    integer ticks
    real Z
    real maxdist
    real startx
    real starty
endstruct

private function ExplodeCallback takes nothing returns boolean
    local Boom data = TT_GetData() // TT

    local real x = GetUnitX(data.u)+data.dx
    local real y = GetUnitY(data.u)+data.dy
    local real dx = data.startx-x
    local real dy = data.starty-y
    local real distance = SquareRoot(dx*dx + dy*dy)
    
    call SetUnitPosition(data.u,x,y) 
    set data.Z = Parabola(distance, data.maxdist)
    call SetUnitFlyHeight(data.u,data.Z,0)
    
    call DestroyEffect( AddSpecialEffectTarget( ExplodeEffect, data.u, ExplodeAttach))
    
    set data.ticks = data.ticks - 1
    if data.ticks <= 0 then  
        call SetUnitFlyHeight(data.u,GetUnitDefaultFlyHeight(data.u),0)
        call data.destroy()
        return true // stop ticking
    endif
    
    return false
endfunction

private function Explode takes unit u, location loc, real angle returns nothing
    local Boom data = Boom.create()
    local real x = GetLocationX(loc)
    local real y = GetLocationY(loc)
    local real dx = x-GetUnitX(u)
    local real dy = y-GetUnitY(u)
    local real distance = SquareRoot(dx*dx+dy*dy)
    local real newx = GetUnitX(u) + (ExplodeDistance-distance) * Cos(angle)
    local real newy = GetUnitY(u) + (ExplodeDistance-distance) * Sin(angle)
    local real Dx
    local real Dy
    
    call UnitAddAbility( u,CrowForm )
    call UnitRemoveAbility( u,CrowForm )

    
    set data.u = u
    set data.startZ = GetUnitFlyHeight(u)
    
    set Dx = newx - x
    set Dy = newy - y
    
    set distance = SquareRoot(Dx * Dx + Dy * Dy)
    set data.ticks = R2I(distance / (ExplodeSpeed*PERIOD))
    set data.maxdist = distance
    
    set angle = Atan2(Dy, Dx)
    set data.dx = (ExplodeSpeed*PERIOD) * Cos(angle)
    set data.dy = (ExplodeSpeed*PERIOD) * Sin(angle)
    
    
    call TT_Start(function ExplodeCallback, data) // TT
endfunction

private function ExplodeCast takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local location loc = GetSpellTargetLoc()
    local player p = GetOwningPlayer(u)
    
    local real x = GetLocationX(loc)
    local real y = GetLocationY(loc)
    local group g = CreateGroup()
    local unit f
    local real fx
    local real fy
    local real angle
    local real dmg = ExplodeDamageCalc(GetHeroAgi(u,true))
    
    set g = GetUnitsInRangeOfLocAll(ExplodeRange, loc)
    
    call DestroyEffect( AddSpecialEffect( "Abilities\\Spells\\Other\\Incinerate\\FireLordDeathExplode.mdl",x,y))
    
    loop
        set f = FirstOfGroup(g)
        exitwhen f == null
        if IsUnitEnemy(f,p) == true and GetWidgetLife(f) > .405 then
            set fx = GetUnitX(f)
            set fy = GetUnitY(f)
            set angle = Atan2(fy-y,fx-x)
            call Explode(f,loc,angle)
            call UnitDamageTarget(u,f,dmg,true,true, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_ACID, WEAPON_TYPE_WHOKNOWS)
        endif
        call GroupRemoveUnit(g,f)
    endloop
    
    call RemoveLocation(loc)
    set loc = null
    set u = null
endfunction

//===========================================================================
private function ExplodeInit takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( t, Condition( function ExplodeConditions ) )
    call TriggerAddAction( t, function ExplodeCast )
    set t = null
endfunction

endscope


What's wrong with it?
 

~GaLs~

† Ғσſ ŧħə ѕαĸε Φƒ ~Ğ䣚~ †
Reaction score
180
Use function BJDebugMsg() along with R2S() and check if every value is correctly assign.

I know math less, so I don't know that if or not that your equation are correct or not.
Just use the function and debug your code. :)
 

Nexor

...
Reaction score
74
the Z settings are wrong, the units are knocked away, they just won't do the parabola thing in the air.
I'll debug it and check.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top