function not called

[jackall]

function Blink takes unit who returns nothing
  local real maxX=GetRectMaxX(bj_mapInitialPlayableArea)
  local real maxY=GetRectMaxY(bj_mapInitialPlayableArea)
  local real minX=GetRectMinX(bj_mapInitialPlayableArea)
  local real minY=GetRectMinY(bj_mapInitialPlayableArea)
  local real newX=GetOrderPointX()
  local real newY=GetOrderPointY()
  local real oldX
  local real oldY
  local real angle
    if newX>maxX then
      set newX=maxX
    endif
    if newX<minX then
      set newX=minX
    endif
    if newY>maxY then
      set newY=maxY
    endif
    if newY<minY then
      set newY=minY
    endif
  set angle=bj_RADTODEG*Atan2(newY-oldY,newX-oldX)
    call SetUnitX(who,newX)
    call SetUnitY(who,newY)
    call DestroyEffect(AddSpecialEffect("Abilities\\Spells\\NightElf\\Blink\\BlinkCaster.mdl",newX,newY))
    call IssueImmediateOrder(who,"stop")
    call SetUnitFacing(who,angle)
    call PanCameraTo(newX,newY)
    call BJDebugMsg(R2S(newX))
    call BJDebugMsg(R2S(newY))
endfunction

Builder Move
    Events
        Unit - A unit Is issued an order targeting a point
    Conditions
        (Unit-type of (Triggering unit)) Equal to Builder
        Or - Any (Conditions) are true
            Conditions
                (String((Issued order))) Equal to move
                (String((Issued order))) Equal to smart
    Actions
        Custom script:   //local real x = GetOrderPointX()
        Custom script:   //local real y = GetOrderPointY()
        Custom script:   call Blink(GetTriggerUnit())

The Blink function doesn't get called...why not?

EDIT: nvm fixed

 

[GFreak45]

well i assume your unit cant cast blink past the playable map area due to target limitations and movement limitations, so i dont know why you use the GetRectMin/MaxX/Y
i would remove those

i would do it like this:

library BlinkLib
    function Blink takes unit who, real newX, real newY returns nothing
        local real angle = bj_RADTODEG*Atan2(newY-oldY,newX-oldX)
        call SetUnitX(who,newX)
        call SetUnitY(who,newY)
        call DestroyEffect(AddSpecialEffect("Abilities\\Spells\\NightElf\\Blink\\BlinkCaster.mdl",newX,newY))
        call IssueImmediateOrder(who,"stop")
        call SetUnitFacing(who,angle)
        call PanCameraTo(newX,newY)
        call BJDebugMsg(R2S(newX))
        call BJDebugMsg(R2S(newY))
    endfunction
endlibrary

• Blink
  • Events
    • A unit begins the effect of an ability
  • Conditions
    • Ability cast is equal to (blink)
  • Actions
    • Custom Script: local location a = GetSpellTargetLoc
    • Custom Script: call Blink(GetTriggerUnit(), GetLocationX(a), GetLocationY(a))
    • Custom Script: set a = null

hand written, dont hate me if it has typos/bad case sensitivity
also... functions that are lower on the script than the functions that call them never get called, try putting it in: library endlibrary, updating that in the jass up there ^

 

[jackall]

its supposed to be called when the builder moves be it move or smart
anyway fixed it, problem was oldX and oldY didnt have values set

thanks anyway

 

[luorax]

Stick to GFreak's code and spam that blink ability if you want to leak as much as possible.

Local variables do not get a value upon declaring them and using a variable without a value immediately crashes the thread. You don't have to worry about globals tho', their value will always be 0/0./false after declaration.

 

[GFreak45]

90% of that was copy paste from his code and it was freehand like i said, spend your time flaming elsewhere

 

[luorax]

I can't see leaking [ljass]GetSpellTargetLoc[/ljass] in his code (which is not even used as a function call, but as a variable), so don't blame him for your stupidity.

Also, I think I should ask a moderator for help, not only because ever since you started to "learn" JASS this section is full of your shit, but to stop neg-repping everyone for your own faults.

 

[Dirac]

GFreak i need you to define flaming, because from my point of view any technical correction to one of your post is flaming.
Because you write most of your codes out of freehand you have to expect someone to point out some major flaws you did there, and in this case it wasn't the fact that you were writing without a compiler what caused you to commit a mistake, it was your lack of JASS knowledge
All luorax did was to point out that your code leaks and in fact it does, 2 locations.
[ljass]GetSpellTargetX(),GetSpellTargetY()[/ljass]

 

[GFreak45]

flaming is when someone intentionally posts to start fights, essentially, flaming is being a troll... at least thats what i thought flaming meant, and saying, your function leaks, the way he said it, which was totally baseless at the time, is trolling, 100% undisputable trolling... and luorax you are the only one i have neg-repped, 1 for saying, that was an idiotic post why would you post that and in the same message saying the same thing reworded and for trolling here... and you are right i should i have cleared that leak correctly...
he didnt point out those leaks till the next post, and thats not jass knowledge thats plain gui, but i was concentrating more on the jass function that the gui custom script, i will edit it and remove those leaks, but i stand by my point that luorax was flaming

 

[KaerfNomekop]

luorax, you shouldn't have posted after OP said the problem was fixed :/ A PM to GFreak should have been enough.

Would a moderator be kind enough to close/lock this thread?

 

[UndeadDragon]

The problem has been fixed, and this thread is going the wrong way.

Closed.