How to improve this system?

[Lobster]

Im making a custom combat system, similar to ff13's, and Its pretty much finished. Im just wondering: How can I make it cleaner?
Updated:

library CombatEngine 

globals

//Configurables:
    private   real                      normalUpdate = .05 //The bar update rate when uneffected
    private   integer                   updateAmount = 1 //How much of the bar out of 100 is recovered per update
    
//other variables
    private   real              array   update 
    private   multiboard        array   mbList 
    private   Multibar          array   battleGage
    private   integer           array   value    
    private   AbilityData array abilities
    private   integer totalAbilities = 0
endglobals

struct AbilityData //Register abilities mana cost
    public    integer Spell = 0//The spell's ID
    public    integer Cost = 0//How much of the bar is drained
endstruct
//========================================================

function RegisterAbility takes integer S, integer C returns nothing//Creates the struct

    set abilities[totalAbilities] = AbilityData.create()
    set abilities[totalAbilities].Spell = S
    set abilities[totalAbilities].Cost = C
    set totalAbilities = totalAbilities + 1
 
endfunction

private function UpdateMultiboard takes nothing returns nothing//Updates the bar every time it fires
    local integer i = 0

    loop
    exitwhen i == 12
        set value<i> = value<i> + updateAmount
        call battleGage<i>.UpdateValue(value<i>,true)
        set i = i+1

    endloop
endfunction
//============================================
private function DrainBar takes nothing returns boolean//Compares if the casting ability is
//a registered spell, and drains the bar of that spells mana cost.
local integer i = 0
loop
    exitwhen i == totalAbilities
    if GetSpellAbilityId() == abilities<i>.Spell then
        if value[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))] &gt;= abilities<i>.Cost then
            set value[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))] = value[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))] - abilities<i>.Cost
            
        else
            call IssueImmediateOrder(GetTriggerUnit(), &quot;stop&quot;)
            
        endif
    endif
set i = i +1

endloop
return false
endfunction



//========================================================
 
function MultiboardCreation takes player p,string title, integer col, integer row, integer barInitValue returns nothing
//Creates the multiboard with multibar, suggested: 1 row 1 column for a better look    
    local trigger T2 = null//Trigger
    local timer Per = null//Timer

    set update[GetPlayerId(p)] = normalUpdate
    set Per = CreateTimer()
    
    call TimerStart(Per, update[GetPlayerId(p)] ,true, function UpdateMultiboard)

    set mbList[GetPlayerId(p)] = CreateMultiboard()
   
    call MultiboardSetColumnCount(mbList[GetPlayerId(p)], col)
    call MultiboardSetRowCount(mbList[GetPlayerId(p)], row)
    call MultiboardSetTitleText(mbList[GetPlayerId(p)], title)
    set battleGage[GetPlayerId(p)] = Multibar.create(mbList[GetPlayerId(p)],0,0,16,100,10,2)
   
    call MultiboardDisplay(mbList[GetPlayerId(p)], true)
   
    set value[GetPlayerId(p)] = barInitValue
    
    set T2 = CreateTrigger()
 
    
    call TriggerAddCondition(T2, function DrainBar)
    call TriggerRegisterAnyUnitEventBJ(T2,EVENT_PLAYER_UNIT_SPELL_CAST )
    
endfunction


endlibrary</i></i></i></i></i></i></i>

 

[Lyerae]

Gotta indent the code a bit more, so it's easier to read.

 

[kingkingyyk3]

and privatlize all unneeded variables and functions.

 

[Anachron]

Use library.
Use structs
Declare methods private / public.
Use the correct indenting
Write comments above the things you do.

Example

library ThisIsATestLibrary

    struct TestStruct
        //: This is a test for members that can't be
        //: acessed outside the object itself
        private integer youCantAccessFromOutside = 0
        
        //: This is a test for members that can be
        //: acessed outside the object
        public unit youCanAccessMeFromAnywhere = null
        
        /* Create our object and return it.
            Don't forget to set the members correctly */
        public static method create takes unit u, integer i returns thistype
            local thistype this = thistype.allocate()
            
            set .youCanAccessMeFromAnywhere = u
            set .youCantAccessFromOutside   = i
            
            return this
        endmethod
    endstruct
endlibrary

 

[Lobster]

Use library.
Use structs
Declare methods private / public.
Use the correct indenting
Write comments above the things you do.

Example

library ThisIsATestLibrary

    struct TestStruct
        //: This is a test for members that can't be
        //: acessed outside the object itself
        private integer youCantAccessFromOutside = 0
        
        //: This is a test for members that can be
        //: acessed outside the object
        public unit youCanAccessMeFromAnywhere = null
        
        /* Create our object and return it.
            Don't forget to set the members correctly */
        public static method create takes unit u, integer i returns thistype
            local thistype this = thistype.allocate()
            
            set .youCanAccessMeFromAnywhere = u
            set .youCantAccessFromOutside   = i
            
            return this
        endmethod
    endstruct
endlibrary

Why does everything have to be in a struct? Also, Im already using a library, Ill add comments, and I thought I did indent(Maybe I don't know how to indent properly?
function
-call
-if
--if actions
-else
--else actions
-endif
endfunction
right?

Just go an indentation further per code block?

 

[Anachron]

Correct.

Most things need structs. That's why. Also there is nothing bad at using them even if you can do it in another way.

 

[Trollvottel]

Correct.

Most things need structs. That's why. Also there is nothing bad at using them even if you can do it in another way.

doesnt mean you have to have everything in a struct.

 

[Lyerae]

No, but some people like doing things OO.