IKilledKEnny's JASS Question Theard, I love to give +REP :)

Status
Not open for further replies.
I

IKilledKEnny

Guest
Jesus, thanks to all the pointers Andrew! It shows that I'm a begginer. :p

Anyway doesn't this line

call UnitAddAbilityBJ( 'Arav', cast )
Click to expand...

add crow form?

Edit: So sorry but another problem (lol those spells were supposed to be in a released spell pack, I guess I'll have to give you all tons of credits :p ), anyway I'm trying to work on this spell and I just checked it and it doesn't work. I believe the bolded line is what screws it (I removed if / then / else to be sure i's not luck that does it)

Code: 
function Trig_Air_Shield_Conditions takes nothing returns boolean
    if ( not ( UnitHasBuffBJ(GetSpellTargetUnit(), 'B000') == true ) ) then
        return false
    endif
    if ( not ( GetUnitAbilityLevelSwapped('ANab', GetSpellTargetUnit()) >= GetUnitAbilityLevelSwapped(GetSpellAbilityId(), GetSpellAbilityUnit()) ) ) then
        return false
    endif
    return true
endfunction

function Trig_Air_Shield_Actions takes nothing returns nothing
    local location AHLoc
    local unit dum
    local unit vic
    local unit ref
        set vic = GetSpellAbilityUnit()
        set ref = GetSpellTargetUnit()
        set AHLoc = GetUnitLoc(GetSpellTargetUnit())
        call CreateNUnitsAtLoc( 1, 'h001', GetOwningPlayer(GetSpellTargetUnit()), AHLoc, GetUnitFacing(GetSpellTargetUnit()) )
        set dum = GetLastCreatedUnit()
        call UnitAddAbilityBJ( GetSpellAbilityId(), dum )
        call SetUnitAbilityLevelSwapped( GetSpellAbilityId(), dum, GetUnitAbilityLevelSwapped(GetSpellAbilityId(), GetSpellAbilityUnit()) )
        call TriggerSleepAction (1.00)
        call SetUnitAnimation( ref, "cast" )
[B]        call IssueTargetOrderBJ( dum, AbilityId2String(GetSpellAbilityId()), vic)[/B]

endfunction

//===========================================================================
function InitTrig_Air_Shield takes nothing returns nothing
    set gg_trg_Air_Shield = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Air_Shield, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Air_Shield, Condition( function Trig_Air_Shield_Conditions ) )
    call TriggerAddAction( gg_trg_Air_Shield, function Trig_Air_Shield_Actions )
endfunction
 
I

IKilledKEnny

Guest
Nope, I used that before and saw it doesn't work so I tried what sooda (or chocobo? :p ) said about using Arav and both didn't work...
 
E

emjlr3

Change can be a good thing
Reaction score
395
crow form works, so does metamorphisis I believe
 
I

IKilledKEnny

Guest
Well, I guess i did somthing really wrong, but it doesn't work for me... What do you think the problem might be? Would you mind if I'll post the map and I'll say what are the problems in each Trigger, and you will try to fix them? I know it's a lot of work, but I would really appreciate that. :D

Thanks!
 
Andrewgosu

Andrewgosu

The Silent Pandaren Helper
Reaction score
716
Well, try this one. I optimized the code, too.

Code: 
function Trig_Air_Shield_Conditions takes nothing returns boolean
    return ( ( GetUnitAbilityLevel( GetSpellTargetUnit(), 'B000' ) > 0 ) and (( GetUnitAbilityLevel(GetSpellTargetUnit(), 'ANab' ) >= GetUnitAbilityLevel( GetTriggerUnit(), GetSpellAbilityId()))))
endfunction

function Trig_Air_Shield_Actions takes nothing returns nothing
    local unit     a  =  GetTriggerUnit()
    local unit     b  =  GetSpellTargetUnit()
    local real     x  =  GetUnitX( b )
    local real     y  =  GetUnitY( b )
    local real     r  =  GetUnitFacing( b )
    local integer  i  =  GetSpellAbilityId()
    local unit     c  =  CreateUnit( GetOwningPlayer( b ), 'h001', x, y, r ) 

    if ((GetRandomInt(1, 100) <= (GetUnitAbilityLevel( b, 'A002' ) * 15))) then
        call UnitAddAbility( c, i )
        call SetUnitAbilityLevel( c, i, GetUnitAbilityLevel( a, i ) )
        call TriggerSleepAction ( 1.00 )
        call SetUnitAnimation( b, "cast" )
        call IssueTargetOrderById( c, i, b )
    endif
    
    set a = null
    set b = null
    set c = null    
endfunction

//===========================================================================
function InitTrig_Air_Shield takes nothing returns nothing
    set gg_trg_Air_Shield = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Air_Shield, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Air_Shield, Condition( function Trig_Air_Shield_Conditions ) )
    call TriggerAddAction( gg_trg_Air_Shield, function Trig_Air_Shield_Actions )
endfunction
 
I

IKilledKEnny

Guest
New question.

I'm trying to get a learned skill's id. I figured the following line should work, however it disables my trigger for an unknown reason. When I ran it in JASSCraft it says I have too many arguments.

function Sap Conditions takes nothing returns boolean
return GetSpellAbilityId(GetLearnedSkill())=='A000'==true
endfunction
 
Chocobo

Chocobo

White-Flower
Reaction score
409
IKilledKEnny said:
New question.

I'm trying to get a learned skill's id. I figured the following line should work, however it disables my trigger for an unknown reason. When I ran it in JASSCraft it says I have too many arguments.

function Sap Conditions takes nothing returns boolean
return GetSpellAbilityId(GetLearnedSkill())=='A000'==true
endfunction
Click to expand...

Code: 
function Sap Conditions takes nothing returns boolean
return GetSpellAbilityId(GetLearnedSkill())=='A000'
endfunction

instead.
 
I

IKilledKEnny

Guest
Thanks. Next Question.

I tryed to do this:

set dummy=CreateNUnitsAtLoc(1,id,p,ld,bj_UNIT_FACING)

Like I was told I can do it, however it disabled the trigger. When I did

call CreateNUnitsAtLoc(1,id,p,ld,bj_UNIT_FACING)
set dummy=GetLastCreatedUnit

it worked fine however.
 
I

IKilledKEnny

Guest
local unit dummy=CreateUnit(id,p,ld,bj_UNIT_FACING)

Still doesn't work.
 
I

IKilledKEnny

Guest
Yet, another question. Why is this trigger disabled? (This is just a part of the trigger)

Code: 
function TFGC takes nothing returns boolean
return GetFilterUnit()!=GetTriggerUnit()
endfunction

function TFC takes nothing returns boolean
return GetSpellAbilityId()=='A000'
endfunction

function TFA takes nothing returns nothing
local unit c=GetTriggerUnit()
local group g=CreateGroup()
local boolexpr b=Condition(function TFGC)
local unit f

call GroupEnumUnitsInRect(g,GetWorldBounds(),b)
loop
  set f=FirstOfGroup(g)
  exitwhen f==null
  call PauseUnitBJ(f,true)
[B]  call GroupRemoveUnit(g,f)[/B]
endloop

It tells about the bolded line that there is invalid arguement type (boolean)
 
I

IKilledKEnny

Guest
Lol, such a simple problem. Thanks again.

JASS is pretty hard. :p
 
I

IKilledKEnny

Guest
Yet, another question. Why does this disable the trigger? I believe it has somthing to do with the bolded part but I'm not sure.

Code: 
function TFMC2 takes nothing returns boolean
if (GetIssuedOrderIdBJ()==String2OrderIdBJ("smart")) then
  return true
elseif (GetIssuedOrderIdBJ()==String2OrderIdBJ("move")) then
return true
endif
return false
endfunction

function TFMC1 takes nothing returns boolean
if [B](function TFMC2==true)[/B] then
  if UnitHasBuffBJ(GetTriggerUnit(),'B000') then
    return true
  endif
endif
return false
endfunction
 
I

IKilledKEnny

Guest
Thanks again AceHart.

I want it to be
Unit has buff and the command is either smart or move, I figured that would be the easiest way to do it.
 
I

IKilledKEnny

Guest
I read Daelin's tutorial (Advanced Tips) and got great explanation from Tom Jones regarding local handles. From what I understood you can call a linker and then few handles that will be linked to him.

So by being able to call the linker only, you can also call the other linked handles. (Daelin's used the word linked so I assume that is what more or less happening).

Also I have been told that not destroy the leaks when we are done with them casus a leak.

My question is say that I want to keep the links to rest of the game, doesn't matter why. How bad would the leak be?

I'll give you an example, say I want to keep pushing a unit back all the game, thus in order to make the pushing efficent I need the unit to be "linked" to a timer (and maybe even a point). So if I wanto achive this, how would it effect the computer?
 
Status
Not open for further replies.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +1
  • V-SNES V-SNES:
    Happy Friday!
     +1

      The Helper Discord

      Members online

      Online now:
      272 (members: 1, guests: 271)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top