Income Trigger

[Sirroelivan]

I've been experimenting with JASS lately, but I've come at a problem. The function is meant to add 1 gold to each player for each unit they have. However, Jasscraft gives this error: line 12: cannot convert playerstate to real.

call SetPlayerState(p,PLAYER_STATE_RESOURCE_GOLD, (R2I(PLAYER_STATE_RESOURCE_GOLD) + 1))

 

[Viikuna]

In that case you need to find some function, which converts playerstate to real

Try this one:

constant native GetPlayerState takes player whichPlayer, playerstate whichPlayerState returns integer

EDIT. ey, that one returns integer, just noticed.

 

[Sirroelivan]

Ok, I've got a new problem now. The trigger is supposed to add 1 gold to the owner of each rifleman, but it adds nothing.

function IncomeActions takes nothing returns nothing
local group g = CreateGroup()
local unit dummy
local player p

call GroupEnumUnitsOfType(g, "hrif", null)
loop
    set dummy = FirstOfGroup(g)
    set p = GetOwningPlayer(dummy)
    exitwhen dummy==null
    call GroupRemoveUnit(g, dummy)
    call SetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(p, PLAYER_STATE_RESOURCE_LUMBER) + 1) 
endloop

call DestroyGroup(g)
set g = null
endfunction

function InitTrig_Income takes nothing returns nothing
    set gg_trg_Income = CreateTrigger(  )
    call TriggerRegisterTimerEventPeriodic( gg_trg_Income, 2 )
    call TriggerAddAction( gg_trg_Income, function IncomeActions )
endfunction

 

[quraji]

    call SetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(p, PLAYER_STATE_RESOURCE_[B]LUMBER[/B]) + 1)

 

[Viikuna]

call GroupEnumUnitsOfType(g, "hrif", null)

I might be wrong, but isnt null booleanexpres dangerous or something?

And use BJDebugMsg to find where your code fails.

 

[Sirroelivan]

Changed it, but it's still not working.

 

[Artificial]

call GroupEnumUnitsOfType(g, "hrif", null)

hrif should be a rawcode, not a string.

call GroupEnumUnitsOfType(g, 'hrif', null)

 

[Sirroelivan]

If I change "hrif" to 'hrif', world edit says "invalid argument type".

@Viikuna: I don't know if it's dangerous, but how should I write that line than?

 

[SerraAvenger]

If I change "hrif" to 'hrif', world edit says "invalid argument type".

@Viikuna: I don't know if it's dangerous, but how should I write that line than?

GetUnitsOfTypeIdAll('hrif') would enum units that way.

Should be dwarfish sniper with the thing you use, if I remember correctly.

    set p = GetOwningPlayer(dummy)
    exitwhen dummy==null

please swap these two lines, too. Might give out some bugs when dummy == null ( unbound reference or w/e )

hth, Davey

 

[Sirroelivan]

@ SerraAvenger: Thanks for the help, it works now. I just wonder why it didn't work with "call GroupEnumUnitsOfType(g, "hrif", null)".

 

[SerraAvenger]

@ SerraAvenger: Thanks for the help, it works now. I just wonder why it didn't work with "call GroupEnumUnitsOfType(g, "hrif", null)".

I'm think it should be "Dwarvish sniper"(*) instead of "hrif". Not sure, though.

(*) Or w/e the name of the unit is