WolfieeifloW
WEHZ Helper
- Reaction score
- 372
Hey there!, I have two questions today TH.net (Yay 
)!
My first, is to 'fix' this trigger I have.
I have a passive spell that has a chance on attacking to increase Strength by 15% for 5 seconds.
I've found one of my old spells, and re-learned timers (I think).
The Strength increase works great, but if the spell procs again, it just increases the hero's Strength further (30%).
Whereas I only want the heroes Strength to be able to increase a maximum of 15%.
How would I go about changing this to only allow a maximum of 15%?
I've thought of a few different ways, but I want to see what other people think.
I'd like a method that is easy (Coding wise, prefer not to add 100 variables or something), and efficient (Not as important).
Here's my code:
Also, for my second question.
I've only relearned structs/timers a bit ago, so I'm asking if someone can give me any pointers to optimize/fix my code up.
)!My first, is to 'fix' this trigger I have.
I have a passive spell that has a chance on attacking to increase Strength by 15% for 5 seconds.
I've found one of my old spells, and re-learned timers (I think
).The Strength increase works great, but if the spell procs again, it just increases the hero's Strength further (30%).
Whereas I only want the heroes Strength to be able to increase a maximum of 15%.
How would I go about changing this to only allow a maximum of 15%?
I've thought of a few different ways, but I want to see what other people think.
I'd like a method that is easy (Coding wise, prefer not to add 100 variables or something), and efficient (Not as important).
Here's my code:
JASS:
scope ROTFC initializer ROTFCInit
globals
private constant string rotfcString = "innerfire"
endglobals
private struct data
unit attacker
unit dummy
integer str
timer t
method onDestroy takes nothing returns nothing
call ReleaseTimer(.t)
endmethod
endstruct
private function Chance takes integer level returns integer
return 100//level * 1
endfunction
private function RemoveStr takes nothing returns nothing
local data d = GetTimerData(GetExpiredTimer())
call BJDebugMsg("Running!")
call SetHeroStr(d.attacker, d.str, true)
call d.destroy()
endfunction
private function Conditions takes nothing returns boolean
local data d = data.create()
set d.attacker = GetAttacker()
set d.str = GetHeroStr(d.attacker, true)
if (GetUnitAbilityLevel(d.attacker, rotfc) > 0 and GetRandomInt(0, 100) <= Chance(GetUnitAbilityLevel(d.attacker, rotfc))) then
call BJDebugMsg(I2S(R2I(d.str * 1.15)))
set d.dummy = CreateUnit(GetOwningPlayer(d.attacker), dummyID, GetUnitX(d.attacker), GetUnitY(d.attacker), bj_UNIT_FACING)
call UnitAddAbility(d.dummy, rotfcBuff)
call SetUnitAbilityLevel(d.dummy, rotfcBuff, 1)
call IssueTargetOrder(d.dummy, rotfcString, d.attacker)
call UnitApplyTimedLife(d.dummy, 'BTLF', 0.01)
call SetHeroStr(d.attacker, R2I(d.str * 1.15), false)
set d.t = NewTimer()
call SetTimerData(d.t, d)
call TimerStart(d.t, 5., false, function RemoveStr)
endif
return false
endfunction
private function ROTFCInit takes nothing returns nothing
local trigger t = CreateTrigger()
local integer index = 0
loop
call TriggerRegisterPlayerUnitEvent(t, Player(index), EVENT_PLAYER_UNIT_ATTACKED, null)
set index = index + 1
exitwhen index == bj_MAX_PLAYER_SLOTS
endloop
call TriggerAddCondition(t, Condition(function Conditions))
set t = null
endfunction
endscopeAlso, for my second question.
I've only relearned structs/timers a bit ago, so I'm asking if someone can give me any pointers to optimize/fix my code up.
