[Leaks] Did I fix them?

Kelv

Kelv

TH.net Regular
Reaction score
7
I'll post two triggers that I tried to fix their leaks.
Code: 
Spawn Top Ally
    Events
        Time - Every 20.00 seconds of game time
    Conditions
    Actions
        Wait 2.50 seconds
        Set Move_Loc = (Center of top boss sw <gen>)
        Unit - Create 1 boss_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Set Move_Loc = (Center of top melee sw 1 <gen>)
        Unit - Create 1 melee_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Set Move_Loc = (Center of top melee sw 2 <gen>)
        Unit - Create 1 melee_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Set Move_Loc = (Center of top melee sw 3 <gen>)
        Unit - Create 1 melee_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Set Move_Loc = (Center of top ranged sw 1 <gen>)
        Unit - Create 1 ranged_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Set Move_Loc = (Center of top ranged sw 2 <gen>)
        Unit - Create 1 ranged_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Set MoveGroup = (Units in top boss sw <gen> owned by Player 12 (Brown))
        Set Move_Loc = (Center of Top Ally 2 <gen>)
        Unit Group - Order MoveGroup to Attack-Move To (Center of Top Ally 2 <gen>)
        Wait 2.50 seconds
        Set MoveGroup = (Units in Top Ally <gen> owned by Player 12 (Brown))
        Unit Group - Order MoveGroup to Attack-Move To Move_Loc
        Custom script:   call DestroyGroup (udg_MoveGroup)
        Custom script:   call RemoveLocation (udg_Move_Loc)

and

Code: 
top ally
    Events
        Unit - A unit enters Top Ally 2 <gen>
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Owner of (Triggering unit)) Equal to Player 12 (Brown)
            Then - Actions
                Set Move_Loc = (Center of ally base <gen>)
                Unit - Order (Triggering unit) to Attack-Move To Move_Loc
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Owner of (Triggering unit)) Equal to Player 1 (Red)
                (Unit-type of (Triggering unit)) Not equal to Akama
            Then - Actions
                Set Move_Loc = (Center of Top Ally <gen>)
                Unit - Order (Triggering unit) to Attack-Move To Move_Loc
            Else - Actions
        Custom script:   call RemoveLocation (udg_Move_Loc)

Are there any leaks still there, and did I remove the leaks properly?
Another question, I have these triggers for top, middle, and bottom; can I use Move_Loc, and MoveGroup for each of the triggers, or do I need Move_Loc[1], Move_Loc[2] and so on?


I tried it and so far it seems like I dont need 3 of each but obviously, you cant have one trigger of each type, and it for every single trigger. Is the only factor of needing to triggers is if you use the two variables of the same type in a way in which that they are affected by each other?

example of what I mean that they are affected by each other.
this would not work unless you had two variables of type point
Code: 
set move loc 1 to Point 1
set move loc 2 to Point 2
order unit to move to Move_Loc 1 offset by 900 torwards Move_Loc 2
 
Sim

Sim

Forum Administrator
Staff member
Reaction score
534
> Are there any leaks still there, and did I remove the leaks properly?

There are, and quite a lot.

Before setting an handle variable (In your case, a point variable) to a new value you must first remove it. Removing it only at the end is not enough.

> Another question, I have these triggers for top, middle, and bottom; can I use Move_Loc, and MoveGroup for each of the triggers, or do I need Move_Loc[1], Move_Loc[2] and so on?

No you don't, unless there is a wait in your trigger.

The group is correctly removed in the first trigger because it is used only 1 time.
 
Kelv

Kelv

TH.net Regular
Reaction score
7
I have waits in the triggers, one at the beginning at and one near the end, do you mean there cant be a wait in between setting the variable and using the variable? If so, I might have a problem with Move_Loc because I have a wait before I use it a second time.

Also, I did set the unit group to two different groups, but I think I fixed what you told me to.
Code: 
Spawn Top Ally
    Events
        Time - Every 20.00 seconds of game time
    Conditions
    Actions
        Wait 2.50 seconds
        Set Move_Loc = (Center of top boss sw <gen>)
        Unit - Create 1 boss_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Custom script:   call RemoveLocation (udg_Move_Loc)
        Set Move_Loc = (Center of top melee sw 1 <gen>)
        Unit - Create 1 melee_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Custom script:   call RemoveLocation (udg_Move_Loc)
        Set Move_Loc = (Center of top melee sw 2 <gen>)
        Unit - Create 1 melee_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Custom script:   call RemoveLocation (udg_Move_Loc)
        Set Move_Loc = (Center of top melee sw 3 <gen>)
        Unit - Create 1 melee_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Custom script:   call RemoveLocation (udg_Move_Loc)
        Set Move_Loc = (Center of top ranged sw 1 <gen>)
        Unit - Create 1 ranged_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Custom script:   call RemoveLocation (udg_Move_Loc)
        Set Move_Loc = (Center of top ranged sw 2 <gen>)
        Unit - Create 1 ranged_var_ally for Player 12 (Brown) at Move_Loc facing 225.00 degrees
        Custom script:   call RemoveLocation (udg_Move_Loc)
        Set MoveGroup = (Units in top boss sw <gen> owned by Player 12 (Brown))
        Set Move_Loc = (Center of Top Ally 2 <gen>)
        Unit Group - Order MoveGroup to Attack-Move To Move_Loc
        Custom script:   call DestroyGroup (udg_MoveGroup)
        Wait 2.50 seconds
        Set MoveGroup = (Units in Top Ally <gen> owned by Player 12 (Brown))
        Unit Group - Order MoveGroup to Attack-Move To Move_Loc
        Custom script:   call DestroyGroup (udg_MoveGroup)
        Custom script:   call RemoveLocation (udg_Move_Loc)
 
Sim

Sim

Forum Administrator
Staff member
Reaction score
534
You did fix it.

> do you mean there cant be a wait in between setting the variable and using the variable?

Exactly, sorry if I confused you. :)
 
You must log in or register to reply here.
General chit-chat
Help Users
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage

      The Helper Discord

      Staff online

      Members online

      Online now:
      516 (members: 1, guests: 515)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top