Little problem with a variable

[Magoiche]

Well i made this simple jass trigger.
When a unit get the spell it do the defend animation tag, realy simple.

But i tried to do it in JASS but i got one error in the syntax cheker on JASScraft.

function Conditions takes nothing returns boolean
    if ( GetLearnedSkill() == 'A000' ) then
        return true
    endif
        return false
endfunction

function Actions takes nothing returns nothing
    call AddUnitAnimationProperties( GetTriggerUnit(), "defend", true )
endfunction

function Events takes nothing returns nothing
    set gg_trg_Events = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Events, EVENT_PLAYER_HERO_SKILL )
    call TriggerAddCondition( gg_trg_Events, Condition( function Conditions ) )
    call TriggerAddAction( gg_trg_Events, function Actions )
endfunction

The error is: Undeclared variable: gg_trg_Events Line 14

Whats wrong with that? Its the same if i convert a trigger from GUI to JASS but in the 2 cases it gave me this error. Why? T.T


Quick Questions:

1. call TriggerAddCondition and call TriggerAddAction what they do? I know it add condition and actions but... Its like the Events function will run the condition then if its true it will run the action? or something like that?

2. set gg_trg_Events = CreateTrigger(). What this line do? I know it create a trigger but... It can be in a variable? Maybe the cause of the error its because i dont have a global/local variable?

Thanks for now on =P

 

[Larcenist]

function Events takes nothing returns nothing

Change that into

function InitTrig_Events takes nothing returns nothing

> 1. call TriggerAddCondition and call TriggerAddAction what they do? I know it add condition and actions but... Its like the Events function will run the condition then if its true it will run the action? or something like that?

Pretty much yeah.

> 2. set gg_trg_Events = CreateTrigger(). What this line do? I know it create a trigger but... It can be in a variable? Maybe the cause of the error its because i dont have a global/local variable?

gg_trg_ is a global variable. Though when you code normally you usually find it easier to use "local trigger t = CreateTrigger()" since it doesn't require you to use the gg_trg_Trigger_Name variable but simply "t" instead.

 

[Magoiche]

That was.... Fast i.i

Thanks the error is gone but.

Some questions still are in the air x.x

The InitTrig_ indicates that this is the firts triggger to run?

And the trigger dont have error but it wont work i.i

function Conditions takes nothing returns boolean     
    if ( GetLearnedSkill() == 'A002' ) then
        return true
    else
        return false
    endif         
endfunction

function Actions takes nothing returns nothing
    call AddUnitAnimationProperties( GetTriggerUnit(), "defend", true )
endfunction

function InitTrig_Events takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_HERO_SKILL )
    call TriggerAddCondition( t, Condition( function Conditions ) )
    call TriggerAddAction( t, function Actions )
endfunction

Why? i.i

 

[Larcenist]

InitTrig_xxxx indicates that this is the init function of the trigger, in spells and such you add events, conditions and actions here as well as creating the trigger.

Try adding this:

call BJDebugMsg("Test")

In your actions function to see if it runs or not.

 

[Ryuu]

function Conditions takes nothing returns boolean     
    if ( GetLearnedSkill() == 'A002' ) then
        return true
    else
        return false
    endif         
endfunction

Isn't that supposed to be:

function Conditions takes nothing returns boolean     
    if ( GetLearnedSkill() == 'A002' ) then
        return false
    else
        return true
    endif         
endfunction

?

 

[Magoiche]

@Larcenist

It do not worked =X

@Ryuu

No. Because if the spell its the A002 it will run the trigger if not i will do nothing.

 

[T.s.e]

It's supposed to be this

return GetLearnedSkill() == 'A002'

 

[Troll-Brain]

If you use the official editor your InitFunction must be named like that :
InitTrig_TriggerName.

But, meh, if you are a windows user, just use the last JassNewGenPack ...

scope NewScope initializer init

private function Conditions takes nothing returns boolean
   // your conditions and return
endfunction

private function Actions takes nothing returns nothing
   // your stuff
endfunction

public function init takes nothing returns nothing
   local trigger trig = CreateTrigger()
   // register your event(s)
   call TriggerAddAction(trig,function Actions)
   call TriggerAddCondition(trig,Condition(function Conditions))
endfunction

endscope

If you need to set the trigger to a global you can put a global/englobals block in your scope.

 

[Magoiche]

@T.s.e

It do no worked i.i


@Troll-Brain

I use new gen. But i liked the Jasscraft i.i.
Anyway...

This is vJass right?
Let's see.

scope/endscope - don't know what this do.

private/public - private its a function only used in that trigger? public used on every? something like that?

global/endgloblas - what that thing do? its to set a global variable in the trigger?


EDIT:

I found the problem!
InitTrig_xxx!!! The xxx must be the name of the trigger x.x what a dumb i am xD.
Also i noticed that in vJass i dont have to put InitTrig_xxx because the scope say where to begin... right?

Anyway if someone can to explain the things above i apreciate it i.i

 

[WarLuvr3393]

Scopes are kind of like sections in your map script that don't necessarily get declared first like libraries; they're more like a section where the scripts/variables are independent from the rest of the script, or at least that's what I've seen.

Scopes are used mostly in spells because all you have to do is copy and paste it and because everything in those scripts have the "private" tag, you won't have to worry about re-declaring variables.

 

[Magoiche]

Let's see...

Scopes - Sections of indepent scripts/variables
Private - It means that i dont need to re-declare the variables in same scope? (Not sure)
Public - I don't have a clue i.i

 

[Troll-Brain]

Reading the jasshelper manual should help you.
It is in the folder jasshelper of your JNGP.

private : you can use it in the scope/library/struct and so one ..., but not outside the block code.
public : you can use it outside the bloc code.

I personnaly always use public for the initializer functions, in case of i need to manage the order of the differents inits.

 

[Magoiche]

The... Jass... helper?!?!?!?

I LOVED IT!

It will be a great help.

Thanks man! I will never foget that i.i