Looping Help

T

Tooters

Guest
I want some creeps to go attack the Castle after they enter a certain region. I have a loop that detects how many creeps are in the region, and when if that number should reach 0 then the gates close leading to the castle, but when they enter the area they attack the castle, and after I kill them all, the gates don't close. Here is my triggers:
Code: 
Castle Area Copy
    Events
        Unit - A unit enters Human Encampment <gen>
    Conditions
        (Owner of (Entering unit)) Equal to Player 12 (Brown)
    Actions
        Destructible - Open Gate (Horizontal) 0000 <gen>
        Destructible - Open Gate (Horizontal) 0001 <gen>
        Destructible - Open Gate (Horizontal) 0002 <gen>
        Destructible - Open Gate (Horizontal) 0003 <gen>
        Destructible - Open Gate (Horizontal) 0004 <gen>
        Trigger - Turn off Hero Death <gen>
        Trigger - Turn on Hero Death2 <gen>
        Custom script: call Loop_Function()
        Set attackCastle = False

Here is Loop_Function

Code: 
function Exit_When takes nothing returns boolean
    return ( udg_attackCastle == true )
endfunction

function Units_In_attackGroup takes nothing returns boolean
    if ( not ( CountUnitsInGroup(udg_attackGroup[0]) != 0 ) ) then
        return false
    endif
    return true
endfunction

function If_Statement takes nothing returns nothing
    if ( Units_In_attackGroup() ) then
    else
        set udg_attackCastle = true
        call DisableTrigger( gg_trg_Hero_Death2 )
        call EnableTrigger( gg_trg_Hero_Death )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0000 )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0001 )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0002 )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0003 )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0004 )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0000, true )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0001, true )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0002, true )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0003, true )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0004, true )
        call PauseTimerBJ( false, udg_creepTimer )
        call DestroyGroup(udg_attackGroup[0])
    endif
endfunction

function Loop_Function takes nothing returns nothing
    loop
    call PolledWait( 1.00 )
    set udg_attackGroup[0] = GetUnitsInRectOfPlayer(gg_rct_Human_Encampment, Player(11))
    exitwhen(Exit_When())
    call If_Statement()
    endloop
endfunction

Please help me figure this out.
 
phyrex1an

phyrex1an

Staff Member and irregular helper
Reaction score
447
No doubt about it, here is your problem ^^

Code: 
call ForGroupBJ( udg_attackGroup[0], function If_Statement )
Runs the function If_Statement once for each unit in the group.

Code: 
    if ( Units_In_attackGroup() ) then
    else
        set udg_attackCastle = true
        call DisableTrigger( gg_trg_Hero_Death2 )
        call EnableTrigger( gg_trg_Hero_Death )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0000 )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0001 )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0002 )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0003 )
        call ModifyGateBJ( bj_GATEOPERATION_CLOSE, gg_dest_LTg1_0004 )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0000, true )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0001, true )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0002, true )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0003, true )
        call SetDestructableInvulnerableBJ( gg_dest_LTg1_0004, true )
        call PauseTimerBJ( false, udg_creepTimer )
        call DestroyGroup(udg_attackGroup[0])
    endif

The else statement will only run if the group is empty, but if the group is empty then the function wont fun at all.

Just change
Code: 
call ForGroupBJ( udg_attackGroup[0], function If_Statement )
to
Code: 
call If_Statement()


I suggest that you read some tutorials on how to write more effective jass code, you can improve that code a lot.
 
T

Tooters

Guest
I did what you said but it still didn't work. :(

BTW: What's the difference between PolledWait, and TriggerSleepAction?
 
phyrex1an

phyrex1an

Staff Member and irregular helper
Reaction score
447
What is the initial vaule of udg_attackCastle? If it is true from the begining then you have to move the line
Code: 
Set attackCastle = False
one step up.

PolledWait uses a timer to keep track on the time remaining on the wait, thus it will pause the wait during lagg periods. But insteed it will last somewhat longer than expected.
I actualy suggest that you try to keep your functions as free from waits as possible, if you have to wait then use a timer.
 
T

Tooters

Guest
Well I changed PolledWait to TriggerSleepAction and it worked... o_O I already knew that it used a timer for PolledWait I just don't understand why it works with TriggerSleepAction and not PolledWait.

I use Waits so that the loop won't go off ever .01 seconds and lag the game.
 
T

Tooters

Guest
Well actually it still doesn't work. I just tested my map out again, and some units got spawned inside of the rect and I killed them and the gates did not close.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Staff online

      Members online

      Online now:
      364 (members: 2, guests: 362)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top