Merging 3 triggers into one

C

Charapanga

New Member
Reaction score
46
Hi!
I made a spell, with 3 triggers, then converted to jass, added some special effects, etc.
Well now i want to know how to make them fit into one trigger, if possible, i have been told to use countdown timers, but i have no idea how to impliment them into a code...
Here are the codes:
JASS:
function Trig_AirstrikeCast_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A01F' ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeCast_Actions takes nothing returns nothing
    set udg_AirCaster = GetTriggerUnit()
    set udg_AirCasterPos = GetUnitLoc(udg_AirCaster)
    set udg_AirTargetPoint = GetSpellTargetLoc()
    set udg_AirDummyPos = PolarProjectionBJ(udg_AirTargetPoint, 1000.00, AngleBetweenPoints(udg_AirTargetPoint, udg_AirCasterPos))
    set udg_AirMoveTarget = PolarProjectionBJ(udg_AirTargetPoint, 1000.00, AngleBetweenPoints(udg_AirCasterPos, udg_AirTargetPoint))
    call CreateNUnitsAtLocFacingLocBJ( 1, 'o005', GetOwningPlayer(udg_AirCaster), udg_AirDummyPos, udg_AirMoveTarget )
    set udg_AirDummy = GetLastCreatedUnit()
    call MoveRectToLoc( gg_rct_AirstrikeRegion, udg_AirMoveTarget )
endfunction

//===========================================================================
function InitTrig_AirstrikeCast takes nothing returns nothing
    set gg_trg_AirstrikeCast = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_AirstrikeCast, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_AirstrikeCast, Condition( function Trig_AirstrikeCast_Conditions ) )
    call TriggerAddAction( gg_trg_AirstrikeCast, function Trig_AirstrikeCast_Actions )
endfunction

JASS:
function Trig_AirstrikeMove_Conditions takes nothing returns boolean
    if ( not ( IsUnitAliveBJ(udg_AirDummy) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeMove_Func005C takes nothing returns boolean
    if ( not ( RectContainsUnit(gg_rct_AirstrikeRegion, udg_AirDummy) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeMove_Actions takes nothing returns nothing
    set udg_AirDummyPos = GetUnitLoc(udg_AirDummy)
    set udg_AirMovePoint = PolarProjectionBJ(udg_AirDummyPos, 5.00, AngleBetweenPoints(udg_AirTargetPoint, udg_AirMoveTarget))
    call SetUnitPositionLoc( udg_AirDummy, udg_AirMovePoint )
    if ( Trig_AirstrikeMove_Func005C() ) then
        call KillUnit( udg_AirDummy )
        call RemoveLocation(udg_AirCasterPos)
        call RemoveLocation(udg_AirMoveTarget)
        call RemoveLocation(udg_AirDummyPos)
        call RemoveLocation(udg_AirMovePoint)
        call RemoveLocation(udg_AirTargetPoint)
    else
    endif
endfunction

//===========================================================================
function InitTrig_AirstrikeMove takes nothing returns nothing
    set gg_trg_AirstrikeMove = CreateTrigger(  )
    call TriggerRegisterTimerEventPeriodic( gg_trg_AirstrikeMove, 0.02 )
    call TriggerAddCondition( gg_trg_AirstrikeMove, Condition( function Trig_AirstrikeMove_Conditions ) )
    call TriggerAddAction( gg_trg_AirstrikeMove, function Trig_AirstrikeMove_Actions )
endfunction

JASS:
function Trig_AirstrikeDropBomb_Conditions takes nothing returns boolean
    if ( not ( IsUnitAliveBJ(udg_AirDummy) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeDropBomb_Func008Func001C takes nothing returns boolean
    if ( not ( GetDestructableTypeId(GetEnumDestructable()) == 'NTtw' ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeDropBomb_Func008A takes nothing returns nothing
    if ( Trig_AirstrikeDropBomb_Func008Func001C() ) then
        call KillDestructable( GetEnumDestructable() )
    else
    endif
endfunction

function Trig_AirstrikeDropBomb_Actions takes nothing returns nothing
    call CreateNUnitsAtLoc( 1, 'h00I', GetOwningPlayer(udg_AirCaster), udg_AirDummyPos, bj_UNIT_FACING )
    call UnitAddAbilityBJ( 'A01E', GetLastCreatedUnit() )
    call UnitApplyTimedLifeBJ( 1.00, 'BTLF', GetLastCreatedUnit() )
    call IssuePointOrderLoc( GetLastCreatedUnit(), "clusterrockets", udg_AirMovePoint )
    call AddSpecialEffectLocBJ( udg_AirMovePoint, "Objects\\Spawnmodels\\Other\\NeutralBuildingExplosion\\NeutralBuildingExplosion.mdl" )
    call DestroyEffect( GetLastCreatedEffectBJ() )
    call EnumDestructablesInCircleBJ( 200.00, udg_AirMovePoint, function Trig_AirstrikeDropBomb_Func008A )
endfunction

//===========================================================================
function InitTrig_AirstrikeDropBomb takes nothing returns nothing
    set gg_trg_AirstrikeDropBomb = CreateTrigger(  )
    call TriggerRegisterTimerEventPeriodic( gg_trg_AirstrikeDropBomb, 1.00 )
    call TriggerAddCondition( gg_trg_AirstrikeDropBomb, Condition( function Trig_AirstrikeDropBomb_Conditions ) )
    call TriggerAddAction( gg_trg_AirstrikeDropBomb, function Trig_AirstrikeDropBomb_Actions )
endfunction
Thanx,
Chara
 
Romek

Romek

Super Moderator
Reaction score
964
Here:
JASS:
function Trig_AirstrikeCast_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A01F' ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeCast_Actions takes nothing returns nothing
    set udg_AirCaster = GetTriggerUnit()
    set udg_AirCasterPos = GetUnitLoc(udg_AirCaster)
    set udg_AirTargetPoint = GetSpellTargetLoc()
    set udg_AirDummyPos = PolarProjectionBJ(udg_AirTargetPoint, 1000.00, AngleBetweenPoints(udg_AirTargetPoint, udg_AirCasterPos))
    set udg_AirMoveTarget = PolarProjectionBJ(udg_AirTargetPoint, 1000.00, AngleBetweenPoints(udg_AirCasterPos, udg_AirTargetPoint))
    call CreateNUnitsAtLocFacingLocBJ( 1, 'o005', GetOwningPlayer(udg_AirCaster), udg_AirDummyPos, udg_AirMoveTarget )
    set udg_AirDummy = GetLastCreatedUnit()
    call MoveRectToLoc( gg_rct_AirstrikeRegion, udg_AirMoveTarget )
endfunction

function Trig_AirstrikeMove_Conditions takes nothing returns boolean
    if ( not ( IsUnitAliveBJ(udg_AirDummy) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeMove_Func005C takes nothing returns boolean
    if ( not ( RectContainsUnit(gg_rct_AirstrikeRegion, udg_AirDummy) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeMove_Actions takes nothing returns nothing
    set udg_AirDummyPos = GetUnitLoc(udg_AirDummy)
    set udg_AirMovePoint = PolarProjectionBJ(udg_AirDummyPos, 5.00, AngleBetweenPoints(udg_AirTargetPoint, udg_AirMoveTarget))
    call SetUnitPositionLoc( udg_AirDummy, udg_AirMovePoint )
    if ( Trig_AirstrikeMove_Func005C() ) then
        call KillUnit( udg_AirDummy )
        call RemoveLocation(udg_AirCasterPos)
        call RemoveLocation(udg_AirMoveTarget)
        call RemoveLocation(udg_AirDummyPos)
        call RemoveLocation(udg_AirMovePoint)
        call RemoveLocation(udg_AirTargetPoint)
    else
    endif
endfunction

function Trig_AirstrikeDropBomb_Conditions takes nothing returns boolean
    if ( not ( IsUnitAliveBJ(udg_AirDummy) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeDropBomb_Func008Func001C takes nothing returns boolean
    if ( not ( GetDestructableTypeId(GetEnumDestructable()) == 'NTtw' ) ) then
        return false
    endif
    return true
endfunction

function Trig_AirstrikeDropBomb_Func008A takes nothing returns nothing
    if ( Trig_AirstrikeDropBomb_Func008Func001C() ) then
        call KillDestructable( GetEnumDestructable() )
    else
    endif
endfunction

function Trig_AirstrikeDropBomb_Actions takes nothing returns nothing
    call CreateNUnitsAtLoc( 1, 'h00I', GetOwningPlayer(udg_AirCaster), udg_AirDummyPos, bj_UNIT_FACING )
    call UnitAddAbilityBJ( 'A01E', GetLastCreatedUnit() )
    call UnitApplyTimedLifeBJ( 1.00, 'BTLF', GetLastCreatedUnit() )
    call IssuePointOrderLoc( GetLastCreatedUnit(), "clusterrockets", udg_AirMovePoint )
    call AddSpecialEffectLocBJ( udg_AirMovePoint, "Objects\\Spawnmodels\\Other\\NeutralBuildingExplosion\\NeutralBuildingExplosion.mdl" )
    call DestroyEffect( GetLastCreatedEffectBJ() )
    call EnumDestructablesInCircleBJ( 200.00, udg_AirMovePoint, function Trig_AirstrikeDropBomb_Func008A )
endfunction

//===========================================================================
//===========================================================================
function InitTrig_CombinedTrigger takes nothing returns nothing // Change the "CombinedTrigger" to the name of the trigger in the WE.
//===========================================================================
    local trigger t = CreateTrigger()
    call TriggerRegisterTimerEventPeriodic( t, 1.00 )
    call TriggerAddCondition( t, Condition( function Trig_AirstrikeDropBomb_Conditions ) )
    call TriggerAddAction( t, function Trig_AirstrikeDropBomb_Actions )
    
    set t = CreateTrigger()
    call TriggerRegisterTimerEventPeriodic( t, 0.02 )
    call TriggerAddCondition( t, Condition( function Trig_AirstrikeMove_Conditions ) )
    call TriggerAddAction( t, function Trig_AirstrikeMove_Actions )
    
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( t, Condition( function Trig_AirstrikeCast_Conditions ) )
    call TriggerAddAction( t, function Trig_AirstrikeCast_Actions )
endfunction


Change the:
Code: 
function InitTrig_>> CombinedTrigger << takes nothing returns nothing
To the name of the trigger in the WE. (I put loads of comments around the line :))

Alternatively, you could use initializers if you have Newgen.
 
C

Charapanga

New Member
Reaction score
46
Thanx romek!
I thought calling other functions would work, though wasnt sure about the multiple events...
 
Romek

Romek

Super Moderator
Reaction score
964
Charapanga said:
Thanx romek!
I thought calling other functions would work, though wasnt sure about the multiple events...
Click to expand...
As long as you merge the Init functions, the rest will be fine. Just put the functions into 1 script. :)
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      88 (members: 0, guests: 88)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top