Quick Jass Question

[GooseBoy]

function GroupConditions1 takes nothing returns boolean
    if (IsUnitAlly(GetFilterUnit(),GetOwningPlayer(udg_Shadow_Hero) == true) then
        if(IsUnitIdType(GetUnitTypeId(GetFilterUnit()), UNIT_TYPE_HERO) == true) then
            if(GetUnitCurrentOrder(GetFilterUnit()) != String2OrderIdBJ("attack")) == true) then
                return true
            endif
        endif
    endif
    return false
endfunction

I want to pick all heroes that are not attacking and are allies of Shadow Hero. I wanted to ask if there is a better way of doing this?

 

[Flare]

return IsUnitAlly(GetFilterUnit(),GetOwningPlayer(udg_Shadow_Hero)) and IsUnitType (GetFilterUnit (), UNIT_TYPE_HERO == true and GetUnitCurrentOrder(GetFilterUnit()) != String2OrderIdBJ(&quot;attack&quot;) //I don&#039;t know the native alternative to the String2OrderIdBJ, so I can&#039;t replace it for you <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue    :p" loading="lazy" data-shortname=":p" />

 

[chobibo]

call OrderId("attack")

 

[GooseBoy]

but, i wanna know if my code is valid, i want to do it in a way so that i dont need to keep scrolling to the right on the Jass editor if i need to fix something, lol.

 

[Trollvottel]

if(IsUnitIdType(GetUnitTypeId(GetFilterUnit()), UNIT_TYPE_HERO) == true) then

can be shortened into:

if IsUnitType(GetFilterUnit(), UNIT_TYPE_HERO) == true then

 

[TheDamien]

IIRC you don't need the "== true" for UNIT_TYPE_HERO comparisons.

 

[Trollvottel]

I dont know, but normally you need it for IsUnitType and IMO its safer like this.

 

[GooseBoy]

EDIT: Nevermind, i solved it. Keep discussing please, lol.

 

[Strilanc]

I dont know, but normally you need it for IsUnitType and IMO its safer like this.

You only need it if you're returning the value from a function being used as a boolexpr. "IF" statements will work correctly.