Revive trigger not working

C

Charapanga

New Member
Reaction score
46
I'm trying to make a Slide ninja slide - like revive trigger...but it doesn't work...
the Unit/player variables are globals set in the init trigger..

JASS:
scope Revive initializer Init

private function FGg takes nothing returns nothing
    local unit u = GetEnumUnit()
    local player p = GetOwningPlayer(u)
    local location l = GetUnitLoc(u)
    local real x = GetLocationX(l)
    local real y = GetLocationY(l)
    local real face = GetUnitFacing(u)
    if p == Red then
    call ReviveHero(HeroRed, x, y, true)
    call SetUnitFacing(HeroRed, face)
    elseif p == Blue then
    call ReviveHero(HeroBlue, x, y, true)
    call SetUnitFacing(HeroBlue, face)
    elseif p == Teal then
    call ReviveHero(HeroTeal, x, y, true)
    call SetUnitFacing(HeroTeal, face)
    elseif p == Purple then
    call ReviveHero(HeroPurple, x, y, true)
    call SetUnitFacing(HeroPurple, face)
    elseif p == Yellow then
    call ReviveHero(HeroYellow, x, y, true)
    call SetUnitFacing(HeroYellow, face)
    elseif p == Orange then
    call ReviveHero(HeroOrange, x, y, true)
    call SetUnitFacing(HeroOrange, face)
    elseif p == Green then 
    call ReviveHero(HeroGreen, x, y, true)
    call SetUnitFacing(HeroGreen, face)
    elseif p == Pink then
    call ReviveHero(HeroPink, x, y, true)
    call SetUnitFacing(HeroPink, face)
    elseif p == Grey then
    call ReviveHero(HeroGrey, x, y, true)
    call SetUnitFacing(HeroGrey, face)
    endif 
    set u = null
    call RemoveLocation(l)
    set l = null
endfunction

private function Matching takes nothing returns boolean
    return GetUnitTypeId(GetFilterUnit()) == 'hfoo'
endfunction    

private function Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local location l = GetUnitLoc(u)
    local real x = GetLocationX(l)
    local real y = GetLocationY(l)
    local group g = CreateGroup()
    call GroupEnumUnitsInRange(g, x, y, 32, Filter(function Matching))
    call ForGroup(g, function FGg)
    call RemoveLocation(l)
    set l = null
    set u = null
    call DestroyGroup(g)
    set g = null
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    set gg_trg_Revive = CreateTrigger(  )
    call TriggerAddAction( gg_trg_Revive, function Actions )
endfunction

endscope

JASS:
scope Replacer initializer DM

private function Trig_Death_Marker_Conditions takes nothing returns boolean
    return GetUnitTypeId(GetTriggerUnit()) == 'HERO'
endfunction

private function Trig_Death_Marker_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local location l = GetUnitLoc(u)
    call CreateNUnitsAtLoc( 1, 'hfoo', GetOwningPlayer(u), l, GetRandomReal(1, 360))
    call TriggerRegisterUnitInRange(gg_trg_Revive, bj_lastCreatedUnit, 32, CondTrue)
    call RemoveLocation(l)
    set l = null
    set u = null
endfunction

//===========================================================================
private function DM takes nothing returns nothing
    local integer index
    local trigger t
    set index = 0
    set t = CreateTrigger(  )
    loop
        call TriggerRegisterPlayerUnitEvent(t, Player(index), EVENT_PLAYER_UNIT_DEATH, CondTrue)
        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
    call TriggerAddCondition( t, Condition( function Trig_Death_Marker_Conditions ) )
    call TriggerAddAction( t, function Trig_Death_Marker_Actions )
endfunction

endscope
 
T

TriggerHappy

...
Reaction score
341
Please learn to use arrays. Set all the players heroes in an array corresponding with their GetPlayerId(). so then you could just do...

JASS:
scope Revive initializer Init

private function FGg takes nothing returns nothing
    local unit u = GetEnumUnit()
    local player p = GetOwningPlayer(u)
    local location l = GetUnitLoc(u)
    local real x = GetLocationX(l)
    local real y = GetLocationY(l)
    local real face = GetUnitFacing(u)
    call ReviveHero(Hero[GetPlayerId(p)], x, y, true)
    call SetUnitFacing(Hero[GetPlayerId(p)], face)
    set u = null
    call RemoveLocation(l)
    set l = null
endfunction

private function Matching takes nothing returns boolean
    return GetUnitTypeId(GetFilterUnit()) == 'hfoo'
endfunction    

private function Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local location l = GetUnitLoc(u)
    local real x = GetLocationX(l)
    local real y = GetLocationY(l)
    local group g = CreateGroup()
    call GroupEnumUnitsInRange(g, x, y, 32, Filter(function Matching))
    call ForGroup(g, function FGg)
    call RemoveLocation(l)
    set l = null
    set u = null
    call DestroyGroup(g)
    set g = null
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    set gg_trg_Revive = CreateTrigger(  )
    call TriggerAddAction( gg_trg_Revive, function Actions )
endfunction

endscope


And your trigger isn't working because you have no event.
 
~GaLs~

~GaLs~

† Ғσſ ŧħə ѕαĸε Φƒ ~Ğ䣚~ †
Reaction score
180
>>
JASS:
private function DM takes nothing returns nothing
    local integer index
    local trigger t
    set index = 0
    set t = CreateTrigger(  )
    loop
        call TriggerRegisterPlayerUnitEvent(t, Player(index), EVENT_PLAYER_UNIT_DEATH, CondTrue)
        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
    call TriggerAddCondition( t, Condition( function Trig_Death_Marker_Conditions ) )
    call TriggerAddAction( t, function Trig_Death_Marker_Actions )
endfunction

Why? Why mess up your initializer function?
Those messy things can be inlined up by 1 BJ function:
function TriggerRegisterAnyUnitEventBJ takes trigger trig, playerunitevent whichEvent returns nothing

*BJs' are bad, when they just inline 1 function in it.
In this case, this BJ are GOOD

Well, the code is quite messy, as I can't do much help as I don't familiar on how the code should go.

Here's an advise, make good use of the function BJDebugMsg and debug your code.
Use it to determind which part of the code is stucked and debug.
 
Trollvottel

Trollvottel

never aging title
Reaction score
262
~GaLs~ said:
>>

Why? Why mess up your initializer function?
Those messy things can be inlined up by 1 BJ function:
function TriggerRegisterAnyUnitEventBJ takes trigger trig, playerunitevent whichEvent returns nothing

*BJs' are bad, when they just inline 1 function in it.
In this case, this BJ are GOOD
Click to expand...

In this case, the BJ leaks ;)
 
G

Gwypaas

hook DoNothing MakeGUIUsersCrash
Reaction score
50
The leak is not noticible since the event only runs once :p

But dynamicly using TriggerRegisterAnyUnitEventBJ is pure suicide.
 
~GaLs~

~GaLs~

† Ғσſ ŧħə ѕαĸε Φƒ ~Ğ䣚~ †
Reaction score
180
>>the BJ leaks
>>The leak is not noticible since the event only runs once

Thanks to Troll-Brain. +rep

*There are quite some BJs we can savely use.
Only exclude those which contain only 1 line of function calling in it... ;)
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      136 (members: 1, guests: 135)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top