Simple yet complicated revive trigger

xAnaMorphine

Active Member
Reaction score
43
Hi, folks!

Code:
Create Grave
    Events
        Unit - A unit Dies
    Conditions
        ((Dying unit) is A Hero) Equal to True
    Actions
        Set TEMP_Point = (Position of (Dying unit))
        Set UnitPosition[(Player number of (Owner of (Triggering unit)))] = TEMP_Point
        Set GraveLocation[(Player number of (Owner of (Triggering unit)))] = UnitPosition[(Player number of (Owner of (Triggering unit)))]
        Set Revive[(Player number of (Owner of (Triggering unit)))] = (Dying unit)
        Set ReviveLocation[(Player number of (Owner of (Triggering unit)))] = GraveLocation[(Player number of (Owner of (Triggering unit)))]
        Unit - Create 1 Grave for (Owner of (Triggering unit)) at ReviveLocation[(Player number of (Owner of (Triggering unit)))] facing Default building facing degrees
        Custom script:   call RemoveLocation(udg_TEMP_Point)
Code:
Revive Unit
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Revive 
    Actions
        Hero - Instantly revive Revive[(Player number of (Owner of (Target unit of ability being cast)))] at GraveLocation[(Player number of (Owner of (Triggering unit)))], Hide revival graphics
        Set ReviveGrave = (Units owned by (Owner of (Target unit of ability being cast)) of type Grave)
        Set ReviveUnitGroup[(Player number of (Owner of (Target unit of ability being cast)))] = ReviveGrave
        Unit Group - Pick every unit in ReviveUnitGroup[(Player number of (Owner of (Target unit of ability being cast)))] and do (Actions)
            Loop - Actions
                Unit - Remove (Picked unit) from the game
        Custom script:   call RemoveLocation(udg_ReviveLocation[GetConvertedPlayerId(GetTriggerPlayer())])
        Custom script:   call DestroyGroup(udg_ReviveUnitGroup[GetConvertedPlayerId(GetOwningPlayer(GetSpellTargetUnit()))])
        Custom script:   call DestroyGroup(udg_ReviveGrave)
        Custom script:   call RemoveLocation(udg_GraveLocation[GetConvertedPlayerId(GetOwningPlayer(GetDyingUnit()))])
        Custom script:   call RemoveLocation(udg_UnitPosition[GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))])

The unit does not get revived at the grave location and does the code look somehow ok?
 

Dirac

22710180
Reaction score
147
happens in GUI triggering that when you
set PointA = PointB
it bugs the hell up, and PointA is set to null, in order to fix this do this
set PointA = PointB offset by 0 towards 0 degrees.

Also (Target Unit of Ability Being Cast) is an unit? isnt your spell AoE, if not, how do you target a corpse?

And you create many unnecessary variables such as ReviveGrave, UnitPosition[array] and GraveLocation[array]
 

xAnaMorphine

Active Member
Reaction score
43
My Spell is based of channel, which I changed to a point-target spell and the grave is a unit, indeed.
I create many unnecessary variables because I thought they were needed to make the trigger MUI.
 

Dirac

22710180
Reaction score
147
this trigger is not MUI, it's MPI though (which means that works fine for each player)
Ok now i see, the second ability targets the grave and revives the hero right there, making every variable useless but the one that sets the Hero unit... i'll just rewrite your trigger roughly here.

Trigger:
  • Create Grave
    • Events
      • Unit - A unit Dies
    • Conditions
      • ((Dying unit) is A Hero) Equal to True
    • Actions
      • Set TEMP_Point = (Position of (Dying unit))
      • Unit - Create 1 Grave for (Owner of (Triggering unit)) at ReviveLocation[(Player number of (Owner of (Triggering unit)))] facing Default building facing degrees
      • Set Revive = (Dying unit)
      • Custom script: call RemoveLocation(udg_TEMP_Point)


Trigger:
  • Revive Unit
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to Revive
    • Actions
      • Set TEMP_Point = (Position of (Target unit of ability being cast))
      • Hero - Instantly revive Revive[(Player number of (Owner of (Target unit of ability being cast)))] at TEMP_Point, Hide revival graphics
      • Remove (Target unit of ability being cast) from the game
      • Custom script: call RemoveLocation(udg_TEMP_Point)
 

xAnaMorphine

Active Member
Reaction score
43
Tweaked the code, works how intended.
If anyone is intrested:

Erstelle Grabstein
Events
Unit - A unit Dies
Conditions
((Dying unit) is A Hero) Equal to True
Actions
Set TEMP_Point = (Position of (Dying unit))
Set Revive[(Player number of (Owner of (Triggering unit)))] = (Dying unit)
Set ReviveLocation[(Player number of (Owner of (Triggering unit)))] = TEMP_Point
Unit - Create 1 Grave for (Owner of (Triggering unit)) at ReviveLocation[(Player number of (Owner of (Triggering unit)))] facing Default building facing degrees
Custom script: call RemoveLocation(udg_TEMP_Point)

Wiederbeleben
Events
Unit - A unit Starts the effect of an ability
Conditions
(Ability being cast) Equal to Revive
Actions
Set TEMP_Point = (Position of (Target unit of ability being cast))
Hero - Instantly revive Revive[(Player number of (Owner of (Target unit of ability being cast)))] at TEMP_Point, Hide revival graphics
Set ReviveGrave = (Units owned by (Owner of (Target unit of ability being cast)) of type Grave)
Set ReviveUnitGroup[(Player number of (Owner of (Target unit of ability being cast)))] = ReviveGrave
Unit Group - Pick every unit in ReviveUnitGroup[(Player number of (Owner of (Target unit of ability being cast)))] and do (Actions)
Loop - Actions
Unit - Remove (Picked unit) from the game
Custom script: call RemoveLocation(udg_ReviveLocation[GetConvertedPlayerId(GetTriggerPlayer())])
Custom script: call DestroyGroup(udg_ReviveGrave)
Custom script: call DestroyGroup(udg_ReviveUnitGroup[GetConvertedPlayerId(GetOwningPlayer(GetSpellTargetUnit()))])
Custom script: call RemoveLocation(udg_TEMP_Point)
 

Dirac

22710180
Reaction score
147
My trigger does the exact thing as yours without the 7 location variables, it should works just fine
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top