Some jass questions

K

Kazuga

Let the game begin...
Reaction score
110
Ok so I ran into some strange problems (to me anyway) when coding the last part of my spell.

First of all, I get the strange error that says "data is not of a type that allows .syntax" and the normal "syntax error"
JASS:
private function Effect takes nothing returns nothing
local real x
local real y
local real real1
set real x = data.x + 300 * Cos((real1+45)*bj_DEGTORAD) //Syntax error
set real y = data.y + 300 * Sin((real1+45)*bj_DEGTORAD) //Syntax error

    call TriggerSleepAction (1.00)
    call BJDebugMsg("works")
    call PauseUnit (data.target,false)      //data is not of a type that allows .syntax
    call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",data.tx,data.ty)  //data is not of a type that allows .syntax
endfunction

Also don't you call a function like this?
JASS:
    call Effect


Whole code
JASS:
library HAILInit requires HAIL
//! runtextmacro HAIL_CreateProperty ("Data", "integer", "")
endlibrary
scope Lightnings initializer Lightning
globals
private constant integer raw = 'AHtb'
endglobals
private struct TestStruct
unit dummy
unit caster
unit target
real tx
real ty
timer SlideTimer
endstruct

private function Conditions takes nothing returns boolean
return GetSpellAbilityId() == raw
endfunction

private function Effect takes nothing returns nothing
local real x
local real y
set real x = data.x + 300 * Cos((real1+45)*bj_DEGTORAD)
set real y = data.y + 300 * Sin((real1+45)*bj_DEGTORAD)

call TriggerSleepAction (1.00)
call BJDebugMsg("works")
//call PauseUnit (data.target,false)
//call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",data.tx,data.ty)
endfunction

private function Slide takes nothing returns nothing
local TestStruct data = GetData (GetExpiredTimer ())
local real x = GetUnitX(data.dummy)
local real y = GetUnitY(data.dummy)
local real newX
local real newY
local real angle
local real distance
local real real1=45
local real x2 
local real y2 



set data.tx    = GetUnitX(data.target)
set data.ty    = GetUnitY(data.target)
set angle = Atan2(data.ty-y,data.tx-x)
set newX  = x + 30 *Cos(angle)
set newY  = y + 30 *Sin(angle)

call SetUnitPosition(data.dummy,newX,newY)
set distance=SquareRoot( (data.tx-x)*(data.tx-x) + (data.ty-y)*(data.ty-y) )
if distance < 50 then
    call BJDebugMsg ("If works")
    call PauseTimer (data.SlideTimer)
    call data.destroy ()
    call ResetData (data.SlideTimer)
    call DestroyTimer (data.SlideTimer)
    call PauseUnit (data.target,true)
    call Effect
endif
endfunction


private function Actions takes nothing returns nothing
local TestStruct data = TestStruct.create ()
local unit Unit                    = GetTriggerUnit()
local real real1                   = GetUnitFacing(GetTriggerUnit())

local real x = GetUnitX(GetTriggerUnit())
local real y = GetUnitY(GetTriggerUnit())

local real x2 = x + 300 * Cos((real1+145)*bj_DEGTORAD)
local real y2 = y + 300 * Sin((real1+145)*bj_DEGTORAD)

local real x3 = x + 300 * Cos((real1+180)*bj_DEGTORAD)
local real y3 = y + 300 * Sin((real1+180)*bj_DEGTORAD)

local real x4 = x + 300 * Cos((real1+215)*bj_DEGTORAD)
local real y4 = y + 300 * Sin((real1+215)*bj_DEGTORAD)

set data.SlideTimer = CreateTimer()
set data.target = (GetSpellTargetUnit())

call TriggerSleepAction (0.1)
call AddSpecialEffect("Abilities\\Weapons\\Bolt\\BoltImpact.mdl",x2,y2)
call AddSpecialEffect("Abilities\\Weapons\\Bolt\\BoltImpact.mdl",x3,y3)
call AddSpecialEffect("Abilities\\Weapons\\Bolt\\BoltImpact.mdl",x4,y4)
call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",x,y)
call PauseUnit (Unit, true)

call TimedLightning ("CLPB", x, y, 0, x2, y2, 0, 2., true, 1, 0)
call TimedLightning ("CLPB", x, y, 0, x3, y3, 0, 2., true, 1, 0)
call TimedLightning ("CLPB", x, y, 0, x4, y4, 0, 2., true, 1, 0)



call TriggerSleepAction (1)
set data.dummy = CreateUnit (GetOwningPlayer(Unit),'h000',x,y,0)
call SetUnitPathing(data.dummy, false )
call PauseUnit (Unit, false)
call TimerStart (data.SlideTimer,0.1,true, function Slide)
call SetData (data.SlideTimer, data)
set Unit = null

endfunction


//===========================================================================

private function SafeFilt takes nothing returns boolean
return true
endfunction
private function Lightning takes nothing returns nothing
 local trigger trig = CreateTrigger()
local integer i = 0
loop
    exitwhen i > 15
    call TriggerRegisterPlayerUnitEvent(trig,Player(i),EVENT_PLAYER_UNIT_SPELL_EFFECT,Condition(function SafeFilt))
    set i = i + 1
endloop
 call TriggerAddCondition (trig, Condition (function Conditions ) )
 call TriggerAddAction (trig, function Actions )
 set trig = null
 endfunction

endscope
 
Prometheus

Prometheus

Everything is mutable; nothing is sacred
Reaction score
590
Elaborating on 2.
JASS:
call Effect()

if the function of effect goes like....
JASS:
function Effect takes string a returns nothing

then you would do
JASS:
call Effect(MyString)
 
K

Kazuga

Let the game begin...
Reaction score
110
1: How exactly do I declare it?
JASS:
local TestStruct data = TestStruct.create ()

Is used in the Actions function but it didn't work in this one, also
JASS:
local TestStruct data = GetData (GetExpiredTimer ())

is for a timer..

2: Ok thanks both of you^^^^
 
Larcenist

Larcenist

REP: Respect, Envy, Prosperity?
Reaction score
211
How about changing the function so that it takes x and y as arguments?

JASS:
private function Effect takes real myX, real myY, unit Target returns nothing
    local real x
    local real y
    local real real1 //You never declared this one
    set x = myX + 300 * Cos((real1+45)*bj_DEGTORAD)    //myX is one of the arguments taken
    set y = myY + 300 * Sin((real1+45)*bj_DEGTORAD)    //myY is one of the arguments taken

    call TriggerSleepAction (1.00)
    call BJDebugMsg("works")
    call PauseUnit (Target,false)    //Target is one of the arguments taken
    call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",data.tx,data.ty)  
endfunction


Then you call it like this:

JASS:
call Effect(data.x, data.y, data.target)
 
K

Kazuga

Let the game begin...
Reaction score
110
Hm still some strange errors and buggs,
JASS:
private function Effect takes real myX, real myY, unit Target returns nothing
    local real x
    local real y
    local real real1 = 0
    set x = myX + 300 * Cos((real1+45)*bj_DEGTORAD) 
    set y = myY + 300 * Sin((real1+45)*bj_DEGTORAD)  

    call TriggerSleepAction (1.00) //None of these actions is executed =/
    call BJDebugMsg("works")
    call PauseUnit (Target,false)    
    call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",data.tx,data.ty)  
    //error "data is not of type that allows .syntax"
endfunction
 
PurgeandFire

PurgeandFire

zxcvmkgdfg
Reaction score
509
You ALWAYS have to declare the struct in the function UNLESS it is a regular method. ;)

If it is a regular function, just use "local structname Name = structname.create()".

If it is a static method, you would use "local structname Name = structname.allocate()".

If it is a callback or trigger callback etc., you would use "local structname Name = RetrievingFunction(ObjectAttachedTo)" or however the attachment system works.

If it is a regular method, you don't have to declare it, you can just use a single "." such as ".u" or ".i" or you can use a different thing such as "this.u" or "this.i".
 
K

Kazuga

Let the game begin...
Reaction score
110
Darn this is complicated just to call a simple function :eek:
Shoudn't this work?.. Or is it some other type of function?
JASS:
private function Effect takes real myX, real myY, unit Target returns nothing
    local TestStruct data = TestStruct.create ()
    local real x
    local real y
    local real real1 = 0
    set x = myX + 300 * Cos((real1+45)*bj_DEGTORAD)
    set y = myY + 300 * Sin((real1+45)*bj_DEGTORAD)

    call TriggerSleepAction (1.00)
    call BJDebugMsg("works")
    call PauseUnit (Target,false)
    call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",data.tx,data.ty)  
endfunction
 
Larcenist

Larcenist

REP: Respect, Envy, Prosperity?
Reaction score
211
JASS:
    call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",data.tx,data.ty)


There are two struct members in that line, data.tx and data.ty. Include these in the arguments and you should be good to go.
 
K

Kazuga

Let the game begin...
Reaction score
110
JASS:
private function Effect takes real myX, real myY, unit Target returns nothing
    local TestStruct data = TestStruct.create ()
    local real x
    local real y
    local real real1 = 0
    set x = myX + 300 * Cos((real1+45)*bj_DEGTORAD)
    set y = myY + 300 * Sin((real1+45)*bj_DEGTORAD)

    call TriggerSleepAction (1.00)
    call BJDebugMsg("works")
    call PauseUnit (Target,false)
    call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",data.tx,data.ty)  
endfunction

JASS:
call Effect(data.tx, data.ty, data.target,data.tx,data.ty)

JASS:
private function Slide takes nothing returns nothing
local TestStruct data = GetData (GetExpiredTimer ())
local real x = GetUnitX(data.dummy)
local real y = GetUnitY(data.dummy)
local real newX
local real newY
local real angle
local real distance
local real real1=45
local real x2 
local real y2 



set data.tx    = GetUnitX(data.target)
set data.ty    = GetUnitY(data.target)
set angle = Atan2(data.ty-y,data.tx-x)
set newX  = x + 30 *Cos(angle)
set newY  = y + 30 *Sin(angle)

call SetUnitPosition(data.dummy,newX,newY)
//call AddSpecialEffect("Abilities\\Weapons\\Bolt\\BoltImpact.mdl",newX,newY)
set distance=SquareRoot( (data.tx-x)*(data.tx-x) + (data.ty-y)*(data.ty-y) )
if distance < 50 then
    call BJDebugMsg ("If works")
    call PauseTimer (data.SlideTimer)
    call data.destroy ()
    call ResetData (data.SlideTimer)
    call DestroyTimer (data.SlideTimer)
    call PauseUnit (data.target,true)
call Effect(data.tx, data.ty, data.target,data.tx,data.ty)

endif
endfunction
 
PurgeandFire

PurgeandFire

zxcvmkgdfg
Reaction score
509
Why do you put data.tx and ty twice?

JASS:
call Effect(data.tx, data.ty, data.target)


There you go. :D
 
Larcenist

Larcenist

REP: Respect, Envy, Prosperity?
Reaction score
211
Change this:

JASS:
    call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",data.tx,data.ty)


To this:
JASS:

    call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",myX,myY)
 
K

Kazuga

Let the game begin...
Reaction score
110
1: Wops dunno why I did that^^
2: Hm the function still isn't executed... Still I get no errors :S I can test the map but the function isn't called...
 
K

Kazuga

Let the game begin...
Reaction score
110
JASS:
library HAILInit requires HAIL
//! runtextmacro HAIL_CreateProperty ("Data", "integer", "")
endlibrary
scope Lightnings initializer Lightning
globals
private constant integer raw = 'AHtb'
endglobals
private struct TestStruct
unit dummy
unit caster
unit target
real tx
real ty
timer SlideTimer
endstruct

private function Conditions takes nothing returns boolean
return GetSpellAbilityId() == raw
endfunction

private function Effect takes real myX, real myY, unit Target returns nothing
    local TestStruct data = TestStruct.create ()
    local real x
    local real y
    local real real1 = 0
    set x = myX + 300 * Cos((real1+45)*bj_DEGTORAD)
    set y = myY + 300 * Sin((real1+45)*bj_DEGTORAD)

    call TriggerSleepAction (1.00)
    call BJDebugMsg("works")
    call PauseUnit (Target,false)
    call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",myX,myY)  
endfunction



private function Slide takes nothing returns nothing
local TestStruct data = GetData (GetExpiredTimer ())
local real x = GetUnitX(data.dummy)
local real y = GetUnitY(data.dummy)
local real newX
local real newY
local real angle
local real distance
local real real1=45
local real x2 
local real y2 



set data.tx    = GetUnitX(data.target)
set data.ty    = GetUnitY(data.target)
set angle = Atan2(data.ty-y,data.tx-x)
set newX  = x + 30 *Cos(angle)
set newY  = y + 30 *Sin(angle)

call SetUnitPosition(data.dummy,newX,newY)
call AddSpecialEffect("Abilities\\Weapons\\Bolt\\BoltImpact.mdl",newX,newY)
set distance=SquareRoot( (data.tx-x)*(data.tx-x) + (data.ty-y)*(data.ty-y) )
if distance < 50 then
    call BJDebugMsg ("If works")
    call PauseTimer (data.SlideTimer)
    call data.destroy ()
    call ResetData (data.SlideTimer)
    call DestroyTimer (data.SlideTimer)
    call PauseUnit (data.target,true)
    call Effect(data.tx, data.ty, data.target)

endif
endfunction


private function Actions takes nothing returns nothing
local TestStruct data = TestStruct.create ()
local unit Unit                    = GetTriggerUnit()
local real real1                   = GetUnitFacing(GetTriggerUnit())

local real x = GetUnitX(GetTriggerUnit())
local real y = GetUnitY(GetTriggerUnit())

local real x2 = x + 300 * Cos((real1+145)*bj_DEGTORAD)
local real y2 = y + 300 * Sin((real1+145)*bj_DEGTORAD)

local real x3 = x + 300 * Cos((real1+180)*bj_DEGTORAD)
local real y3 = y + 300 * Sin((real1+180)*bj_DEGTORAD)

local real x4 = x + 300 * Cos((real1+215)*bj_DEGTORAD)
local real y4 = y + 300 * Sin((real1+215)*bj_DEGTORAD)

set data.SlideTimer = CreateTimer()
set data.target = (GetSpellTargetUnit())

call TriggerSleepAction (0.1)
call AddSpecialEffect("Abilities\\Weapons\\Bolt\\BoltImpact.mdl",x2,y2)
call AddSpecialEffect("Abilities\\Weapons\\Bolt\\BoltImpact.mdl",x3,y3)
call AddSpecialEffect("Abilities\\Weapons\\Bolt\\BoltImpact.mdl",x4,y4)
call AddSpecialEffect("Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl",x,y)
call PauseUnit (Unit, true)

call TimedLightning ("CLPB", x, y, 0, x2, y2, 0, 2., true, 1, 0)
call TimedLightning ("CLPB", x, y, 0, x3, y3, 0, 2., true, 1, 0)
call TimedLightning ("CLPB", x, y, 0, x4, y4, 0, 2., true, 1, 0)


call TriggerSleepAction (1)
set data.dummy = CreateUnit (GetOwningPlayer(Unit),'h000',x,y,0)
call SetUnitPathing(data.dummy, false )
call PauseUnit (Unit, false)
call TimerStart (data.SlideTimer,0.05,true, function Slide)
call SetData (data.SlideTimer, data)
set Unit = null

endfunction


//===========================================================================

private function SafeFilt takes nothing returns boolean
return true
endfunction
private function Lightning takes nothing returns nothing
 local trigger trig = CreateTrigger()
local integer i = 0
loop
    exitwhen i > 15
    call TriggerRegisterPlayerUnitEvent(trig,Player(i),EVENT_PLAYER_UNIT_SPELL_EFFECT,Condition(function SafeFilt))
    set i = i + 1
endloop
 call TriggerAddCondition (trig, Condition (function Conditions ) )
 call TriggerAddAction (trig, function Actions )
 set trig = null
 endfunction

endscope
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +1
  • V-SNES V-SNES:
    Happy Friday!
     +1

      The Helper Discord

      Members online

      Online now:
      262 (members: 1, guests: 261)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top