Discussion Total JassHelper overhaul project

[Lyerae]

I'm starting to think indentation-based code might be a good thing for the JASS community. You won't have to deal with completely unreadable scripts, as the compiler will enforce a strict indentation-style.

 

[Narks]

a strict indentation style which prevents coders from compacting code

eg.

if (b == true) { a = 1; } else { a = 0; }

as opposed to

if (b == true)
    a = 1
else
    a = 0

message = "Hello world" + CONST_SPACE_THING + "some other stuff" 
    + CONST_OBNOXIOUS_NAME + "very long indeed" + CONST_I_HATE_PHP 
    + "this could go on for a fair bit" + GetPlayerName(GetTriggerPlayer()) 
    + GetColor(GetPlayerId(GetTriggerPlayer()));

opposed to

message = "Hello world" + CONST_SPACE_THING + "some other stuff" + CONST_OBNOXIOUS_NAME + "very long indeed" + CONST_I_HATE_PHP + "this could go on for a fair bit" + GetPlayerName(GetTriggerPlayer()) + GetColor(GetPlayerId(GetTriggerPlayer()))

how anyone can find this readable is beyond me:

	$inputUsername = trim($_POST['inputLoginUsername'], "|")
	$inputPassword = trim($_POST['inputLoginPassword'], "|")
	$filename = "customers.txt"
	
	if (is_readable($filename))

		if (!$file = fopen($filename, "r")) 
			echo "<p>Cannot open customers.txt!</p>"
			exit
		
		$record = explode("|", fgets($file))

		while (!feof($file))
			$username = $record[1];
			$password = $record[2];

			if ($inputUsername == $username && $inputPassword == $password)
				$_SESSION['currentLogin'] = $username
				fclose($file)
				header("location:home.php")

			$record = explode("|", fgets($file))
		
		fclose($file)
		header("location:login_failed.php")
		exit
	else
		echo "<p>Could not read customers.txt - does it exist, and is it
		readable?</p>"
		exit
	echo "hello world"

 

[Bribe]

What language is that? Looks like a mix of PHP and Python with a touch of "huh?"

Anyway, perhaps I should reveal what the syntax looks like when properly highlighted:

 

[tooltiperror]

That is some seriously ugly syntax highlighting.

 

[Bribe]

That is some seriously ugly syntax highlighting.

Thank god for configuration, right?