Trigger Dificulties

Naga'sShadow

Ultra Cool Member
Reaction score
49
I've got a trigger designed to add damage to an arrow ability. I can't see a problem with it and the phraser has no issues with it, but in testing the move does nothing and I'm not sure whats wrong. Could someone please let me know if they see anything that doesn't work?

JASS:
function OoD_Detect takes nothing returns boolean
    if GetTriggerEventId()==EVENT_PLAYER_UNIT_ATTACKED and GetUnitAbilityLevel(GetAttacker(),'A0AR')>0 then        
        return true           
    elseif GetTriggerEventId()==EVENT_PLAYER_UNIT_SPELL_EFFECT and GetSpellAbilityId()=='A0AR' then        
        return true        
    endif
    return false
endfunction

function OoD_Effects takes nothing returns nothing
    local unit targ = GetTriggerUnit()
    local unit cast = GetEventDamageSource()
    local texttag t
    local real dam
            
    if GetUnitAbilityLevel(targ,'B00D')>0 and GetUnitAbilityLevel(cast,'A0AR')>0 then
        if IsUnitType(targ,UNIT_TYPE_HERO) then
            set dam = (GetUnitAbilityLevel(cast, 'A0AR')*GetHeroInt(cast,true) - GetHeroInt(targ,true))
                if dam <= 0 then
                    set dam = (GetUnitAbilityLevel(cast, 'A0AR')* 25)
                endif 
            else 
                set dam = (GetUnitAbilityLevel(cast, 'A0AR')* 25)
        endif 
        
        call DisableTrigger(GetTriggeringTrigger())                        
        set t = CreateTextTag()
        call SetTextTagText(t,"+"+I2S(R2I(dam)),.023)
        call SetTextTagPosUnit(t,targ,15)
        call SetTextTagColor(t,255,105,180,50)               
        call SetTextTagVelocity(t,.0355 * Cos(90 * bj_DEGTORAD),.0355 * Sin(90 * bj_DEGTORAD))
        call SetTextTagLifespan(t,1.)
        call UnitDamageTarget(cast,targ,dam,false,false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_MIND,null)                
        call PolledWait(1.)
        call DestroyTextTag(t) 
        set t = null                   
    endif

    set targ = null
    set cast = null       
endfunction

function OoD_Detect_Actions takes nothing returns nothing
    local trigger trig = CreateTrigger()  
    local triggeraction ta  
    local unit u
    
    if GetTriggerEventId()==EVENT_PLAYER_UNIT_SPELL_EFFECT then        
        set u = GetSpellTargetUnit()
    else        
        set u = GetTriggerUnit()
    endif
    call TriggerRegisterUnitEvent(trig,u, EVENT_UNIT_DAMAGED)
    set ta = TriggerAddAction(trig, function OoD_Effects)
    call PolledWait(2)

    call DisableTrigger(trig)
    call TriggerRemoveAction(trig,ta)    
    call DestroyTrigger(trig)     
     
    set ta = null  
    set u = null
    set trig = null
endfunction

function InitTrig_Orb_of_Dreams takes nothing returns nothing
    local trigger gg_trg_OoD
    set gg_trg_OoD = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ(gg_trg_OoD, EVENT_PLAYER_UNIT_ATTACKED)
    call TriggerRegisterAnyUnitEventBJ(gg_trg_OoD, EVENT_PLAYER_UNIT_SPELL_EFFECT)        
    call TriggerAddCondition(gg_trg_OoD, Condition(function OoD_Detect))
    call TriggerAddAction(gg_trg_OoD, function OoD_Detect_Actions)
    set gg_trg_OoD = null
endfunction


*Edit I removed the wait in that section to see if it made any difference in the trigger's execution. It didn't and removing the disable and destroy function had no effect either.*

*Edit 2 nevermind, I flubed up and used the wrong buff. If you spot a leak let me know please.*
 

Artificial

Without Intelligence
Reaction score
326
How are you supposing the trigger you create in the actions to run if you disable it, remove its actions, and destroy it immediately after you've created it and added the event and action?
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top