Trigger problem-almost freezes game

S

SilentDragon

Guest
Dwarf Drop - Catapults a dwarven tank into target location dealing damage and summoning dwarven riflemen.

Problem - 3-4 casts in gets kind of jerky
5+ capable of freezing game

Code:
Code:
Dwarf Drop
    Events
        Unit - A unit Begins casting an ability
    Conditions
        (Ability being cast) Equal to Dwarf Drop 
    Actions
        Set Spell_DDrop_Caster = (Position of (Casting unit))
        Set Spell_DDrop_Pos = (Target point of ability being cast)
        Set Spell_DDrop_Avail = (Spell_DDrop_Max - Spell_DDrop_Current)
        Unit - Create 1 Dummy Caster (DD) for (Owner of (Casting unit)) at Spell_DDrop_Caster facing Spell_DDrop_Pos
        Unit - Order (Last created unit) to Attack Ground Spell_DDrop_Pos
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        Sound - Play Catapult <gen> at 100.00% volume, located at Spell_DDrop_Caster with Z offset 0.00
        Wait 1.20 seconds
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Spell_DDrop_Avail Greater than or equal to 2
            Then - Actions
                Unit - Create 2 Spell_DDrop_Type for (Owner of (Casting unit)) at Spell_DDrop_Pos facing Default building facing degrees
                Set Spell_DDrop_Current = (Spell_DDrop_Current + 2)
                Sound - Play Dwready <gen> at 100.00% volume, located at Spell_DDrop_Pos with Z offset 0.00
                Custom script:   call RemoveLocation (udg_Spell_DDrop_Caster)
                Custom script:   call RemoveLocation (udg_Spell_DDrop_Pos)
                Skip remaining actions
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Spell_DDrop_Avail Equal to 0
            Then - Actions
                Unit - Create 3 Sheep Bomb for (Owner of (Casting unit)) at Spell_DDrop_Pos facing Default building facing degrees
            Else - Actions
                Unit - Create 1 Spell_DDrop_Type for (Owner of (Casting unit)) at Spell_DDrop_Pos facing Default building facing degrees
                Set Spell_DDrop_Current = (Spell_DDrop_Current + 1)
                Sound - Play Dwready <gen> at 100.00% volume, located at Spell_DDrop_Pos with Z offset 0.00
                Custom script:   call RemoveLocation (udg_Spell_DDrop_Caster)
                Custom script:   call RemoveLocation (udg_Spell_DDrop_Pos)

I downloaded the leak checker and it says it's leakless other than the two I have removed at end. I'm wondering if the sounds cause leaks? they are imported from the first warcraft game. other than that I have no idea how to fix, it used to be worse...(works the same wether if/then/elses are all one stream)

IMPORTANT FACTS:
-you have max of four that increases via another (perfectly fine) trigger by higher levels.
-current goes up on creation
-current goes down on death (nother perfectly fine trigger)
-I don't want dwarves to go away by anything but death

major thanks for ANY useful help I get
 
General chit-chat
Help Users
  • The Helper The Helper:
    I just got to watch the video because even though I was there I was trying to work out tech problems with the chat since I was the social media guy so I was distracted but check it out guys the video is super fucking great!
    +1
  • WildTurkey WildTurkey:
    is there a stephen green in the house?
    +1
  • The Helper The Helper:
    What is up WildTurkey?
  • The Helper The Helper:
    Looks like Google fixed whatever mistake that made the recipes on the site go crazy and we are no longer trending towards a recipe site lol - I don't care though because it motivated me to spend alot of time on the site improving it and at least now the content people are looking at is not stupid and embarrassing like it was when I first got back into this like 5 years ago.
  • The Helper The Helper:
    Plus - I have a pretty bad ass recipe collection now! That section of the site is 10 thousand times better than it was before
  • The Helper The Helper:
    We now have a web designer at my job. A legit talented professional! I am going to get him to redesign the site theme. It is time.
  • Varine Varine:
    I got one more day of community service and then I'm free from this nonsense! I polished a cop car today for a funeral or something I guess
  • Varine Varine:
    They also were digging threw old shit at the sheriff's office and I tried to get them to give me the old electronic stuff, but they said no. They can't give it to people because they might use it to impersonate a cop or break into their network or some shit? idk but it was a shame to see them take a whole bunch of radios and shit to get shredded and landfilled
  • The Helper The Helper:
    whatever at least you are free
  • Monovertex Monovertex:
    How are you all? :D
    +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top